Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63988200
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private PlugNicAnswer execute(final PlugNicCommand
cmd) {
}
}
+ private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+ File keyFile = getSystemVMKeyFile();
+ try {
+ File file = new File(cmd.getSrc());
+ if(file.exists()) {
+ if(file.isDirectory()) {
+ for (File f : FileUtils.listFiles(new
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+ SshHelper.scpTo(cmd.getVmIp(), 3922, "root",
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+ }
+ } else {
+ SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile,
null, cmd.getDest(), file.getCanonicalPath(), null);
+ }
+ }
+ } catch (Exception e) {
--- End diff --
SshHelper is throwing Exception so I am catching Exception. If you are
talking about handling it here and not passing to CopyFileInVmAnswer then
CopyFileInVmAnswer is just passing the exception message and not full
exception. Applicable constructor from CopyFileInVmAnswer
public CopyFileInVmAnswer(CopyFileInVmCommand cmd, Exception e) {
super(cmd, false, e.getMessage());
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
