Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r59501528
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigCmd.java ---
@@ -0,0 +1,73 @@
+// Licensed to the Apache Softwar
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-209265910
@jburwell please restart the jenkins run (force push/close re-open) The
logs have been deleted from jenkins.
---
If your project is set up for it, you can rep
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-209286654
### ACS CI BVT Run
**Sumarry:**
Build Number 172
Hypervisor xenserver
NetworkType Advanced
Passed=18
Failed=63
Skipped=3
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59510155
--- Diff: api/src/org/apache/cloudstack/acl/RoleService.java ---
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59512724
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java ---
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Found
Welcome Rashmi
Kind Regards
Giles
Regards,
Giles Sirett
giles.sir...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London WC2N 4HSUK
@shapeblue
-Original Message-
From: Tutkowski, Mike [mailto:mike.tutkow...@netapp.com]
Sent: 08 April 2016 06:12
To: dev@cloudstac
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59513157
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/acl/ListRolePermissionsCmd.java
---
@@ -0,0 +1,104 @@
+// Licensed to the Apache Soft
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59513255
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/acl/ListRolesCmd.java ---
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Founda
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59513920
--- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59514254
--- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under on
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59514329
--- Diff: api/test/org/apache/cloudstack/acl/RuleTest.java ---
@@ -0,0 +1,39 @@
+package org.apache.cloudstack.acl;
--- End diff --
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59514818
--- Diff: engine/schema/src/com/cloud/user/AccountVO.java ---
@@ -83,8 +86,16 @@ public AccountVO(String accountName, long domainId,
String networkD
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59515911
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/acl/CreateRolePermissionCmd.java
---
@@ -0,0 +1,121 @@
+// Licensed to the Apache Sof
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59516247
--- Diff: server/src/org/apache/cloudstack/acl/RoleManagerImpl.java ---
@@ -0,0 +1,242 @@
+package org.apache.cloudstack.acl;
--- End diff --
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-209326684
One blocker found so far, some license headers missing.
Otherwise looks good, I wish I could say i had completely scrutinised this.
It is a big chunk. I hav
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-209347260
@DaanHoogland thanks, I'll fix them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59522641
--- Diff: api/src/org/apache/cloudstack/acl/RoleService.java ---
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59523317
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java ---
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Foundatio
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59523371
--- Diff: engine/schema/src/com/cloud/user/AccountVO.java ---
@@ -83,8 +86,16 @@ public AccountVO(String accountName, long domainId,
String networkDomai
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59524315
--- Diff: api/src/org/apache/cloudstack/acl/RoleService.java ---
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user nnesic closed the pull request at:
https://github.com/apache/cloudstack/pull/1191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1191#issuecomment-209360865
We need to re-submit this on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/1373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1373#issuecomment-209361378
We have found that this fix actually does not work on 4.7+. We are going to
submit a new pull request based on 4.7 with a working fix.
---
If your project is s
GitHub user sverrirab opened a pull request:
https://github.com/apache/cloudstack/pull/1490
Installing bzip2 since it is required for extracting templates
If you do not install bzip2, then installing templates that are bzip2
compressed will result in Cloudstack not being able to ext
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-209390353
@rafaelweingartner I've written a simple test which will fail if someone
throws an exception and it is not caught. I've tried mocking the `s_logger` but
for it to work
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-209431789
@syed sorry the delay, I just read your email asking for some assistance;
it is the time zone :(
I have opened a PR to your branch with the test c
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1491
Fixes regarding VOLUME_DELETE events resulting from account deletion.
New version of #1373, but updated for the 4.7 branch with another fix that
allows it to properly find expunged root vol
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-209435788
@syed I have seen the code, and I believe we could work a little bit here.
Are you willing to?
For instance, class "NfsSecondaryStorageResource" l
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-209446471
@swill LGTM -- passes static analysis and unit tests + code looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-209461264
Ok, thanks. I will add to merge list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1412#issuecomment-209530633
What do we do about this since it is against the 4.6 branch? Do you want
to close this and open it against the 4.7 branch?
---
If your project is set up for it, you
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-209533275
The current workflow, as I understand it, is that the oldest supported
release branch is for bug fixes (which are then forward-merged), and any new
features go
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-209533528
Yes exactly, but the oldest supported branch right now is 4.7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1412#issuecomment-209533591
Since it's a bug fix, according to the current CS workflow it should be put
on the oldest supported release branch and then forward merged. I can resubmit
it ag
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1406#issuecomment-209531960
another one against 4.6. how should we be handling this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1492
[CLOUDSTACK-9003] Resource Naming Policies
Pull request #988, completed and reinvented.
This is an initial submission, a request for commentary.
This started with attemptin
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1492#issuecomment-209550386
Jenkins build is currently failing on this due to needing to "resolve index
first." Seems like an issue with the build server.
---
If your project is set up fo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-209626989
### CI bubble run
initially test_02_redundant_VPC_default_routes failed. On manual
verification it succeeded.
```
[roo
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1492#issuecomment-209634604
@ProjectMoon correct resource naming is critical to the proper operation of
the management server. We have had a significant bugs and production issues
caused by
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1493
utils: Use non-blocking SSL handshake in NioConnection/Link
- Uses non-blocking socket config in NioClient and NioServer/NioConnection
- Scalable connectivity from agents and peer clustered
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-209649226
Note: in general there are a lot of issue with the Java code around
variable names, class scope/usage, protected/private usage but I've tried to
keep minimal chang
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-209649764
@DaanHoogland I forced pushed which triggered both Travis and Jenkins to
rebuild PR. However, the Jenkins details link still yields a 404. Any
thoughts on how I
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59629317
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,150 @@ public static SSLContext initSSLContext(boolean
isClient) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59629406
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,150 @@ public static SSLContext initSSLContext(boolean
isClient) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59631427
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,150 @@ public static SSLContext initSSLContext(boolean
isClient) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59631614
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,150 @@ public static SSLContext initSSLContext(boolean
isClient) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59632482
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,150 @@ public static SSLContext initSSLContext(boolean
isClient) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59632722
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,150 @@ public static SSLContext initSSLContext(boolean
isClient) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59632745
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,150 @@ public static SSLContext initSSLContext(boolean
isClient) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59633131
--- Diff: utils/src/main/java/com/cloud/utils/nio/NioClient.java ---
@@ -36,52 +36,39 @@
private static final Logger s_logger =
Logger.getLogge
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59633344
--- Diff: utils/src/main/java/com/cloud/utils/nio/NioClient.java ---
@@ -36,52 +36,39 @@
private static final Logger s_logger =
Logger.getLogge
Hi,
Has anyone recently observed the following behavior:
http://imgur.com/8ALJmWb
As you can see in the image, I have three 6.5 XenServer hosts in a resource
pool.
I just used them when creating a basic zone and the system VMs were deployed
just fine. However, there are SRs pointing to se
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1491#discussion_r59644306
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account,
long callerUserId,
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1491#discussion_r59644462
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account,
long callerUserId,
Just an FYI, but when I kicked off my first VM in this cloud, the VR happened
to get deployed to XenServer-6.5-3 (which was one of my XenServer hosts that
had an un-expected shared SR pointing at secondary storage beforehand).
Once the process of copying the system template down to local storage
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-209759974
For sure @rafaelweingartner. As I have outlined in my mail to you, I've
been basically following the practices that have been put in place by the
previous developers.
57 matches
Mail list logo
