Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59522641
--- Diff: api/src/org/apache/cloudstack/acl/RoleService.java ---
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.acl;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+
+import java.util.List;
+
+public interface RoleService {
+
+ ConfigKey<Boolean> EnableDynamicApiChecker = new ConfigKey<>("Hidden",
Boolean.class, "dynamic.apichecker.enabled", "false",
+ "If set to true, this enables the dynamic role-based api
access checker and disables the default static role-based api access checker.",
+ true);
+
+ boolean isEnabled();
+ Role findRole(final Long id);
+ Role createRole(final String name, final RoleType roleType, final
String description);
+ boolean updateRole(final Role role, final String name, final RoleType
roleType, final String description);
+ boolean deleteRole(final Role role);
+
+ RolePermission findRolePermission(final Long id);
+ RolePermission createRolePermission(final Role role, final Rule rule,
final RolePermission.Permission permission, final String description);
+ boolean updateRolePermission(final RolePermission rolePermission,
final Rule rule, final RolePermission.Permission permission, final String
description);
+ boolean deleteRolePermission(final RolePermission rolePermission);
+
+ List<Role> findAllRolesBy(final Long id, final String name, final
RoleType roleType);
--- End diff --
This method tries to solve data processing for listRoles API, it can list
by id (i.e. if exists, single item returned) , or returns list of role matching
a name, or if nothing else passed checks if a role type was passed.
@DaanHoogland do you want me to split them up into separate methods?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
