Build failed in Jenkins: build-master-slowbuild #3528

See -- [...truncated 497 lines...] [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-framework-managed-context --- [debug] execute contextualize [INFO] Using

Re: Masters Thesis on False Alarms in Test Failures

Hi Daan, I have a set of JIRA issue IDs from the authors (and can generate an updated list). These issues are Test Bugs. However, what is more interesting are the causes of these False Positives. To determine what category the Test Bug belongs to requires looking into the JIRA issue, comments,

Volunteers wanted: Masters Thesis on False Alarms in Test Failures

People, Do we have enough meat on the bones to see this through? On Fri, Apr 8, 2016 at 9:26 AM, Kevin van den Bekerom < k.vandenbeke...@sig.eu> wrote: > Hi Daan, > > I have a set of JIRA issue IDs from the authors (and can generate an > updated list). These issues are Test Bugs. However, what is

[GitHub] cloudstack pull request: Remove unused images

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-207355341 :) still cleaning, good job. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

Re: Introduction

While I know we all want these answers, I doubt the 'new guy' is going to be able to speak to that. :P Welcome. I look forward to working with you. On Apr 8, 2016 1:58 AM, "Erik Weber" wrote: On Fri, Apr 8, 2016 at 6:58 AM, Rashmi Dixit wrote: > Hello! > > I am Rashmi Dixit and have recently j

Re: Introduction

That's why I added 'or someone else' :-) Anyway, it's great to see the increased activity in the community these days, not just from Accelerite, but from everyone! -- Erik On Fri, Apr 8, 2016 at 1:15 PM, Will Stevens wrote: > While I know we all want these answers, I doubt the 'new guy' is go

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

GitHub user kiwiflyer opened a pull request: https://github.com/apache/cloudstack/pull/1479 Cloudstack-9285 exception log addition After discussion with @miguelaferreira on the previous PR related to Cloudstack-9285, we decided on adding additional exception logging for this issue.

Re: Introduction

Heartily agree, and welcome Rashmi!! On Friday, 8 April 2016, Erik Weber wrote: > That's why I added 'or someone else' :-) > > Anyway, it's great to see the increased activity in the community these > days, not just from Accelerite, but from everyone! > > -- > Erik > > On Fri, Apr 8, 2016 at 1:1

[GitHub] cloudstack-docs pull request: Add note in dev.rst about use of the...

GitHub user phillipkent opened a pull request: https://github.com/apache/cloudstack-docs/pull/17 Add note in dev.rst about use of the safe option in urllib.quote_plus() There is a mismatch between the URL encoding behavior of Python and CloudStack's internal URL encoder (Java URLEnc

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1230#discussion_r59020704 --- Diff: engine/storage/snapshot/pom.xml --- @@ -37,6 +37,11 @@ test-jar test + + org.apac

[GitHub] cloudstack pull request: Remove classes with no references

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-207423945 @swill , @DaanHoogland , Now everything is ok here. @GabrielBrascher was a little busy, so I did the rebase for him. --- If your project is set u

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207424478 It looks like I have two LGTM on this PR and the tests are passing. This one is ready? Any final comments? --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207425226 @swill no final comments ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

Re: Introduction

> 'new > ​***' > ​very welcome Rashmi, I hope you will feel comfortable in our snug little community.​ -- Daan

[GitHub] cloudstack pull request: Improve ordering of fields of VPC router ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1422#issuecomment-207434231 @swill this is a well tested UI change with several LGTM, can you(we) merge? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207434839 Hi @rafaelweingartner I executed sql in my env and succeeded, is there a way to trace which line failed? --- If your project is set up for it, you can reply to th

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1263#discussion_r59026583 --- Diff: server/src/com/cloud/api/ApiServer.java --- @@ -223,10 +226,7 @@ private static ExecutorService s_executor = new ThreadPoolExecutor(10,

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1263#discussion_r59026830 --- Diff: server/src/com/cloud/api/ApiServer.java --- @@ -1340,37 +1340,31 @@ public String getSerializedApiError(final ServerApiException ex, final Map ge

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1263#discussion_r59026874 --- Diff: server/src/com/cloud/api/ApiServlet.java --- @@ -156,7 +158,7 @@ void processRequestInContext(final HttpServletRequest req, final HttpServletResp

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207440848 @nvazquez, it is complain about a column called "size" at the "schema-40to410.sql" > schema-40to410.sql: Duplicate column name 'size' That

[GitHub] cloudstack pull request: CLOUDSTACK-8611:Handle SSH if server "for...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1459#issuecomment-207446285 @rafaelweingartner now I am ensuring that the "Thread.sleep()" method is being called properly. Also I removed the method that was checking if the session w

[GitHub] cloudstack pull request: Removed unused methods from EventBus inte...

Github user pedro-martins closed the pull request at: https://github.com/apache/cloudstack/pull/1260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-207452373 It's all set to go. :-) On Apr 8, 2016, at 7:09 AM, Rafael Weing?rtner mailto:notificati...@github.com>> wrote: @swill

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207454618 It failed again, I can try pushing sql by parts to find out which part is failing --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-207460552 Do we need the tests in all child-test classes? otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: Remove classes with no references

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-207466536 @rafaelweingartner the merge errors occured during testing as merging is part of the integration tests. I agree with @swill about the test being needed for thi

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-207470025 @DaanHoogland that is a good question. The point here is that it is an abstract class being tested. So, instead of removing the abstract from that class,

[GitHub] cloudstack pull request: Remove classes with no references

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-207470758 @DaanHoogland I understand your points on requiring functional tests and accept it. Even after the rebase I did today, you had problems while testing

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207471025 @nvazquez did it fail with the problem? for me it is showing as executing and not failed. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207472873 @rafaelweingartner sorry I pushed force again, after the whole file failed I pushed a part of sql file and pushed it and started again --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207473461 Now the error is different, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1263#discussion_r59043684 --- Diff: server/src/com/cloud/api/ApiServlet.java --- @@ -156,7 +158,7 @@ void processRequestInContext(final HttpServletRequest req, final HttpS

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-207488773 @pdube removed those uderscores, also I modified the "com.cloud.api.ApiServer.setEncodeApiResponse(boolean)" method to static again. Thanks. --- If your p

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1263#issuecomment-207490720 Built the package LGTM after review [INFO] [INFO] Reactor Summary: [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207498927 Yes, this test failed, but I didn't see schema error this time === TestName: test_listVM_by_id_as_user_vmsfromotherdomain | Status : EXCEPTION === ERRO

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207501906 @kiwiflyer shouldn't the `s_logger.warn("NIO Connection Exception " + e);` be after the info `s_logger.info("Attempted to connect")`? --- If your proje

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207504054 @GabrielBrascher The reason I placed it before is because the follow on log message is basically informing that a reconnect attempt was going to be attempted nex

Re: Introduction

Welcome! :) -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Rashmi Dixit" > To: dev@cloudstack.apache.org > Sent: Friday, 8 April, 2016 05:58:24 > Subject: Introduction > Hello! > > I am Rashmi Dixit and have recently joined the Clo

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207507877 Got it @kiwiflyer. I am good with the way it is. Simple logger change, the code LGTM. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Improve ordering of fields of VPC router ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1422#issuecomment-207510466 Yes, I think this is good. I will add it to the list of merges I will do later today. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack-docs pull request: Add note in dev.rst about use of the...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-docs/pull/17#issuecomment-207517322 LGTM, I tested this against ACS 4.5 whenever an API arg (of type string) has an asterisk between text (something like arg="some*value"). When @phillipkent origi

[GitHub] cloudstack-docs pull request: Add note in dev.rst about use of the...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-docs/pull/17#issuecomment-207517469 I've also find this to be an issue with Marvin, and the same fix works with Marvin as well. I'll be send that PR soon. --- If your project is set up for it, yo

Re: Introduction

Welcome Rashmi, look forward to seeing great contributions! Ahmad E > On Apr 7, 2016, at 9:58 PM, Rashmi Dixit wrote: > > Hello! > > I am Rashmi Dixit and have recently joined the CloudPlatform team in > Accelerite. I have worked on a hybrid cloud management solution supporting > hypervisors

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1478#issuecomment-207524802 PR https://github.com/apache/cloudstack/pull/872 is going to replacing openswan with strongswan. I believe PFS is depreciated in strongwan, so it might ma

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1478#issuecomment-207526795 ah, thanks @kiwiflyer . How do i change this to 4.7.x? Also i check PR #872 and the PFS code looks good there, it is totally re-written. --- If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1478#issuecomment-207528583 @Slair1 You can checkout the 4.7 branch and then create a new branch. Apply the patch and then push that new local branch back up to your github ACS fork. Then cr

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1478#issuecomment-207530559 @kiwiflyer thanks, how do i delete this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1478#issuecomment-207531252 @Slair1 You should have a close button below the comments section. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1478#issuecomment-207531359 @kiwiflyer , wow i feel stupid now :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user Slair1 closed the pull request at: https://github.com/apache/cloudstack/pull/1478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1478#issuecomment-207533662 @Slair1 If you create a new PR or if a different PR solves the problem you ran into, can you please post the PR number that replaces this one? This helps me maintain

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez closed the pull request at: https://github.com/apache/cloudstack/pull/1466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207534182 are you still going to push this forward? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

GitHub user nvazquez reopened a pull request: https://github.com/apache/cloudstack/pull/1466 CLOUDSTACK-9340: General DB Optimization ## Description In some production environments there were being experimented delays in most of the jobs. A search for DB optimization was taken a

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207535135 @rafaelweingartner yes, it was my mistake. I wanted to leave the pr with no changes to test if Travis passes, I didn't know that removing my commits will close the

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207535756 Here are my updated Marvin tests for this feature: [TestSnapshots.py.txt](https://github.com/apache/cloudstack/files/210618/TestSnapshots.py.txt)

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207536244 Can you rebase and give me a squashed commit for this? Also, regarding the code. I have seen a lot of people cleaning up code to remove the `_` in front of t

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207537254 Just for the future reference. If you want to kick off the rebuild of a PR, you can do a `push -f` which will trigger a new build even if the code did not change in

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207537198 Simply added a log warning. Built it LGTM [INFO] [INFO] Reactor Summary: [INFO]

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207537423 Hi @swill - No problem for me to squash the commits, but are you sure you want to lose the history of the individual commits? Also, from what I've se

[GitHub] cloudstack pull request: Cloudstack-9285 exception log addition

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1479#issuecomment-207539579 Can you squash your commits and do a `push -f` to update your branch so this gets merged as a single commit? This does not change anything that could fail via

[GitHub] cloudstack pull request: CID-1338387: Deletion of method endPointS...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1124#issuecomment-207540194 @swill, @DaanHoogland What about this one? I have just rebased it. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207542455 I have not seen a style guide, but I have not looked. I have just seen a bunch of PRs recently and there seems to be a consistent work to remove the `_`s in the code

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

GitHub user Slair1 opened a pull request: https://github.com/apache/cloudstack/pull/1480 CLOUDSTACK-9342: Site to Site VPN PFS not being set correctly Bug in code set PFS to the same value (yes/no) as DPD. file.addeq(" pfs=%s" % CsHelper.bool_to_yn(obj['dpd'])) You can merg

[GitHub] cloudstack pull request: CLOUDSTACK-9342: Site to Site VPN PFS not...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1478#issuecomment-207543327 Create new PR #1480 in 4.7 branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207543372 No problem, @swill, I can just squash them all. I was just thinking that the fact that we are merging can preserve the individual history better (in a differ

Re: PRs for 4.9 Release

Hi Will, Thanks for all the effort you've put into getting the PRs moving. This is huge for the community. >From my side, I have these two PRs which I think are critical as they fix broken functionality. https://github.com/apache/cloudstack/pull/1423 : This fixes client side VPN failure due to I

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207550783 Thanks @swill, I just wanted to remove all my commits for Travis test to run without my changes, but doing that closed the pr. Now I pushed a commit including a co

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207551688 Oh, I understand. Thanks... :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-207553542 @syed I have not looked into this. Is it possible for us to improve the test so it actually tests that the VPN works? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207554051 @mike-tutkowski @swill I don't think a formal guideline has been set, but we have been pushing toward adopting more idiomatic Java naming conventions. The use of

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207554891 @mike-tutkowski why can't the Marbin test cases be checked in? While we can't run them, it would be nice to review them to understand exactly how the feature is b

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207555843 The CloudStack community can definitely have those tests, if it wants them. Right now, however, we don't have any way to enable other people (besides

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-207555946 @syed can you squash the commits please and do a `push -f` to update the PR branch? Do you have any feedback for @kollyma if he is seeing a similar issue as

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59073124 --- Diff: core/src/org/apache/cloudstack/storage/command/ResignatureCommand.java --- @@ -0,0 +1,46 @@ +// +// Licensed to the Apache Software Fo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59073181 --- Diff: core/src/org/apache/cloudstack/storage/command/ResignatureCommand.java --- @@ -0,0 +1,46 @@ +// +// Licensed to the Apache Software Fo

Re: PRs for 4.9 Release

Thanks for the items syed. I have added them to my active list. *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Fri, Apr 8, 2016 at 2:32 PM, Syed Mushtaq wrote: > Hi Will, > > Thanks for a

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59073600 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java --- @@ -394,6 +394,7 @@ public VolumeInfo createV

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207559800 I'm not sure what the standard for "idiomatic" is here. :) I've pretty much usually seen "_" (and sometimes "m_") used to note a member variable versus a loc

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59074068 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -80,32 +92,48 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59074209 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -114,6 +142,17 @@ private bool

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59074290 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -114,6 +142,17 @@ private bool

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59074279 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -80,32 +92,48 @@

Re: PRs for 4.9 Release

Hi Will, I’d propose to test this one as it fixes a nasty concurrency issue. I runs on prod at SBP for some time now so I’m quite sure it’s solid but let’s run the tests again to be sure. https://github.com/apache/cloudstack/pull/1470 Regards, Remi On 08/04/16 20:56, "williamstev...@gmail

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r5907 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -132,31 +171,52 @@ public void

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59074456 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -132,31 +171,52 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-207562190 You're welcome :) Now Travis failed without including changes (only comment line). Do I try again after Jenkins finishes using push -f? --- If your project i

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59074950 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59075010 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59075048 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59075182 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59075640 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -80,32 +92,48 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-207565521 @mike-tutkowski while we can't run the tests, there is still value in being able to read them to understand how the functionality is being tested. During review,

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59076080 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59076160 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59076292 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59076683 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59076763 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59076866 --- Diff: core/src/com/cloud/agent/api/StartupRoutingCommand.java --- @@ -35,7 +35,7 @@ long memory; long dom0MinMemory;

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r59076982 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private vo

  1   2   >