Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r59074209
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -114,6 +142,17 @@ private boolean canHandle(DataStore dataStore) {
return true;
}
+ } else if (dataObject instanceof TemplateInfo) {
+ // If the storage system can clone volumes, we can cache
templates on it.
+ String value =
mapCapabilities.get(DataStoreCapabilities.CAN_CREATE_VOLUME_FROM_VOLUME.toString());
+ Boolean canCloneVolume = new Boolean(value);
--- End diff --
``new Boolean`` skips the constant pool -- placing unnecessary pressure on
the garbage collector. Use ``Boolean.valueOf`` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
