Re: Help with JUnits

So, yeah, unit tests are written in Java while integration tests are written in Python using Marvin...if that helps clarify things a bit more. On Tue, Jan 19, 2016 at 12:45 AM, B Prakash wrote: > Thanks Mike, I read through the link and also saw the video, this answers > part of my question abou

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1319#discussion_r50086554 --- Diff: ui/scripts/docs.js --- @@ -1008,7 +1008,7 @@ cloudStack.docs = { }, // Add volume helpVolumeName: { -

Build failed in Jenkins: build-master-slowbuild #3022

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1319#issuecomment-172807056 LGTM, the one error in the files below is a known error in the test environment and unrelated. This has been reviewed extensively. [1319.network.resul

Re: [PROPOSAL] LTS Release Cycle

+1 LTS, but FWIW I also think Daan has a point here and it should be taken into consideration. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Daan Hoogland" > To: "dev" > Sent: Tuesday, 19 January, 2016 07:45:57 > Subject: Re: [PRO

Re: [PROPOSAL] LTS Release Cycle

On a certain night when a release had been cut and there was some worry about a security fix not being included. The root cause was that we cherry-picked that fix and as a result its commit hash had changed. Hence we couldn’t find it. I’d recommend using forward merging instead of back porting a

Re: [PROPOSAL] LTS Release Cycle

Maybe require all cherry-picks to use the -x option, which puts the original commit hash in the cherry-picked commit message? On Tue, Jan 19, 2016 at 10:53 AM, Remi Bergsma wrote: > On a certain night when a release had been cut and there was some worry > about a security fix not being included.

Re: [PROPOSAL] LTS Release Cycle

Jeff, That we did before. I don't think that's good enough. It must be the same commit as far as I'm concerned. Any conflict will be made explicit in a merge commit that way. On Tue, Jan 19, 2016 at 12:08 PM, Jeff Hair wrote: > Maybe require all cherry-picks to use the -x option, which puts the

[ANNOUNCE] New PMC member: Boris Roman Schrijver

The Project Management Committee (PMC) for Apache CloudStack is pleased to announce that Boris Roman Schrijver has accepted our invitation to join the PMC. Please join me in congratulating him. On behalf of the Apache CloudStack PMC Wilder Rodrigues

Build failed in Jenkins: build-master-slowbuild #3023

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Better later than never! :) Welcome, dude! Let’s make this boat rock! Cheers, Wilder > On 19 Jan 2016, at 13:15, Wilder Rodrigues > wrote: > > The Project Management Committee (PMC) for Apache CloudStack is pleased to > announce that Boris Roman Schrijver has accepted our invitation to join t

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

On Tue, Jan 19, 2016 at 1:15 PM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > The Project Management Committee (PMC) for Apache CloudStack is pleased to > announce that Boris Roman Schrijver has accepted our invitation to join > the PMC. > > Please join me in congratulating him. > >

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Well done Boris, looking forward for more contributions from you > On Jan 19, 2016, at 1:17 PM, Erik Weber wrote: > > On Tue, Jan 19, 2016 at 1:15 PM, Wilder Rodrigues < > wrodrig...@schubergphilis.com> wrote: > >> The Project Management Committee (PMC) for Apache CloudStack is pleased to >> an

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Welcome Boris! :) On 19-01-16 13:15, Wilder Rodrigues wrote: > The Project Management Committee (PMC) for Apache CloudStack is pleased to > announce that Boris Roman Schrijver has accepted our invitation to join the > PMC. > > Please join me in congratulating him. > > On behalf of the Apache Cl

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Congrats, Boris. :) -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Wilder Rodrigues" > To: dev@cloudstack.apache.org > Sent: Tuesday, 19 January, 2016 12:15:42 > Subject: [ANNOUNCE] New PMC member: Boris Roman Schrijver > The Projec

[GitHub] cloudstack-cloudmonkey pull request: Summary: Allow 'sync' as a ve...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/12#issuecomment-172875848 LGTM, merging. Thanks for fixing this @waegemae --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack-cloudmonkey pull request: Summary: Allow 'sync' as a ve...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-cloudmonkey/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Congrats and welcome Boris! > [ShapeBlue] Rohit Yadav Software Architect , ShapeBlue d: | s: +44 203 603 0540 | m: +91 8826230892 e: rohit.ya...@shapeblue.com | t: | w:

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Welcome Boris, Hope you stay with us long long time :) On Tue, Jan 19, 2016 at 3:52 PM, Rohit Yadav wrote: > Congrats and welcome Boris! > > > > > [image: ShapeBlue] > Rohit Yadav > Software Architect , ShapeBlue > d: * | s: +44 203 603 0540* <%7C%20s:%20+44%20203%20

Build failed in Jenkins: build-master-slowbuild #3024

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-172892988 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-172903549 @remibergsma I am puzzled. You don't agree with the contents of the PR but you did run the tests? or did I misread your comment? I though you and @agneya2001 d

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-172911093 ok, clear --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

RE: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Congratulations Boris. [ShapeBlue] Paul Angus VP Technology , ShapeBlue d: +44 203 617 0528 | s: +44 203 603 0540 | m: +44 7711 418784 e: paul.an...@shapeblue.com | t: @cloudyangus

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-172908360 @DaanHoogland This PR is better than the current situation and would improve even more if the whole check would disappear. If the PR is changed, I'll happily ru

[GitHub] cloudstack pull request: test: Fix Libvirt test so that it works o...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Vmdk findbugs

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1351 Vmdk findbugs these are two of the findbugs errors coming out of our jenkins all the time. The author seems to be unavailable so I kicked and screamed at it. notice that this is noredi

[GitHub] cloudstack pull request: Vmdk findbugs

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1351#issuecomment-172917596 note that jenkins isn't responding to the PR (so far) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [PROPOSAL] LTS Release Cycle

All, LTS branches will be maintained for 20 months. In that time, some defects will be fixed in an LTS branch and forward merged. Some defects will be identified in master, and we will need to determine whether or not they should be pulled back to one or more of the active LTS branches. As mast

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1352 CLOUDSTACK-9244 Fix setting up RFC1918 routes Public ip var was empty so routes were always set. Corrected this. You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

Github user nislim commented on the pull request: https://github.com/apache/cloudstack/pull/1352#issuecomment-172929285 Fixed my problem, my routing tables are now looking as I expected. Thanks --- If your project is set up for it, you can reply to this email and have your reply a

Build failed in Jenkins: build-master-slowbuild #3025

See Changes: [wido] test: Fix Libvirt test so that it works on Windows [nitin.maharana] CLOUDSTACK-9132: API createVolume takes empty string for name parameter [Rohit Yadav] ui: improve metrics view implementation --

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Congratulations, Boris! On Tue, Jan 19, 2016 at 5:15 AM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > The Project Management Committee (PMC) for Apache CloudStack is pleased to > announce that Boris Roman Schrijver has accepted our invitation to join > the PMC. > > Please join me in

Re: [PROPOSAL] LTS Release Cycle

> Therefore, the process should strive to make as a few releases as necessary to achieve this goal. I guess part two to this question would be - we need the automated testing environments. This can ensure rapid release testing and acutal release, and we dont have to restrains ourselves to limited

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Warm welcome Boris.. On 1/19/16 4:15 AM, Wilder Rodrigues wrote: > The Project Management Committee (PMC) for Apache CloudStack is pleased to > announce that Boris Roman Schrijver has accepted our invitation to join the > PMC. > > Please join me in congratulating him. > > On behalf of the Apach

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-172966645 I have some remarks about style (made one) but the logic looks fine. LGTM --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1352#discussion_r50168987 --- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config --- @@ -1166,6 +1166,9 @@ setup_storage_network() { } setup_sy

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1352#issuecomment-172975452 If this helps @nislim And is tested it should go in. I feel uncertain of this functionality. It is called from sestro and console proxy setup functions but

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1352#issuecomment-172977865 @DaanHoogland I think we agree cloud-early-config needs major refactoring as it is one big copy/paste thing. Just don't think this is the time to do it.

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: [PROPOSAL] LTS Release Cycle

Hi Ilya (and all others), We (ShapeBlue) agree with you regarding the importance of automated integration testing. The consulting team are currently working to understand Marvin fully and what pieces we need to be able deploy properly representative (virtualised) infrastructures to test against

Build failed in Jenkins: build-master-slowbuild #3026

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1352#issuecomment-173002681 Discussed with @DaanHoogland and he sent me a patch ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1352#issuecomment-173002828 @nislim Can you please test the enhanced patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1352#issuecomment-173005222 `cloud-early-config` now logs: ``` Not setting up route of RFC1918 space to 192.168.22.1 befause 192.168.23.2 is RFC1918.. ``` Routes a

Build failed in Jenkins: build-master-slowbuild #3027

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #3028

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: Help with JUnits

Yes it does, thanks. Next I am going through the code to identify a pattern (like class name ending with TEST :-)) to identify junit code. I am unable to zero in on few of the operations ie I am unable to find unit test for this operation UserVmManagerImpl.commitUserVm. I am still looking f

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

Congrats Boris !! On Wed, Jan 20, 2016 at 12:10 AM, ilya wrote: > Warm welcome Boris.. > > On 1/19/16 4:15 AM, Wilder Rodrigues wrote: > > The Project Management Committee (PMC) for Apache CloudStack is pleased > to > > announce that Boris Roman Schrijver has accepted our invitation to join > th

Re: Help with JUnits

I'm not sure what CloudStack's test-coverage numbers look like (for either unit or integration), but I suspect we are quite well below 100% coverage. On Tue, Jan 19, 2016 at 10:34 PM, B Prakash wrote: > Yes it does, thanks. Next I am going through the code to identify a > pattern (like class na

[GitHub] cloudstack pull request: OSPF: WIP: adding dynamically routing cap...

GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1353 OSPF: WIP: adding dynamically routing capability to VPS Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9163 FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dyn

Build failed in Jenkins: build-master-slowbuild #3029

See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1352#issuecomment-173112205 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f