[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168932762 LGTM +1 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Build failed in Jenkins: build-master-slowbuild #2910

See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/1308 Test to create vpn customer gateway with hostname While adding vpn customer gateway for site to site vpn connection, cs should also accept host name apart from gateway ip address. It should n

[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1308#issuecomment-168938202 Test to create vpn customer gateway with hostname ... === TestName: test_22_vpn_customer_gw_with_hostname | Status : SUCCESS === ok --

[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168938400 Thanks @nlivens and @runseb ! Additional question i have : How does this end up now at http://docs.cloudstack.apache.org/en/latest/ ? thanks!

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r48824088 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -479,13 +479,13 @@ def process(self): def deletevpn(self, ip):

[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168939634 It is there (http://docs.cloudstack.apache.org/en/latest/networking/nuage-plugin.html) but should be linked to from the index and networking pages. --- If yo

Re: upgrading 4.5.2 -> 4.6.0 virtualrouter upgrade timeout

Hi Remi, I've not tried the patch. I've missed it. Do I need to rebuild the ACS to apply the patch or would making changes to the two files suffice? Thanks Andrei - Original Message - > From: "Remi Bergsma" > To: "dev" > Sent: Tuesday, 5 January, 2016 05:49:05 > Subject: Re: upgrading

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1199#issuecomment-168940359 LGTM !! Test Results: === Check Snapshots size in database ... === TestName: test_02_snapshot_size_check | Status : SUCCESS ===  ok 

[GitHub] cloudstack-docs pull request: Add Nuage plugin to the list

GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-docs/pull/15 Add Nuage plugin to the list You can merge this pull request into a Git repository by running: $ git pull https://github.com/terbolous/cloudstack-docs master Alternatively you can r

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-168948254 @terbolous Thanks for testing it. @resmo Did you find time to test this feature ? --- If your project is set up for it, you can reply to this email and have you

BVT Report for the week of 1/5

Happy New Year to all! Please see the BVT report KVM Basic - 97.1% XS Basic - 94.0% KVM Adv - 85.8% - action item on me to add configurations for the new tests to run XS Adv - 79.1% - action item on me to add configurations for the new tests to run Failed Tests - same tests from last BVT repor

[GitHub] cloudstack pull request: CLOUDSTACK-9208: Assertion Error in VM_PO...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1307#issuecomment-168964453 +0 code LGTM but the fact that this check is needed is a smell. It points to a possible bug in the statemachine driving the handling of power reports. --- If

[GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1308#discussion_r48831039 --- Diff: test/integration/component/test_vpc.py --- @@ -2490,3 +2498,23 @@ def test_21_deploy_vm_with_gateway_ip(self): "Failed to

Re: BVT Report for the week of 1/5

Raja, thanks. I hve one question: can you produce historic data? preferable graphical so I can kid myself I understand it ;) On Tue, Jan 5, 2016 at 11:13 AM, Raja Pullela wrote: > Happy New Year to all! > > Please see the BVT report > KVM Basic - 97.1% > XS Basic - 94.0% > KVM Adv - 85.8% - act

[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168966438 @terbolous OK thanks - is that something you will take up ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appe

Re: BVT Report for the week of 1/5

On Jan 5, 2016, at 11:13 AM, Raja Pullela wrote: > Happy New Year to all! > > Please see the BVT report > KVM Basic - 97.1% > XS Basic - 94.0% > KVM Adv - 85.8% - action item on me to add configurations for the new tests > to run > XS Adv - 79.1% - action item on me to add configurations for

[GitHub] cloudstack-docs pull request: Add Nuage plugin to the list

Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs/pull/15#issuecomment-168970370 +1 feel free to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168970701 already made a PR for it :) #15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

This PR is related to changes in base.py So ran one test which invokes the changes to make sure the changes works fine. Check Snapshots size in database ... === TestName: test_02_snapshot_size_check | Status : SUCCESS === ok -- R

Re: [GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

Makes sense. I will add code to list vpn customer gateways and will check if the response contains the customer gateway or not. On Tue, Jan 5, 2016 at 3:55 PM, DaanHoogland wrote: > Github user DaanHoogland commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pul

Re: upgrading 4.5.2 -> 4.6.0 virtualrouter upgrade timeout

Hi Andrei, You indeed need to build CloudStack for this to work. You can create packages with ./packaging/package.sh script in the source tree. The PR is against 4.7 and when you create RPMs those will be 4.7.1-SHAPSHOT. I do run this in production and it resolved the issue. Let me know if it w

Build failed in Jenkins: build-master-slowbuild #2911

See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

[GitHub] cloudstack pull request: CLOUDSTACK-9208: Assertion Error in VM_PO...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1307#issuecomment-168977391 @DaanHoogland With the current code, even if the VM is in poweroff(or power report missing) state and stopped state in DB, and receives a stop command, it gets this

Re: [PROPOSE] Dynamic inter VPC routing

Hi Abhi, Few images are not loading in the FS. Can you please correct it. Thanks, Jayapal On 04-Jan-2016, at 7:40 pm, Abhinandan Prateek mailto:abhinandan.prat...@shapeblue.com>> wrote: Hi All, Currently the inter VPC traffic has to go thru the public gateway. This means the traffic has

[GitHub] cloudstack pull request: CLOUDSTACK-9208: Assertion Error in VM_PO...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1307#issuecomment-168983922 @kansal I remember a discussion in a prior PR but not the number. The scenario would be something like hypervisor has been disconnected or rebooted and cloudst

[GitHub] cloudstack pull request: 4.7 quota test

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1306#issuecomment-168987361 More tests is always better! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-168987824 One comment I have on the code. Otherwise it looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1297#discussion_r48840288 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2288,6 +2290,7 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavai

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1291#issuecomment-168988130 LGTM based on the code. Didn't perform a test on it. Trivial fix for some integers. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-168988361 Is there a way to test this quickly or do you have any results? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-168988457 Any other LGTMs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1297#discussion_r48840815 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2288,6 +2290,7 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws Resour

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-168991998 Checked all the commits, re-read the code and LGTM. Based on the tests already performed. --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-168992910 @wido I have not changed logic so am trusting the unit tests and wrote an extra. A run of integration tests might be required by some ;) --- If your project i

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1303#issuecomment-169002502 jenkins passed this one, please point to 4.6 if it contains the problem as well ;) --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1303#issuecomment-169008756 @DaanHoogland Quota is not in 4.6 afaik. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: 4.7 quota test

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.7 quota test

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1306#issuecomment-169015725 This seems to fix the broken unit test. LGTM. ``` [INFO] [INFO] BUILD S

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1303#issuecomment-169016186 @agneya2001 Please close this PR as #1306 is already merged. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

Build failed in Jenkins: build-master-slowbuild #2912

See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

[GitHub] cloudstack pull request: QuotaStatementTest: fix the method invoca...

Github user agneya2001 closed the pull request at: https://github.com/apache/cloudstack/pull/1303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: [PROPOSE] Dynamic inter VPC routing

Jayapal, Can you check if you can see the images ! Cheers ! On 05/01/16, 5:15 PM, "Jayapal Reddy Uradi" wrote: >Hi Abhi, > >Few images are not loading in the FS. Can you please correct it. > >Thanks, >Jayapal > >On 04-Jan-2016, at 7:40 pm, Abhinandan Prateek >mailto:abhinandan.prat...@s

Re: [PROPOSE] Dynamic inter VPC routing

On Mon, Jan 4, 2016 at 3:10 PM, Abhinandan Prateek < abhinandan.prat...@shapeblue.com> wrote: > Hi All, > > Currently the inter VPC traffic has to go thru the public gateway. > This means the traffic has to be nat-ed across public internet via > core-routers, which is inefficient in itself. A

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function This is a mandatory argument but it was NOT passed which caused the re-programming of security groups to fail. S

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169063660 @DaanHoogland @remibergsma @resmo Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169066689 simple fix but a test on the contents in the called method makes sense as well. Not sure how to test. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169067941 @DaanHoogland We do not have any unit testing in place for Python. If you look just 10 lines up you see the method being called exactly that way. Without this

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169069686 Forgot to add, pylint still works fine. It scores 3.54/10. Not great, but a lint check still succeeds. --- If your project is set up for it, you can reply to this ema

Build failed in Jenkins: build-master-slowbuild #2913

See Changes: [Rohit Yadav] QuotaStatementTest: fix the method invocation verification -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbug

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169095290 btw LGTM if you don't want to improve further. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169095187 @wido My point exactly. 10 lines up a conditional should guard the split() call --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1310 CLOUDSTACK-9211: Support passing vRAM size to support 3D GPU on Vmware JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9211 CS support passing hypervisor options by

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-169104666 LGTM, but haven't had the chance to test it yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169117271 @DaanHoogland I agree, this script isn't the best in the world. In my opinion we should offload this work to libvirt: - http://libvirt.org/formatnwfilter.ht

[GitHub] cloudstack pull request: CLOUDSTACK-9208: Assertion Error in VM_PO...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1307#issuecomment-169132663 Agree with @DaanHoogland the code doesn't seem bad and probably fixes the issue. But something is wrong here indeed. Codewise it looks good. --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1298#issuecomment-169132861 Trivial fix indeed. We can ignore this since our goal has been reached. LGTM --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1279#issuecomment-169133233 Did the tests succeed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169133424 @wido will your proposal from CLOUDSTACK-1164 work for other hypervisors as well? --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1279#issuecomment-169133536 Didn't have a chance to test it yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-9210: Pass secondary IPs to de...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1309#issuecomment-169134133 @DaanHoogland No idea. Might work with Xen if we manage those Instances through libvirt. But in case of KVM we can probably do this with libvirt. Might need to patches

[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1287#issuecomment-169134419 Based on the code I don't see anything dangerous though. It still compiles I see ;) --- If your project is set up for it, you can reply to this email and have your re

Build failed in Jenkins: build-master-slowbuild #2914

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2915

See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2916

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [PROPOSE] Dynamic inter VPC routing

[ShapeBlue] Abhinandan Prateek Software Architect , ShapeBlue d: | s: +44 203 603 0540 | m: +91 970 11 99011 e: abhinandan.prat...@shapeblue.com | t: | w: www.s

Build failed in Jenkins: build-master-slowbuild #2917

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack