Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1165#discussion_r47469773
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1889,11 +1889,20 @@ int getReservedCpuMHZ(Vir
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164374286
@priyankparihar Fair enough, please see a code review comment. Once you fix
the null check, I think your PR is good to go. Also, write a unit test to
enforce the c
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1165#discussion_r47469908
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1889,11 +1889,20 @@ int getReservedCpuMHZ(Vir
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/27#issuecomment-164375548
Looks good, but I think it's missing some features:
- quota
- Nuage ?
pinging @remibergsma
---
If your project is set up for it, you can repl
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1236#issuecomment-164376707
@borisroman slf4j sits in a layer above log4j. I?m not sure about the
particular case you are dealing with, however if we were using slf4j with log4j
consis
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-164376871
@priyankparihar As per XenMotion docs: The target host must have the same
or a more recent version of XenServer installed as the source host. So a
migration from
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-164381436
@runseb completely agree. But, what kind of proof should i present ?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164387475
@maneesha-p @remibergsma had a go at it just before the creation of the RC
yesterday nigt but he encountered merge conflicts. Can you have e look? merge
with
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164388358
@bhaisaab I think null check is not required. I have verified( because in
case of null if automatically picks some random value). But if you still think
it
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/27#issuecomment-164388952
- Quota plugin, see PR 768 for screenshots.
- Nicira and Nuage plugins updated
- UI improvements
- >100 smaller bugfixes and improvements
---
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/27#discussion_r47476361
--- Diff: source/upgrade/_sysvm_templates_pre45.rst ---
@@ -18,8 +18,9 @@
Update System-VM templates
--
Github user pdion891 commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/27#discussion_r47476668
--- Diff: source/upgrade/_sysvm_templates_pre45.rst ---
@@ -18,8 +18,9 @@
Update System-VM templates
--
Hi,
As we’re still working on docs/release notes a quick heads-up for those who
want to try upgrades to 4.7.0RC1.
The systemvm template does not need to be changed in 4.7.0, the 4.6.0 version
is still valid and works fine (the changes are in systemvm.iso). Therefore, all
you need to do is stop
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-164395806
>>"So a migration from 6.2 to 6.5 is allowed but not the other way around."
@agneya2001 Currently UI does not allow migration between different
versions,
Github user maneesha-p commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164396034
@DaanHoogland it was due to a latest change in the db file.Pushed
again.Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164399579
thanks @SudharmaJain building again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47480556
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(Qu
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-164401512
@remibergsma
rebase with latest master 7c83e1b2402db9e359fb086b158d65c25309a70e
result of squashing the commits:
(before suqash, 16 commits)
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164401474
@agneya2001 code looks good, one question about the logic. will run the
test.
As this test requires global settings in the server, it would pay to add
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164401688
@priyankparihar I won't be able to give a LGTM without the null check,
split string related code and a unit test that breaks if someone tries to
change the convent
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1241#issuecomment-164402122
@kansal I think this is a good fix but can't be sure. A typical case where
an integration test showing the behaviour would help greatly. I'm sure marvin
can si
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164402621
@wilderrodrigues nice rant and I agree with most except for the part where
it should have been merged. There were objections so this is a clear example of
a th
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1236#issuecomment-164403037
@miguelaferreira good point. It looks like it has been added for that
purpose but never actually used. So now we must choose: start using it or chop
it out.
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47481989
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(Quot
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164404825
@agneya2001 can you still lgtm this?
@maneesha-p thanks I am doing a quick verification install and if all ok
we are fine
---
If your project is set up f
On 12/14/2015 07:25 AM, Sudharma Jain wrote:
> While building Cloudstack on windows, it fails with following exceptions.
>
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.052 sec
> <<< FAILURE! - in com.cloud.utils.TestProfiler
> testProfilerInNano(com.cloud.utils.TestProfile
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1242
test: Fix Libvirt test so that it works on Windows
This test failed on Windows, using the File.separator it should run fine on
Windows.
You can merge this pull request into a Git repository by ru
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1196#issuecomment-164405051
```
[INFO]
[INFO] BUILD SUCCESS
[INFO]
---
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164405451
@DaanHoogland Let me add the DC definition, I still need to figure the
howto part.
---
If your project is set up for it, you can reply to this email and have yo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164406128
i used this file, not all is relevant but the global setting for it are in
there.
```
# Licensed to the Apache Software Foundation (ASF) under one
#
no need to hard code the path. We can use the “File.separator” as it is being
used in the class under test.
Cheers,
Wilder
On 14 Dec 2015, at 11:36, Wido den Hollander
mailto:w...@widodh.nl>> wrote:
On 12/14/2015 07:25 AM, Sudharma Jain wrote:
While building Cloudstack on windows, it fails w
On 12/14/2015 11:45 AM, Wilder Rodrigues wrote:
> no need to hard code the path. We can use the “File.separator” as it is being
> used in the class under test.
>
Indeed, I already filed a PR: https://github.com/apache/cloudstack/pull/1242
> Cheers,
> Wilder
>
> On 14 Dec 2015, at 11:36, Wido
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1242#discussion_r47483781
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
@@ -37,8 +38,8 @@ public void
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47484403
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(Qu
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1240#discussion_r47484456
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -186,7 +186,7 @@ public int compare(Qu
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164411409
@DaanHoogland : In UI, we put the field as required field, so user has to
give some name to create a volume. It cannot be null or blank. But according
the ch
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164412418
@nitin-maharana Your point looks good. Both(UI and API) should be
consistent.
---
If your project is set up for it, you can reply to this email and have you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164415638
I don't agree, for two reasons
1. making the field required constitutes a backwards incompatibility of the
API
2. we should use as much reasonable defau
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-164416731
Have no infra to
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/1243
CLOUDSTACK-9166:Build failed in Jenkins: cloudstack-rat-master #7038
With my last PR#1196, I missed to place the license disclaimer into
CitrixHelperTest.java. Updated the file with the di
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164417605
Hi @nitin-maharana I agree with @DaanHoogland, we should maintain backward
compatibility. I almost liked you code, I would just suggest you extracting it
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164417836
argh, thanks @SudharmaJain LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164425397
@DaanHoogland Could you please explain why you merged this?
We have a policy stating **2 (TWO)** persons will have to review a PR. One
code review and on
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164432291
@DaanHoogland I have put a check that if the quota is not enabled then the
tests are skipped. I tried enabling quota from inside the test, but it requires
a MS r
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1242#discussion_r47495825
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
@@ -37,8 +38,8 @@ public void testSSHK
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1242#discussion_r47495397
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
@@ -37,8 +38,8 @@ public void te
Github user dmytro-shevchenko commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-164459723
Commits are squashed and message updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-164464276
@dmytro-shevchenko Thank you, I'll give them a test run!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1223#issuecomment-164469053
@DaanHoogland I agree, someone must have kept this limit way back and
forgot about it.
---
If your project is set up for it, you can reply to this email and have you
Hi devs!
Despite the fact I was too lazy that weekend cloning the repo and filing
a pull request, I hope that small fix could make it upstream anyway.
--- ajaxviewer.js.orig 2015-12-13 11:10:47.851177577 +
+++ ajaxviewer.js 2015-12-13 14:14:32.367382547 +
@@ -649,6 +649,7 @@
this.sendingE
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164467579
+1 for reverting it. And I don't even care if the RAT is broken after the
rever. Reasons are obvious, but we have to stick to the 2 LGTM otherwise the
proje
Stephan,
Thanks for this. It was driving me nuts, I even complained to Mozilla lol.
I ended up installing an extension that disabled the quicksearch on "/" press.
https://freeshell.de//~kaosmos/index-en.html#searchkeys
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164471811
@Wilderrodrigues, @borisroman I agree with you that we cannot merge PRs
without two(2) LGTMs and integration tests to check if nothing was broken.
@DaanHo
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164474404
@rafaelweingartner
It's not about throwing stones, it's about the process.
Simply put: 2 LGTM, and depending on the PR at least 1 with inte
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164475560
@SudharmaJain Could you please open a new PR so it can be merged with
reviews.
---
If your project is set up for it, you can reply to this email and have your
r
Hi all,
Just to make this clear once more. A PR needs two LGTM's. One of them needs to
run the integration- and unit-tests. While the other does code review.
This is a the minimal requirement. More is always welcome, anything less will be
reverted.
I just enforced this policy [1]. Any active com
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164475760
@DaanHoogland : You mean the name should be an optional field? If that is
the case, we should make the field as optional in UI as well as in API.
@ra
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164477318
@DaanHoogland sorry missed your message, I did not test this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164482127
@nitin-maharana I do not agree with you. Take a look at the size of the
method âallocVolumeâ, there are more than 100 lines, that is terrible to
write
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164483340
@agneya2001 The definition as I gave you is used in th 'bubble' to create
the environment (including settings) before running the test in a
deployDatacenter.py
Boris don't revert blindly on having one tgm anymore. I will now contiunue
and commit the same code directly on master!
On Mon, Dec 14, 2015 at 4:53 PM, wrote:
> Repository: cloudstack
> Updated Branches:
> refs/heads/master 8d2e031a8 -> a00fef8c3
>
>
> Revert "Merge pull request #1243 from Su
You have been doing this blindly and I don't accept this
I have applied the mentioned code directly to master. Next time first see
if you can add your lgtm and whether the code is needed.
On Mon, Dec 14, 2015 at 4:58 PM, Boris Schrijver wrote:
> Hi all,
>
> Just to make this clear once more. A P
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164489480
Don't go here. this is about licensing. We have a duty do do this with
extreme prejudice.
On Mon, Dec 14, 2015 at 5:00 PM, borisroman
wrote:
Hi!
I've recently experimented with different approaches to add languages to
the consoleproxy in a more modular way than the very hardcoded
ajaxviewer / ajaxkeys / index.jsp
I'ld like to ask if someone already did some work in that direction, so
I could join in?
Alternatively, I'll start on a som
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164494786
I truly believe we need a meeting to discuss this. I understand the hole
licensing thing, but having a PR open to review is already a prove that the
issue i
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164514502
Step-1:
=
Ste
Guys,
I can see Daan fixed the build and am happy he cares so much about that. But I
don't see why we had to do it like this, instead of reverting the PR that
caused the build to fail? That's something one can do quickly without review.
Now the mess is complete. A broken PR merged (can happen)
Guys,
I can see Daan fixed the build and am happy he cares so much about that. But I
don't see why we had to do it like this, instead of reverting the PR that
caused the build to fail? That's something one can do quickly without review.
Now the mess is complete. A broken PR merged (can happen)
Yet that is very annoying, no chance it could make it in 4.7.0rc2 ? ...
Thanks Stephan!
On Mon, Dec 14, 2015 at 10:39 AM, Nux! wrote:
> Stephan,
>
> Thanks for this. It was driving me nuts, I even complained to Mozilla lol.
>
> I ended up installing an extension that disabled the quicksearch o
There is already a PR requested some 4 months back addressing some of these
issues. With that patch one has to add only key mappings to support new
languages.
https://github.com/apache/cloudstack/pull/669
On 14-Dec-2015, at 10:22 PM, Stephan Seitz
mailto:s.se...@secretresearchfacility.com>>
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1240#issuecomment-164652898
@DaanHoogland this is what I did:
1. Created a simulator environment
2. Deployed the datacenter using the cfg above,
3. checked the DB and confirmed t
Hi all,
Test this RC yesterday and here goes my +1 (binding). Details below:
ACS 4.6.2
:: Environment 1 ::
* Hardware required: TRUE
* Management Server + MySQL on CentOS 7.1
* One KVM Host on CentOS 7.1
* Agent + Common RPMs built from 4.6.2 source
:: Tests Suites Executed ::
nosetests --w
Github user kishankavala closed the pull request at:
https://github.com/apache/cloudstack/pull/577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
On 12/14/2015 11:15 PM, Remi Bergsma wrote:
> Guys,
>
> I can see Daan fixed the build and am happy he cares so much about that. But
> I don't see why we had to do it like this, instead of reverting the PR that
> caused the build to fail? That's something one can do quickly without review.
>
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164673949
Closing this one for now since it doesn't work on Java 7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/1220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
79 matches
Mail list logo
