[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1

2015-12-13 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1217#issuecomment-164242640 @remibergsma Probably yes, no more update on Transifex since the Dutch. You can merge this just before the start of RC process. Thanks. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164243359 @agneya2001 looks good, I don't understand all of it yet, partly because this is rather new functionality. Any plans on integration tests? I'll add som

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164243999 @DaanHoogland This does have a smoke test here: test/integration/smoke/test_quota.py. This is very basic, will add more test scenarios to it. --- If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164244364 Thanks abhi, I will run it after the regular suite passes and add it to my fork of it, and of course report here. --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1234#discussion_r47442747 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -383,31 +383,41 @@ public QuotaTariffV

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1234#discussion_r47442757 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -95,7 +95,7 @@ @Inject

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164246827 @agneya2001 is this 'only' a major bug? it seems to me to be the purpose of the quota system. blocker may be overdone but I really like this in before 4.7 as r

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1235 CLOUDSTACK-9155 make sure logrotate is effective for cloud.log Many processes on the VRs log to cloud.log. When log rotate kicks in, the file is rotated but the scripts still write to the o

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164247329 Pinging @wilderrodrigues @fborn @DaanHoogland @borisroman to review. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread agneya2001
Github user agneya2001 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1234#discussion_r47443252 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -383,31 +383,41 @@ public QuotaTariffVO

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread agneya2001
Github user agneya2001 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1234#discussion_r47443258 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -95,7 +95,7 @@ @Inject

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164248806 Kept it as a major bug as the account with negative quota will still get locked if quota is enforced, by the quota service thread, when it runs next. Whi

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164251561 @remibergsma sounds like the scripts that are the problem do an open for write instead of log-call, do they? I saw your list of processes and most of them seem

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1234#discussion_r47443410 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -383,31 +383,41 @@ public QuotaTariffV

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164253007 @DaanHoogland There are many different solutions in place, some are bash/python scripts that do `>/var/log/cloud.log` etc, some use `nohup` to keep running and

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164253054 Thanks @DaanHoogland @remibergsma @bhaisaab and @borisroman for reacting very quickly! --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164253411 @remibergsma agree and let's not close the jira ticket on merging as this obviously needs tlc. --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164253492 The change LGTM. We should get this in and for ACS 4.8 we do a refactor in order to have a proper solution in place. Cheers, Wilder --- If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164254871 Before PR this was seen after log rotate: ``` root@r-996-VM:/etc# lsof | grep cloud.log.1 _plutorun 767 root 3w REG 202,10 26054919 71 /var/log/cloud.

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164255438 The new script ends up on the router: ``` root@r-15-VM:~# cat /etc/logrotate.d/cloud # Licensed to the Apache Software Foundation (ASF) under on

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-16428 Ping @bhaisaab any chance to get this reviewed today? ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164255579 As you asked on im @remibergsma : LGTM more explicitely --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164255956 Based on explanation and code review: LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1228#issuecomment-164255977 @DaanHoogland That's an LGTM :+1: right? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1228#issuecomment-164256015 @borisroman I must learn to be less brittish ;) LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164258629 Integration tests make no real sense, but tried a few to be sure: ``` Check the password file in the Router VM ... === TestName: test_isolate_networ

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Removed .pydevproject from plugin kvm hyp...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1226#issuecomment-164261409 @DaanHoogland It's already in .gitignore, I think these we're never removed... --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164266288 @agneya2001 I ran test_quota.py ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-kvm2-zwps.cfg -s -a tags=advanced,requ

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164268405 LGTM @DaanHoogland to use the plugin and run tests, your zone cfg need to enable the quota plugin global setting and restart mgmt server before the plugin/apis

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164269573 thanks @bhaisaab I forgot setting indeed, 5 out of 7 tests now succeed. investigating the other two now --- If your project is set up for it, you can reply t

[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...

2015-12-13 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1236 CLOUDSTACK-9158: Removed SLF4J, it's abundant due to log4j In the entire project we use log4j, so why also use slf4j? I've removed slf4j and all references to it from the codebase.

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164270707 @DaanHoogland @borisroman - I sincerely don't grok the benefits of these changes, which is why I'm asking what are the benefits of the changes? Some potent

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164270791 I think the problem is in the tests as it starts with an empty balance. Can you confirm @bhaisaab , @agneya2001 ? --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1232#issuecomment-164270851 LGTM, though we might need to ask on dev@ as I remember someone using this? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1228#issuecomment-164270975 I think we might need to test if package building still works with the changes, i.e. is rpm/deb packaging are using or referencing it. Possible test would be to bu

[GitHub] cloudstack pull request: Removed .pydevproject from plugin kvm hyp...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1226#issuecomment-164271025 LGTM, not sure why they exist or if anyone (still) uses them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164271090 @borisroman do you need to remove one of the commits around moving to default maven project structure? I see two commits. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164271142 @DaanHoogland thanks, I think you're right but only @agneya2001 can confirm this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164271374 @bhaisaab I don't like maven but we are using it! cherry-picking is really not an argument and backporting is difficult for worse reasons then this one. Usi

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164271411 Hi @bhaisaab, True, that you see 2 commits! Due to the fact that this PR depends heavily on #1224. The commit id of the first commit is the same as the o

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164271487 I will try a run without this PR to confirm it is not a problem with the code --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1228#issuecomment-164271512 @bhaisaab I've already build the RPM's! We use them when running integration tests, so nothing broke in that area. I'll build the DEB packages now. ---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164271638 @DaanHoogland I'm not opposed to the change it is just that I think it makes my life challenging with some of the things I do on day-to-day basis :) We do follow a

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164272026 @borisroman alright, so we review/merge the other PR first and then come to this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164272024 @bhaisaab me too, and I am willing to put it on a long track but let's investigate and discuss more --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164272079 @bhaisaab Yes! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164277189 @remibergsma @bhaisaab @agneya2001 confirmed that the problem with the last two tests is in master as well. I am satisfied nothing breaks in the quota plugin,

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164277430 @DaanHoogland thanks Daan, I'll look into the failing issues with Abhi tomorrow. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1135#issuecomment-164278929 @pdube @remibergsma and i have been noticing extra failures in the integration tests with such short expunge timeouts. maybe it should work and can with some e

[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1150#issuecomment-164279018 @bhaisaab did you test this? should we merge before the RC tonight? --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1209#issuecomment-164279515 LGTM :+1: Based on code-review and @remibergsma tests. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...

2015-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1237 Remove unused folder(s)/file(s); HypervDummyResourceBase.java Dead code, never called and consist only of auto-generated methods. As a developer I want - a clean project to work

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164285184 Integration tests ran fine! **Environment** - 2 KVM host on CentOS 7.1 - 1 Management Server on CentOS 7.1 - Agent + Common RPMs built from

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164285459 @borisroman you know by now I agree on those principles but your integration test results are quite useless as we are talking about hyperv code. Let's do a sho

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164285932 @DaanHoogland The integration tests show nothing broke on the KVM part, the code of course does need to be reviewed. But that doesn't mean the tests are useless.

[VOTE] Apache CloudStack 4.6.2

2015-12-13 Thread Remi Bergsma
Hi all, In the past two weeks (since 4.6.1), 23 pull [1] requests have been merged to 4.6 branch and then to master/4.7.0. Therefore it makes sense to wrap-up the 4.6 release cycle with a final release and bring all the improvements to our users. Vote e-mail below. Later today we will send anot

[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1

2015-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164286918 @borisroman I can not decide based on these tests if the removal is ok, so to me they are useless --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164288018 For the sake of it, I run a some generic integration tests and they are happy. ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164288191 @borisroman @DaanHoogland Let's ask someone to test whether HyperV is still happy and then we'll know. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164289083 @remibergsma @DaanHoogland Back to the point, who could we ping for a HyperV review? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...

2015-12-13 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1238 CLOUDSTACK-9160: Remove unused folder(s)/file(s); engine/api/src/org/… …apache/engine/subsystem/api/storage/disktype Empty files. Moved DiskFormat.java to engine/api/src/org/apa

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1239 build_asf.sh: fix debian changelog altering The script already adds a new entry so we shouldn't replace the previous one. That is done only in the next version script. As discus

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1239#issuecomment-164290759 LGTM, let's merge on my review only as we don't have a second RM to review --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1239#issuecomment-164291121 The changelog file will need to be handled more carefully. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1239#issuecomment-164291346 @borisroman we should separate it from the CloudStack repo ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: QUOTA: Ensuring that the dates displayed ...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1205#issuecomment-164293808 did a code review and trustin @bhaisaab his testing skills: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: QUOTA: Ensuring that the dates displayed ...

2015-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-164294423 a test setup for this is not trivial, I can live with it but would like to see some proof before merging. --- If your project is set up for it, you can reply t

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/826#discussion_r47449550 --- Diff: server/src/com/cloud/storage/ImageStoreUploadMonitorImpl.java --- @@ -117,7 +117,7 @@ public boolean configure(String name, Map par

[VOTE] Apache CloudStack 4.7.0

2015-12-13 Thread Remi Bergsma
Hi all, Since our 4.6.0 release (on Nov 13th, exactly 1 month ago), we have merged 100+ pull requests [1] with lots of bug fixes, refactoring and of course new features. Time for a new release! I've created a 4.7.0 release candidate, with the following artifacts up for a vote: Git Branch and

Re: Need with InsufficientServerCapacityException while adding instance

2015-12-13 Thread Mike Tutkowski
The unfortunate part with that exception is that is could mean a lot of things. Off the top of my head, I've encountered it for the following reasons: * Not enough storage space for the root disk. * I had not applied the free license for my XenServer 6.1 hosts. * CloudStack couldn't find primar

Re: Need with InsufficientServerCapacityException while adding instance

2015-12-13 Thread Nux!
Yeah, usually it takes a bit more looking up and down the logfile to realise the cause, as well as checking the HVs logs. First thing to do is turn on DEBUG mode in the logging: sed -i 's/INFO/DEBUG/g' log4j-cloud.xml -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro -

[GitHub] cloudstack-docs-rn pull request: 4.7.0

2015-12-13 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/27 4.7.0 Please review what's new section and approuve or not the use of a screenshot for the Metric section. Thanks, You can merge this pull request into a Git repository by runn

[TEST] 4.7.0-RC1 Instance password not set

2015-12-13 Thread Pierre-Luc Dion
I'm not sure if this issue start at 4.7.0 or is just related to my test environment. But I can't get the password provide by cloudstack to the vm, In this case the instance is centos6.6 using the usual cloud-set-guest-password here is the log from the Instance: /var/log/messages Dec 14 00:32:56 c

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-13 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-164340450 @remibergsma This job is success now. I am downloading the template from this. http://jenkins.buildacloud.org/job/build-systemvm64-github/ --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-13 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-164344691 @DaanHoogland : Yes, your idea also looks good. Previously, it was generating a random value only in case of NULL. But if we pass an empty string, it was cre

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

2015-12-13 Thread maneesha-p
Github user maneesha-p commented on the pull request: https://github.com/apache/cloudstack/pull/1216#issuecomment-164347886 @bhaisaab @agneya2001 @DaanHoogland 2 LGTMs can it be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

2015-12-13 Thread priyankparihar
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/1165#issuecomment-164348885 @bhaisaab User with different account cannot create VMs with the same name, which was possible earlier (I am not sure in which CCP version). That time na

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-13 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-164350819 Fixed the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-12-13 Thread priyankparihar
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-164354949 @DaanHoogland I have tested it on my machines. what kind of proof do you need ? --- If your project is set up for it, you can reply to this email and have

Building Cloudstack failing on windows

2015-12-13 Thread Sudharma Jain
While building Cloudstack on windows, it fails with following exceptions. Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.052 sec <<< FAILURE! - in com.cloud.utils.TestProfiler testProfilerInNano(com.cloud.utils.TestProfiler) Time elapsed: 1.004 sec <<< FAILURE! java.lang.Asser

[GitHub] cloudstack pull request: [blocker/critical] CLOUDSTACK-9025 : [Xen...

2015-12-13 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1030 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota marvin tes...

2015-12-13 Thread agneya2001
GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1240 CLOUDSTACK-9161: fix the quota marvin test 1. Create a dummy user, as existing user may already have stale quota data 2. fix the tests to use the dummy user 3. a boundary

[GitHub] cloudstack pull request: [blocker/critical] CLOUDSTACK-9025 : [Xen...

2015-12-13 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1030#issuecomment-164359761 Closing this PR as this got fixed by PR #1176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

2015-12-13 Thread pritisarap12
Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1199#discussion_r47465693 --- Diff: test/integration/testpaths/testpath_snapshot_limits.py --- @@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self): )

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

2015-12-13 Thread pritisarap12
Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1199#discussion_r47465783 --- Diff: test/integration/testpaths/testpath_snapshot_limits.py --- @@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self): )

[GitHub] cloudstack pull request: CLOUDSTACK-9162: Unable to add VPN user v...

2015-12-13 Thread kansal
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/1241 CLOUDSTACK-9162: Unable to add VPN user via API with Required Paramet… …ers - Fixed RCA: When we do not provide account parameter which is an optional field , API picks up the a

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-13 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1206#issuecomment-164366344 API with non-empty name: http://10.102.192.122:8080/client/api?command=createVolume&response=json&name=TempVolume&zoneId=18b1cb1a

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-12-13 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-164369338 -1 Just on the fact that "it runs on my machine" is the single most horrible reason to justify working software. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

2015-12-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164371097 @DaanHoogland @bhaisaab The first thing is that using a standard is better than doing the way nobody else is doing. When one adopts a technology is