[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-08 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-162812927 @remibergsma It seems the systemvmvbuilder machine is down. He is having access to these machines ? --- If your project is set up for it, you can reply to this em

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread Sanjeev N
@terbolour, as per the previous logic in the test, it will register xenserver template for any hypervisor other than kvm and vm deployment fails for other hypervisors like vmware,hyper-v and lxc. So I was asking how we should handle this. On Tue, Dec 8, 2015 at 12:44 PM, terbolous wrote: > Githu

[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...

2015-12-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1180#issuecomment-162821748 Hi @harikrishna-patnala Anyway we can test this? Is there any integration test that we can use to cover your changes? Concerning the new methods yo

[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...

2015-12-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1037#issuecomment-162824106 Ping @bhaisaab @atrbgithub If I get some details on how to test - steps - I can give it a try. Cheers, Wilder --- If your project is

Re: Feature freeze ACS 4.7 next Monday

2015-12-08 Thread Wilder Rodrigues
Hi there cs user, If you put some details on the PR about how to test it, I can help out and, perhaps, even write a test for it. Cheers, Wilder > On 07 Dec 2015, at 15:09, cs user wrote: > > Hi Folks, > > Would anyone else be able to give > https://github.com/apache/cloudstack/pull/1037 a t

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-162825327 @jayapalu Can you share the right systemvm template somewhere? Otherwise I cannot test this. --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...

2015-12-08 Thread atrbgithub
Github user atrbgithub commented on the pull request: https://github.com/apache/cloudstack/pull/1037#issuecomment-162829832 Hi @wilderrodrigues To test this you would need to have 2 or more cloudstack management servers operating in a cluster with Xen hosts. Before applying t

Jenkins job to build systemvm templates

2015-12-08 Thread Remi Bergsma
Hi, It seems Jenkins slave ‘systemvmbuilder’ is down so I cannot build a systemvm template to build / test PR 872 (strong swan). Does anyone know another way to build a template? Regards, Remi

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

2015-12-08 Thread kansal
GitHub user kansal opened a pull request: https://github.com/apache/cloudstack/pull/1188 CLOUDSTACK-9086: ACS allows to create isolated networks with invalide… … gateway IP address - Fixed and Test cases added Problem: There was no check for the network and broadcast IP

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936 Gotcha. We could add templates for the other hypervisors (vmware and hyperv) from http://dl.openvm.eu/cloudstack/macchinina/x86_64/ And remove the

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

2015-12-08 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1187#discussion_r46934510 --- Diff: utils/src/test/java/org/apache/cloudstack/utils/hypervisor/HypervisorUtilsTest.java --- @@ -106,6 +104,8 @@ private void setupcheckVolume

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1189 CLOUDSTACK-9118 - As a Developer I want the checkrouter.sh script to report the right information about RVR routers state This PR fixes the RVR routers state information retrieved by th

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162839426 Ping @remibergsma @bhaisaab @DaanHoogland @miguelaferreira @borisroman I'm currently running the other tests, but feel free to start testing now.

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

2015-12-08 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1188#issuecomment-162839268 cc @bhaisaab @DaanHoogland I closed the previous PR. Created this one and rebased with the master. Not sure why the tests were failing in the previous one. Maybe so

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

2015-12-08 Thread nlivens
Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1187#discussion_r46935277 --- Diff: utils/src/test/java/org/apache/cloudstack/utils/hypervisor/HypervisorUtilsTest.java --- @@ -106,6 +104,8 @@ private void setupcheckVolumeFileF

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread Sanjeev N
Thanks @michaelandersen, I will take those templates and make the test generic. On Tue, Dec 8, 2015 at 3:35 PM, michaelandersen wrote: > Github user michaelandersen commented on the pull request: > > https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936 > > Gotcha. We cou

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9113: skip vm with incon...

2015-12-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1182#issuecomment-162850730 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

2015-12-08 Thread pritisarap12
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/1190 CLOUDSTACK-9121: Adding VmSnapshot validation in testpath_revert_snap.py In testpath_revert_snap.py, there was no code to check if VM snapshot is created or not hence adding code for snaps

[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

2015-12-08 Thread pritisarap12
Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/1190#issuecomment-162851170 Testpath Result: Test revert snapshot on XenServer ... === TestName: test_01_check_revert_snapshot | Status : SUCCESS === ok -

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

2015-12-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1187#issuecomment-162851336 @nlivens Thanks for the patch. Just for the sake of it, run the integration tests and they show OK (no surprise ;-) ): ``` nosetests --with-marvin -

[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...

2015-12-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1180#issuecomment-162851856 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162860695 Ping @DaanHoogland @remibergsma @miguelaferreira @borisroman @bhaisaab @karuturi Since I changed the checkrouter.sh, also used by rVPCs, I will run

BVT report for the week of 12/7

2015-12-08 Thread Raja Pullela
Here are the BVT results based on the latest master, going forward please expect to see an email on the BVTs beginning of every week: - XS Basic - 97.3% (4.6 RC passrate 96.9%) - XS Adv - 92.7% (4.6 RC passrate 93.4%) - KVM Basic - 98.6% (4.6 RC passrate - 98.6%) - KVM Adv - 96.4% (4.6 RC passrate

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2015-12-08 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-162867278 @jburwell @DaanHoogland @kishankavala Have included some changes related to the UI. Now after generating the keys from UI, after ListUserCmd() api, listKeysCmd() wi

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2015-12-08 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r46947711 --- Diff: api/src/org/apache/cloudstack/api/command/admin/user/ListKeysCmd.java --- @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundat

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2015-12-08 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r46947731 --- Diff: api/src/org/apache/cloudstack/api/command/admin/user/ListKeysCmd.java --- @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundat

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2015-12-08 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-162869020 @kansal looks good, but for a change like this I would like a marvin test to prove it and guarantee it's continued functioning/functionality Do you see chance

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-08 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r46961653 --- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf --- @@ -30,4 +35,5 @@ conn L2TP-PSK #

[GitHub] cloudstack pull request: Changed UsageEventUtils to UsageEventEmit...

2015-12-08 Thread nnesic
GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/1191 Changed UsageEventUtils to UsageEventEmitter and made it injectable Refactored code to make the UsageEventEmitter injectable. Fixed unit tests where required, but otherwise no changes in the log

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162941648 Hi @wilderrodrigues, I tested it just now! Looking good! Ran against Ubuntu 14.04 KVM management/hypervisor. ``` Test redundant router inter

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

2015-12-08 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/823#issuecomment-162947373 The functionality purely depends on the meaning of compatibility. Here is what I understood about the compatibility. For example, if our current compute offer

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1189#issuecomment-162984674 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9118 - As a Developer I want t...

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-08 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162990802 @remibergsma my mistake, I meant to modify schema-460to470.sql and schema-461to470.sql but not setup/db/db/schema-410to420-cleanup.sql as I did. I'll push some

[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...

2015-12-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1180#issuecomment-162994057 @remibergsma It doesn't break things covered by the tests that were execute, which is fine. However, @harikrishna-patnala hasn't provided any suppo

Lists admin, please unsubscribe/remove andrewlore...@gmx.com

2015-12-08 Thread Nux!
Hi, Whoever is list admin, please remove andrewlore...@gmx.com from the user/dev MLs, his inbox has reached quota and it's generating bouncebacks. This has been going on for a while, at least a few weeks. Thanks! -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro

[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...

2015-12-08 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1037#issuecomment-162995054 Hi @atrbgithub Yes, the info clarifies feel things, but unfortunately I'm also busy and do not have time to write a test to cover it. I also have s

40GB hard limit on template size

2015-12-08 Thread Syed Mushtaq
Hi Guys, Does anyone know why there is a 40GB hard limit on the template size? https://github.com/apache/cloudstack/blob/master/scripts/storage/secondary/createvolume.sh#L30 and https://github.com/apache/cloudstack/blob/master/scripts/storage/secondary/createtmplt.sh#L30 We had a customer who

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-08 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r47049123 --- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf --- @@ -30,4 +35,5 @@ conn L2TP-PSK # ---

[GitHub] cloudstack pull request: CLOUDSTACK-9112: Deploy VM failing freque...

2015-12-08 Thread harikrishna-patnala
Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/1180#issuecomment-163112385 Thank you for the feedback, I'll add the unit tests for the new methods and integration tests for the changes that I have made. --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9122: future credit etries sho...

2015-12-08 Thread agneya2001
GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1192 CLOUDSTACK-9122: future credit etries should be incorporated when the… future credit etries should be incorporated when the balance is calculated 1. Some code is refactored so that

[GitHub] cloudstack pull request: QUOTA: ENSURING THAT THE DATES DISPLAYED ...

2015-12-08 Thread agneya2001
GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1193 QUOTA: ENSURING THAT THE DATES DISPLAYED ARE AS PER USER EXPECTATIONS When querying db we use start of next day to query quota usage for today, but while displaying it to user we

[GitHub] cloudstack pull request: CLOUDSTACK-9125: Brazilian translations

2015-12-08 Thread agneya2001
GitHub user agneya2001 opened a pull request: https://github.com/apache/cloudstack/pull/1194 CLOUDSTACK-9125: Brazilian translations The pull request contains brazilian translations for quota labels. You can merge this pull request into a Git repository by running: $ git pull h

[GitHub] cloudstack pull request: CLOUDSTACK-9120 - As a Developer I want t...

2015-12-08 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1195 CLOUDSTACK-9120 - As a Developer I want the new component tests to be moved into the smoke directory This PR only moves the tests I wrote form the ```component``` to the ```smoke``` di

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-08 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/1196 CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterprise… … Server 10 SP2 and SP3" ISSUE STOP-START of SUSE Linux VMs fail, as PV-bootloader-args

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

2015-12-08 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1140#issuecomment-163140058 @DaanHoogland the fix is simple. We do not need special /extra process for VPC routers. @bhaisaab this issue does not exist in 4.5, as @koushik-das mentioned

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

2015-12-08 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1140#issuecomment-163140236 sorry guys, just notice it is already merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9120 - As a Developer I want t...

2015-12-08 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1195#issuecomment-163140684 fine by me. I will get soem time to add a PR with read.me files per directory indicating what type of test should go where. LGTM pending the outcome of