Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-162994057
@remibergsma
It doesn't break things covered by the tests that were execute, which is
fine. However, @harikrishna-patnala hasn't provided any support in terms of how
to test it; if there is any integration test to help; or about the unit tests
for the new methods he introduced.
I'm not very keen to LGTM a PR without support from the author himself.
Unless he comes back with some more details, I will hold a :-1: for this PR.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
