Hate to be a pain, but could you make sure to keep the exact list of Features
merged, so that the Release notes are accurate ?
thanks
On Dec 4, 2015, at 11:58 PM, Remi Bergsma wrote:
> Hi all,
>
> Next Monday we'll feature freeze for our upcoming 4.7 release. We looked
> through all open Pul
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162448978
Seems like we have the same problem in the XenServer code, as I stated
earlier in another pull request somewhere out there, where this code originates
from (XenServerG
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796541
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Softwar
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796893
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Softwar
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46796854
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Foun
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162450640
@snuf
The procedure getCommandHostDelegation are overrided in three hypervisor:
XenserverGuru, VmwareGuru and Ovm3HypervisorGuru.
We should make su
Rohit, Sebastien,
I think we do not need to hurry any issues. work on 4.8 will start in
January or february at the latest.
On Mon, Dec 7, 2015 at 8:55 AM, sebgoa wrote:
> Hate to be a pain, but could you make sure to keep the exact list of
> Features merged, so that the Release notes are accura
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46797933
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162453199
Though I would like to see how this situation is reproduced, the code is
fine and sensible.
LGTM
---
If your project is set up for it, you can reply t
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46797960
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Founda
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-162454833
The code looks good but I am wondering about the functionality. The prior
situation was that the new offering should have a subset of the old one. Now it
has to
On Dec 7, 2015, at 9:56 AM, Daan Hoogland wrote:
> Rohit, Sebastien,
>
> I think we do not need to hurry any issues. work on 4.8 will start in
> January or february at the latest.
I don't want to hurry anything, I want to be able to have release notes that
describe *all* the features added.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-162455918
Does what it says but probably more. Do we not mind any other version?
@priyankparihar can you show how ACS doesn't allow invalid migrations, "Storage
XenMotion
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162460207
@remibergsma @DaanHoogland
I'm closing this PR and will create a new one against 4.6.
Cheers,
Wilder
---
If your project is set up fo
Github user wilderrodrigues closed the pull request at:
https://github.com/apache/cloudstack/pull/1179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack-www/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162462731
@jburwell, thanks for the review! I've handled your comments. Thanks
@bhaisaab, would be great if we can still get this in 4.7
---
If your project is set up for it
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162464119
@nlivens cool, LGTM. Will merge on 4.6 once the build checks complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162464159
s/4.6/master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162464615
Guys, this got merged on only code review. No tests are described showing
the old and new behaviours. No unit tests are added. No regression tests are
added. I
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162464916
@terbolous your real question is: Can we get this in 4.6/4.7? right? I
sugest you start a discuss thread on dev@ if you feel it should.
---
If your project is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162465934
@DaanHoogland let's revert, and ask @harikrishna-patnala to add more tests?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162466163
@jayapalu I see some new commits. Did you change anything yet? Should we
start testing?
---
If your project is set up for it, you can reply to this email and ha
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162466433
@terbolous @DaanHoogland This seems like a bug fix, but since it needs a
new systemvm template there is no way we will add this to 4.6. For the same
reason, I wa
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162467255
@DaanHoogland: yes, we're unable to use 4.6 due to the bug mentioned. now,
the original issue may be fixed in 4.6 with openswan later, but i would much
rather see
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162468306
Actually I was looking at the history and this is what I found. This was
originally fixed with commit
commit e444a03819ccf72f61cb04e8428d20cc65b145e1
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162469279
@koushik-das good find, that means we also need to fix this for 4.6. We
would still need a round of tests just in case.
@harikrishna-patnala can you open a
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162469649
@jayapalu looks like you're still working on this, making progress. Please
ping us when you want us to start some testing today (hopefully before EOD
12PM/CET). Ple
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162471051
cc @bhaisaab @DaanHoogland . Added test cases and made some minor changes
to the function. Please have a look.
---
If your project is set up for it, you can reply t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162472783
Thanks for picking this up, guys.
I still think there is calling code that should not be allowed to call
start twice. It should skip the VirtualNetwork
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162473175
I have the same concern with Daan. How to reproduce this issue ?
Check my env
mysql> select * from volumes where volume_type is null or provisioning_t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162474888
LGTM
I will run a test build on this
also github reports conflicts on this branch, did you fork this of master?
and when? It may need a rebase to merge
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1044#issuecomment-162476357
regression tests executed:
[1044.network.results.txt](https://github.com/apache/cloudstack/files/53778/1044.network.results.txt)
[1044.vpc.results.txt]
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46805977
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final
String i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162480371
Not sure if it is related but
```
Running com.cloud.utils.net.NetUtilsTest
2015-12-07 11:33:08,471 INFO [utils.net.NetUtils] (main:) Invalid va
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1082#issuecomment-162481574
@nitin-maharana How do I test this? I tried adding a project but the page
keeps loading forever. Which dropdown should I look at?
![screen shot 2015-12-
Github user fmaximus commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162483085
Are we still taking Travis into account? It has a unit test failure in
HypervisorUtilTest, which also failed in other builds on Travis. This test
seems to fail ran
Hi Seb,
Now that we merge everything and have a smaller scope, it should be easier to
get the list of pull requests that got in since 4.6.
Quick attempt:
git log --pretty=oneline --abbrev-commit upstream/4.6..master | grep Merge |
grep -v release | grep -v 4\.6 | awk {'print $5'} | sed s/\#//g
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162483571
@DaanHoogland , @ustcweizhou
This issue is reproduced when the volume associated vm instance has null or
invalid state (vm_state in volume_view). The code
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162484552
@sureshanaparti How do we force such a situation to occur?
It seems to me that should be guarded on input and alerted on on output
instead of silently filter
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162484701
@nitin-maharana @bhaisaab I looked around but just don't find what's
changed. Please post screenshots of what is changed or instruct exactly how it
should work.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162485224
Hmm.. this isn't supported on KVM, is it? That may be why I can't find it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162486767
@sureshanaparti
mysql> SELECT id, name, volume_type, state, vm_state FROM cloud.volume_view
where vm_state is null and vm_id is not null;
Empty set
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46809694
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final
String ipAddre
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1181
CLOUDSTACK-9113: skip vm with inconsistent state when
getVmStats/getVmDiskStats
on KVM, if there is a vm has inconsistent state between hypervisor and db,
the getVmStat will terminate and
Github user ustcweizhou closed the pull request at:
https://github.com/apache/cloudstack/pull/1181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1181#issuecomment-162488604
wrong branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1182
CLOUDSTACK-9113: skip vm with inconsistent state when
getVmStats/getVmDiskStats
on KVM, if there is a vm has inconsistent state between hypervisor and db,
the getVmStat will terminate and
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162490625
@DaanHoogland I see a test case in the NetUtilsTest.java class'
testIsSameIpRange() function.
assertFalse(NetUtils.isSameIpRange(cidrFirst, "10.3.6.5/50"));
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162493826
@ustcweizhou , Same with my result set as well.
mysql> select * from vm_instance where state is null;
Empty set (0.00 sec)
mysql> SELECT id, na
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162493847
@remibergsma Do you remember any changes that might be causing
HypervisorUtilsTest.checkVolumeFileForActivityTest to fail?
---
If your project is set up for it, y
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162494808
The volumes, in Ready state and are not attached to any VM have their
vm_state has null and querying such volumes may result in NPE. These changes
are only to
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162496553
@bhaisaab, we've looked into the code of that test, and the results are
unreliable.
The steps that are done in that test (along with the implementation of the
c
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162497602
it is the NetUtilsTest.test31BitPrefix...() family of tests that are failing
---
If your project is set up for it, you can reply to this email and have your
re
I am studying the logging process used by CloudStack and came accross the
configuration file that is used by Log4j. What is confusing to me is that all
the resources is stating that the "log4j-cloud.xml" is supposed to be the file
used to confiugre the logging, but what I have noticed is that no
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162498348
@nlivens there are several tests like this bugging us. Do you know an
alternative for this one?
---
If your project is set up for it, you can reply to this em
Hello,
Just hit this today.. Opened the following issue with it. Functionality is
restored if I use a v4.4 qcow2/resizevolume.sh script.
https://issues.apache.org/jira/browse/CLOUDSTACK-9115
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
Hello,
I am studying the logging process used by CloudStack and came accross the
configuration file that is used by Log4j. What is confusing to me is that all
the resources is stating that the "log4j-cloud.xml" is supposed to be the file
used to confiugre the logging, but what I have noticed
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162506613
Abhi has fixed the issues, changes are now incorporated, commits squashed
into one.
cc @remibergsma @jburwell
LGTM, let's merge this before EOD.
---
The rn repo contains a script that polls JIRA for a release filter and
generates the tables of issues fixed:
https://github.com/apache/cloudstack-docs-rn/blob/master/utils/jira.py
but we are not tracking the ones that really are *features*….
small detail that would be nice to sort out.
On Dec
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1183
Marvin test to verify that adding TCP ports 500,4500 and 1701 in vpn should
not fail
Please refer to JIRA ticket for more details
https://issues.apache.org/jira/browse/CLOUDSTACK-9117
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162517321
Remote access vpn test results:
nosetests-2.7 --with-marvin
--marvin-config=/Users/jayapalreddy/advanced.cfg
/Users/jayapalreddy/dev/github/cloudstack/test/
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162520027
Just tested this on 4.6.1-SNAPSHOT with the command:
```
nosetests --with-marvin
--marvin-config=/data/shared/marvin/mct-zone1-xen1.cfg -a
tags=adv
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162520618
@sureshanaparti
I do not get NPE when listVolumes.
please notice the code:
long instanceId = volume.getVmId();
if (instanceId
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162522267
ping @sanju1010
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162523432
@DaanHoogland, below you can find a possible alternative for this test file.
[HypervisorUtilsTestPatch.txt](https://github.com/apache/cloudstack/files/53965/Hype
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162526429
@jayapalu Nice! Did you also test site2site VPN?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1184
CLOUDSTACK-9106 - As a Developer I want the Redundant VPC private gateway
feature fixed
This PR contains the same fixes from PR #1179, which was created against
the master branch.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162527902
Ping @DaanHoogland @remibergsma @borisroman
I will continue the tests, but PR is ready to be reviewed.
* Environment
- Hardware requi
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162529656
@bhaisaab @remibergsma there is still one issue that I am looking at now.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162532791
This index comes from schema-40to410.sql:
CREATE TABLE `cloud`.`nicira_nvp_router_map` (
`id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id',
Hi Folks,
Would anyone else be able to give
https://github.com/apache/cloudstack/pull/1037 a try at some point?
Quite a serious issue when running in clustered mode with Xen, and trying
to perform VM migrations between hosts.
Thanks!
On Mon, Dec 7, 2015 at 12:08 PM, sebgoa wrote:
> The rn rep
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-162533617
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_v
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162535442
Doesn't work for me either:
```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Test VP
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162539384
Hi Remi,
As I mentioned in my PR the second test failure is related to connectivity
issues between the vms part of s2s vpn. It is not because of my cha
+1 on this question.
I too would like to know the reason for having all these files in different
modules.
On 07/12/15 12:52, "Chaz PC" wrote:
>Hello,
>
>
>
>
>I am studying the logging process used by CloudStack and came accross the
>configuration file that is used by Log4j. What is confusin
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162544664
@sanju1010 the error lies in the script due to different outputs. the test
seems to use macchinina as template, which has the following output for ping:
# ping
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162545461
Hi Sanju,
Isn't it the point of the test to verify this exact connectivity?
But I any case I don't believe connectivity is the reason this t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162546287
:-1: Tests are failing, we need to fix it before we consider a merge, sorry.
---
If your project is set up for it, you can reply to this email and have your
re
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162548576
Jenkins known issue:
---
If your p
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162549079
@nlivens I like your patch, can you send that as a separate PR please?
LGTM, cc @remibergsma please merge this (do you need to run your tests, if
necessary?)
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1185
Adapted HypervisorUtilsTest to no longer give false positives
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack test_impro
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162551073
@bhaisaab, this is the PR for the test adaptation discussed in PR#1142
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162565931
Run the tests again. LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162572129
@agneya2001 OK, please ping me when done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162572535
@bhaisaab Minor thing: could you also rename the title to "Implement Quota
service"?
I will make sure it will be merged before we freeze.
---
If your p
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162573927
@remibergsma sure, I'm discussing with Abhi on that minor fix. After that,
will squash/amend the message in the git log.
---
If your project is set up for it, you
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162574201
Ping @remibergsma @miguelaferreira @DaanHoogland @borisroman
Problem with my PR! I havenât seen that one failing before. Will
investigate.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162578278
Great thanks, LGTM.
cc @remibergsma - let's merge this, just so to have less Travis failures?
(possibly also merge on 4.6?)
---
If your project is set up for
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162588761
@nlivens @bhaisaab If you guys want this in 4.6 as well (which seems like a
good idea) please open a PR against 4.6. That will then be forward merged to
master.
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162595100
@bhaisaab the issue is resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162598613
Ping @remibergsma @DaanHoogland @miguelaferreira @borisroman
Deployed another DC and followed the same step as the test, but did it
manually:
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162601030
@agneya2001 thanks, squashing the change and pushing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162601662
@remibergsma LGTM, final issue fixed. Let's merge now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162603163
Good idea. @nlivens please open the same patch/PR again 4.6 branch, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162611887
Although it worked manually, I'm running the test again... in an brand new
DC.
```
nosetests --with-marvin
--marvin-config=/data/shared/marvin/
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162612180
@bhaisaab @DaanHoogland I updated the change with current 4.6 branch and
removed the commented codes. @remibergsma This only supports in VMware. Thanks
:)
Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162612642
@ustcweizhou , Yes. I agree. In case on instance id, vm_state is not null.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/768
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162614546
Went through the code. Looks Good To Me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
1 - 100 of 134 matches
Mail list logo
