Re: New PMC member: Erik Weber

Thanks again all :-) Erik On Sat, Oct 31, 2015 at 7:06 PM, Jan-Arve Nygård wrote: > Congratulations Erik, well deserved :) > > Den fredag 30. oktober 2015 skrev Milamber følgende: > > > > > Congrats Erik! Good works! > > > > On 30/10/2015 14:01, Giles Sirett wrote: > > > >> All > >> The PMC is

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1024 [4.6/master] CLOUDSTACK-9019: Add storage network offering in ssvm only if storage… … network is defined During creation of SSVM, checks and adds NetworkOffering.SystemStorageNet

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153285784 Ping @remibergsma @borisroman Partial results (tests still running) ``` Test start/stop of router after addition of one guest network

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9019: Add storage networ...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1025 [4.5] CLOUDSTACK-9019: Add storage network offering in ssvm only if storage… … network is defined During creation of SSVM, checks and adds NetworkOffering.SystemStorageNetwork to

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-153285936 LGTM based on code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1024#issuecomment-153286419 Thanks @bhaisaab nice fix, have seen it before. Will run some tests soon. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153286535 @miguelaferreira @remibergsma Would this be of any help? https://mariadb.com/kb/en/mariadb/about-mariadb-connector-j/ It has a GNU license. Are there any

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153286583 @wilderrodrigues Thanks for the fix, tests are running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1009#issuecomment-153286973 Hi @rags22489664 Thanks for the fix! Can you please get rid of that second commit? It cannot be merged like this. Thanks! If you add a unit test, @dahn

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/1000#issuecomment-153287076 LGTM Based on code understanding One line change if attribute is there then proceed to cleanup if hasattr(self, "data_volume_created"): -

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153287336 That seems to be LGPL and as such not allowed by apache policy: http://www.apache.org/legal/resolved.html The issue to me is more on where do the res

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153287597 @jburwell That's fine, although this branch can be rebased easily. I would do that before running tests anyway. But I'll focus on 4.6 first, so it makes sense to

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

Github user rags22489664 commented on the pull request: https://github.com/apache/cloudstack/pull/1009#issuecomment-153289004 oh..let me remove the second commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153289366 I've searched the legal section of Apache's JIRA and found several posts about including GPL licensed products in builds and test runs. One in particular (ht

Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

I am taking back my previous comment. I created VMWare environment and vpc creation was successful. Please ignore it. On Tue, Nov 3, 2015 at 12:15 PM, Remi Bergsma wrote: > Hi Sanjeev, > > That same tests passes fine here (see all the reviews I posted). Can you > provide more details, so we can

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

In case of VMWare and Hyper-v , linc local is on eth1. So the command in all the failed tests to verify link local IP should be modified. "cat /var/cache/cloud/cmdline | xargs | sed \"s/ /\\n/g\" | grep eth0ip= | sed \"s/\=/ /g\" | awk '{print $2}'",. It is using eth0ip. However, it should be eth1i

Re: Git with Eclipse

Ron, can you link us to your PR? there is 118 open at the moment and I don't see your name with the last bunch. On Mon, Nov 2, 2015 at 10:59 PM, Ron Wheeler wrote: > Due to Sebastien and Daan's help, I have been able to create a pull > request for a small change to the docs. > https://wiki.eclip

Re: Git with Eclipse

never mind: https://github.com/apache/cloudstack-docs-admin/pull/31/files looked in the wrong repo On Tue, Nov 3, 2015 at 10:34 AM, Daan Hoogland wrote: > Ron, can you link us to your PR? there is 118 open at the moment and I > don't see your name with the last bunch. > > On Mon, Nov 2, 2015 at

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153299225 Ron, your PR looks fine. It is kind of convention to have a ticket describing what needs to be done and then prepend the ticket id to the PR descript

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-153301418 this has two lgtm but no report of tests executed. As this is only test code I'll recreate an environment and give it a spin. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153301644 @wilderrodrigues apart from the issue mentioned in CLOUDSTACK-9018, I found the below issue. The egress rule added in a default egress ALLOW network doesnt bloc

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1000#issuecomment-153301936 2 lgtm but no test report, will execute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-153302400 Test Result: Test events table ... === TestName: test_01_verify_events_table | Status : SUCCESS === ok

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/1000#issuecomment-153302753 Test Result: Storage and Snapshot Limit ... -- Ran 1 test in 970.317s

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

Thanks for the details, Sanjeev. Fixing the test now. PR to follow. Cheers, Wilder > On 03 Nov 2015, at 10:26, Sanjeev N wrote: > > In case of VMWare and Hyper-v , linc local is on eth1. So the command in > all the failed tests to verify link local IP should be modified. > "cat /var/cache/clou

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153305656 Thanks for the details, @karuturi ! I will fix that. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153309653 More test results. It did not break existing functionality, but still I will fix the one @karuturi found. Cheers, Wilder ``` test_p

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153309944 Usage of @LogLevel(Log4jLevel.Off) seems inappropriate to avoid logging sensitive information, why not still check the sensitive param/annotation to log or not log

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1024#issuecomment-153311038 Seems like a good fix to me. Can't test it manually at this moment though --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43733925 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,197 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734035 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,219 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734224 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java --- @@ -0,0 +1,108 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734254 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java --- @@ -0,0 +1,108 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-153312402 @DaanHoogland @ustcweizhou Overall it seems good! It's just hard to test this since it can break migration of VMs and you also have to deal with all the versions of lib

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734401 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreVMSnapshotCommandWrapper.java --- @@ -0,0 +1,103 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734583 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,219 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9021 - Add right interface whe...

GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1026 CLOUDSTACK-9021 - Add right interface when test is executed against HyperV/VMware The test now check the IP taking into account the right interface for VMware/HyperV (eth1). @

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934 LGTM, verified in the github preview that the output renders correctly. --- If your project is set up for it, you can reply to this email and have your

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

PR has been created. Could you please have a look? https://github.com/apache/cloudstack/pull/1026 Cheers, Wilder On 03 Nov 2015, at 10:59, Wilder Rodrigues mailto:wrodrig...@schubergphilis.com>> wrote: Thanks for the details, Sanjeev. Fixing the test now. PR to follow. Cheers, Wilder On 03

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r43734962 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java --- @@ -0,0 +1,108 @@

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

Ran one test Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS === ok LGTM!! On Tue, Nov 3, 2015 at 4:20 PM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > PR has been created. Could you please have a look? > > https://github.com/apache/cloudstack/pull/

Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

Cool! Thanks a lot! > On 03 Nov 2015, at 12:13, Sanjeev N wrote: > > Ran one test > > Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : > SUCCESS === > ok > > LGTM!! > > On Tue, Nov 3, 2015 at 4:20 PM, Wilder Rodrigues < > wrodrig...@schubergphilis.com> wrote: > >> PR

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153327157 @bhaisaab What are your reasons for saying that @LogLevel(Log4jLevel.Off) is inappropriate? By sensitive param/annotation are you referring to the exist

[GitHub] cloudstack pull request: CLOUDSTACK-9021 - Add right interface whe...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1026#issuecomment-153327095 Got LGTM from Sanjeev on the mail list: ``` On 03 Nov 2015, at 12:13, Sanjeev N wrote: Ran one test Test SSVM Internals ... ==

[GitHub] cloudstack pull request: CLOUDSTACK-8715: qemu-guest-agent support...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1027 CLOUDSTACK-8715: qemu-guest-agent support on KVM @wido can you check if these codes are useful for you? You can merge this pull request into a Git repository by running: $ git pull ht

[GitHub] cloudstack pull request: CLOUDSTACK-9021 - Add right interface whe...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1026#issuecomment-153329985 change makes sense, I have no hyperv or vmware to test on. LGTM --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153330895 @bhaisaab @koushik-das Isn't there an annotation on field level for APIs as well? A change was accepted for that. I am looking for it and will update this comm

[GitHub] cloudstack pull request: CLOUDSTACK-9021 - Add right interface whe...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1026#issuecomment-153331810 2 LGTMs merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request: CLOUDSTACK-9021 - Add right interface whe...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1026 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: build-master-noredist #4710

See Changes: [wrodrigues] CLOUDSTACK-9021 - Add right interface when test is executed against HyperV/VMware -- [...truncated 849 lines...] 2015-11-03 12:09:47,045 DEBUG [utils.script.

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-153336055 @wido any chance libvirt can be upgraded? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153337620 @DaanHoogland @bhaisaab I also couldn't find any annotation on API fields for this. So ended up using the LogLevel which is also used in the agent commands. -

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153337733 LGTM, formating is fine in the current sphinx theme. Having the link to the feature spec mention at line 305 would have been a nice to have.

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/1028 smoke/test_vpc_vpn: Add template wait & refactor - Added a wait for template download as the test was failing in some environments - Removed debug timer in setup and teardown -

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153338103 @sanjeevneelarapu please review once build checks are completed --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153338369 Tested change on a KVM hypervisor: Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS === ok Test

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1021#issuecomment-153338874 The field level annotation was discussed as a prefered solution but in the end a regexp on field names was used. I am fine with re-using the LogLevel annotatio

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1028#issuecomment-153338894 executed tests with: nosetests --with-marvin --marvin-config=./mct-zone1-kvm1.cfg -a tags=advanced test_vpc_vpn.py --- If your project is set up for

Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Hi Raja, Please see this PR: https://github.com/apache/cloudstack/pull/1028 Regards, Remi On 30/10/15 17:44, "Raja Pullela" wrote: >Hi Michael > >Can you please add a wait for the template to download before the VM creation? > >Raja >Begin forwarded message: >From: Raja Pullela mailto:raja

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-153339945 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1028#discussion_r43742770 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -570,127 +584,139 @@ def test_vpc_site2site_vpn(self): finally:

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9019: Add storage networ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1025#issuecomment-153341540 Result before this PR: ``` root@s-58-VM:~# ifconfig eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:b0 inet addr:169.254.3.

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1024#issuecomment-153341635 Result before this PR: ``` root@s-58-VM:~# ifconfig eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:b0 inet addr:169.254.3.

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1012#issuecomment-153342236 This is already merged, I was running some tests. Documenting the results here just in case we have to look back at it: ``` nosetests --with-marvin

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1024#issuecomment-153351476 Thanks @remibergsma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

Thanks I have downloaded and installed Sphinx so I will be able to generate the docs before the next PR. Ron On 03/11/2015 5:49 AM, terbolous wrote: Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153351842 @remibergsma agree regarding the rebase effort. However, I am not going to spend time testing now knowing that it will need to be retested when master is unfrozen.

Re: [GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

I can make a JIRA if that will help keep things straight. Ron On 03/11/2015 4:41 AM, DaanHoogland wrote: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153299225 Ron, your PR looks fine. It is kind of

Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Cool, thanks Remi! a job is scheduled to run tomorrow morning and looking forward to see 100% passrates! Best Raja > On Nov 3, 2015, at 6:05 PM, Remi Bergsma wrote: > > Hi Raja, > > Please see this PR: https://github.com/apache/cloudstack/pull/1028 > > Regards, > Remi > > > > >> On 30

Re: Git with Eclipse

Thanks for the feedback. It is just a small change to see if I can get the process to work. It is an attempt to clarify a section that I found a bit hard to understand so I hope that it does make that section easier to read for the next person. There is a lot more information in the 4.4 Design

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

Github user ronatartifact commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153356376 I considered using a link but was unsure about the policy of references to outside documents. It creates a link that can be easily broke

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

Github user michaelandersen commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1028#discussion_r43748177 --- Diff: test/integration/smoke/test_vpc_vpn.py --- @@ -570,127 +584,139 @@ def test_vpc_site2site_vpn(self): finally:

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153363457 Ping @remibergsma @karuturi @DaanHoogland @borisroman It's working already, but I'm modifying the tests. I pushed by mistake. If you want to start

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153367941 @jburwell @remibergsma Pls note all again that the changes to core are very minimal and are limited to convenience extensions only. I would expect running the

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153369716 @KrisSterckx this plugin is part of the code that is the responsibility of the community. Therefore, we need to verify its operation in addition to the core change

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-153369869 @DaanHoogland I meant the version of libvirt running on the HV which is out of our control. I still vote for no longer supporting Ubuntu 12.04 for that reason f

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153370030 Ping @remibergsma @karuturi @borisroman @DaanHoogland The test is ready! It now does the following: 1. Creates network + VM + FW + PF + Def

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153370288 Overall this seems OK, but I personally think that we can enable it by default on all KVM guests. It doesn't hurt to add the port. We can detect if the port is

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-153371179 My bad, there is no libvirt-java upgrade possible at this point. I was mistaking libvirt 1.1.0 for a possibility. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153371614 @wilderrodrigues my bubble is very busy but ping if you are ready and need testing --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1024#issuecomment-153371665 :+1: (code review only) good improvement. A test case would have been nice. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153372412 Thanks @wilderrodrigues I will test this tomorrow morning IST --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153373302 @jburwell we have added unit testing and Marvin tests, and we posted the results of Marvin in the Jira ticket, but in order to run the Marvin tests you need a Nu

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153373615 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: [4.6/master] CLOUDSTACK-9019: Add storage...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1024#issuecomment-153374008 code looks good to me too. what happened to the policy of not accepting anything without test? --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1023#issuecomment-153376651 The last test failed because the connection timed out without printing "Giving up.", as I expected in the test. You can see the output below: ```

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153390623 @remibergsma @borisroman I'm closing this PR since I've been able to figure out how the mysql driver is being loaded in the RPM install. It happens that it's

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/950 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-153396280 @miguelaferreira Shame, though I understand ;). Just for reference; here it loads the mysql-connector-jar [0]. It is loaded before the main app because it's in th

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1027#issuecomment-153404172 The virtio console is a bridge between hypervisor and vm instance. I am not sure if customers feel good/friendly with this. I donot know if libvirt-java

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1029 CLOUDSTACK-9022: keep Destroyed volumes for sometime for now, the Destroyed volumes will be expunged in Storage cleanup thread, no matter when they are destroyed. In Expunging vm thread

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153418530 @KrisSterckx it not a matter of trust. By contributing this code to our community, we are responsible for its long-term support and maintenance. Therefore, we mus

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-153424524 @jburwell How do we do this with other such plugins? Nicira, SolidFire & friends. Since we do not have the hardware, there is no way to verify its functionality

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153425811 agreed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153427077 @bhaisaab this is awesome! Do you know if the "search box" in the Instances page will also take into account this field? Will make finding VMs easier! --- If your

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153430373 @NuxRo I can check this tomorrow, I think search box simply queries listVirtualMachines API which does not support filtering by passing an IP argument. On

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153431622 @bhaisaab Thanks for that. The UI is indeed in need of attention. The problem with listing the VMs is that the UI will only show a few, then as you scroll dow

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153437575 @NuxRo I did some pagesize and latency comparisons for one of the views/APIs (see: https://github.com/apache/cloudstack/pull/751#issuecomment-135661968); I think

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153439504 That would help, I'm all for 100+ :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

  1   2   >