Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/1023#issuecomment-153376651
  
    The last test failed because the connection timed out without printing 
"Giving up.", as I expected in the test. You can see the output below:
    
    ```
    {Cmd: wget -t 1 -T 1 www.google.com via Host: 192.168.23.6} {returns: 
[u'--2015-11-03 14:44:03--  http://www.google.com/', u'Resolving 
www.google.com... failed: Connection timed out.', u"wget: unable to resolve 
host address 'www.google.com'"]}
    {Cmd: wget -t 1 -T 1 www.google.com via Host: 192.168.23.6} {returns: 
[u'--2015-11-03 14:44:03--  http://www.google.com/', u'Resolving 
www.google.com... failed: Connection timed out.', u"wget: unable to resolve 
host address 'www.google.com'"]}
    {Cmd: wget -t 1 -T 1 www.google.com via Host: 192.168.23.6} {returns: 
[u'--2015-11-03 14:44:03--  http://www.google.com/', u'Resolving 
www.google.com... failed: Connection timed out.', u"wget: unable to resolve 
host address 'www.google.com'"]}
    {Cmd: wget -t 1 -T 1 www.google.com via Host: 192.168.23.6} {returns: 
[u'--2015-11-03 14:44:03--  http://www.google.com/', u'Resolving 
www.google.com... failed: Connection timed out.', u"wget: unable to resolve 
host address 'www.google.com'"]}
    ```
    
    I will push another time and will rely on a better test string. But no 
worries, the fix is fine!
    
    * Test results:
    
    ```
    Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
    ok
    Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
    ok
    Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
    ok
    Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : FAILED ===
    FAIL
    
    ======================================================================
    FAIL: Test redundant router internals
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File 
"/data/git/cs1/cloudstack/test/integration/component/test_routers_network_ops.py",
 line 473, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
        "Attempt to retrieve google.com index page should NOT be successful"
    AssertionError: Attempt to retrieve google.com index page should NOT be 
successful
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to