Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/926#discussion_r41961743
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -310,8 +326,17 @@ private void init(Map configs) {
_executor.scheduleAtFixed
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/926#discussion_r41961770
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -310,8 +326,17 @@ private void init(Map configs) {
_executor.scheduleAtFixed
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/926#discussion_r41961830
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -700,6 +734,121 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-147961785
@wido I will add some debug/info log messages later.
Do you think if it is good to remove the hardcoded 300 seconds?
---
If your project is set up for it, yo
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-147962383
@ustcweizhou I understand the reasoning behind the 300 second minimal
interval, but isn't that up to the admin? If he/she wants to set it to 10
seconds on their cloud,
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-147969907
@wido the default value is 0, which means the statistics is disabled by
default.
I will remove the 300 seconds limitation if most of us agree.
the vm disk
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/787#issuecomment-147970195
@remibergsma I will add the test if I gets the time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/931
CLOUDSTACK-8947 - Load Balancer not working with Isolated Networks
This PR fixes the Load Balance feature by adding iptables rules for the
public IP and port of the LB.
In order
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-147986130
Hi @remibergsma @karuturi @wido @borisroman @DaanHoogland @miguelaferreira
@bhaisaab
* Environment for required_hardware=true
* Management Ser
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41971547
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py ---
@@ -150,6 +150,8 @@ def compare(self, list):
new_rule.se
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41971855
--- Diff: test/integration/smoke/test_loadbalance.py ---
@@ -254,30 +255,30 @@ def test_01_create_lb_rule_src_nat(self):
)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41971913
--- Diff: test/integration/smoke/test_loadbalance.py ---
@@ -371,22 +372,22 @@ def test_02_create_lb_rule_non_nat(self):
"Check List Load
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41971893
--- Diff: test/integration/smoke/test_loadbalance.py ---
@@ -371,22 +372,22 @@ def test_02_create_lb_rule_non_nat(self):
"Check List Load
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-147988545
LGTM (not tested). Just fix the test to use a for x in range(5) and break
if unameResults are not None.
---
If your project is set up for it, you can reply to this
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972015
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java
---
@@ -0,0 +1,54 @@
+//
+// Licensed to the Apac
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972058
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionCommand.java
---
@@ -0,0 +1,58 @@
+//
+// License
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972073
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java
---
@@ -48,13 +53,93 @@ public boolean isL3Network(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972064
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsAnswer.java
---
@@ -0,0 +1,79 @@
+//
+// Licensed t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972179
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -83,9 +92,130 @@ public String getVmUuid() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972163
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
---
@@ -112,13 +147,212 @@ public boolean isDef
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972148
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java
---
@@ -87,29 +114,285 @@ public boolean isDo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972191
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java
---
@@ -40,9 +43,61 @@ public String getVpcUuid()
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972200
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java
---
@@ -0,0 +1,295 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972314
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -79,4 +191,47 @@ public boolean executeIn
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972355
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java
---
@@ -39,4 +39,22 @@ public VspResourceAnswer(VspResourceCo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972373
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,60 @@
+//
+// Licensed to th
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972321
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java
---
@@ -79,4 +79,41 @@ public String getProxyUserDomainuuid(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972301
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java
---
@@ -51,13 +61,91 @@ public boolean isL3Net
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41972411
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py ---
@@ -150,6 +150,8 @@ def compare(self, list):
new_rule
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972646
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java
---
@@ -26,4 +26,14 @@
public StartupVspCommand() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41972823
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/CmdBuilder.java ---
@@ -0,0 +1,24 @@
+//
+// Licensed to the Apache Software
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-147990778
Thanks @wilderrodrigues. I will run the tests tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-147991655
Based on the code this seems good to me. I haven't been able to verify it
though.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41973409
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdAnswer.java
---
@@ -0,0 +1,71 @@
+//
+// Licensed to t
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41973419
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java
---
@@ -0,0 +1,70 @@
+//
+// Licensed to
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41973391
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainCommand.java
---
@@ -0,0 +1,91 @@
+//
+// Licensed to the Apa
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41973323
--- Diff: plugins/network-elements/nuage-vsp/pom.xml ---
@@ -28,6 +28,13 @@
4.6.0-SNAPSHOT
../../pom.xml
+
+
+
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41973455
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java
---
@@ -39,4 +39,21 @@ public String getNuageVspEntity() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41973520
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/dao/NuageVspDaoImpl.java
---
@@ -36,11 +34,16 @@
implements NuageVspDao {
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/931#discussion_r41973826
--- Diff: test/integration/smoke/test_loadbalance.py ---
@@ -254,30 +255,30 @@ def test_01_create_lb_rule_src_nat(self):
)
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-147993624
code LGTM, few small remarks. (Probably won't have/make time to run a test
before the others:()
---
If your project is set up for it, you can reply to this ema
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/931#issuecomment-148001804
@wilderrodrigues I will build and run it soon. Will post results later
today or tomorrow, depending on when it's done. Thanks!
---
If your project is set up for
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41977477
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsAnswer.java
---
@@ -0,0 +1,79 @@
+//
+// Licen
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148011083
Testing OK.
Can you recover the change on line 120 ? it is not needed, right?
Checking the source code, I think 4.5 should have the same issue.
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979052
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -205,9 +254,79 @@ public boolean implement(Network
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979420
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java
---
@@ -31,4 +31,13 @@ public ApplyStaticNatVsp
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979391
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -303,13 +422,17 @@ protected boolean canHandle(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979426
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java
---
@@ -19,26 +19,26 @@
package com
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979431
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java
---
@@ -31,4 +31,14 @@ public TrashNetworkVspAnswer(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979423
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspAnswer.java
---
@@ -17,18 +17,27 @@
// under the License.
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979424
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java
---
@@ -31,4 +31,13 @@ public ShutDownVpcVspAnswer
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979442
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsCommand.java
---
@@ -17,38 +17,28 @@
// under the Lice
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979446
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionAnswer.java
---
@@ -0,0 +1,43 @@
+//
+// Licensed
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979480
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java
---
@@ -31,4 +31,13 @@ public ApplyAclRuleVspAnsw
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979466
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java
---
@@ -31,4 +31,14 @@ public DeallocateVmVspAnswer(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979553
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,60 @@
+//
+// Licensed to th
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979581
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java
---
@@ -31,4 +31,13 @@ public SyncVspAnswer(SyncVspCommand c
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41979565
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceAnswer.java
---
@@ -0,0 +1,41 @@
+//
+// Licensed to the
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41980395
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -205,9 +254,79 @@ public boolean implement(Network
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41980442
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -303,13 +422,17 @@ protected boolean canHandle(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41980490
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -368,18 +492,15 @@ public boolean applyStaticNats(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41980525
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -447,13 +568,95 @@ protected boolean applyACLRules
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41981224
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -114,7 +117,9 @@ public Network design(Netwo
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41981328
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -129,66 +134,94 @@ public Network design(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41983905
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -129,66 +134,94 @@ public Network design(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41983983
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -129,66 +134,94 @@ public Network design(Net
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41984374
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -322,35 +389,52 @@ public void shutdown(Netw
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41984944
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -358,19 +442,28 @@ private String getVirtual
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41984914
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -358,19 +442,28 @@ private String getVirtual
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41985327
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -67,25 +74,76 @@
import com.cloud.network
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41985416
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -109,12 +163,49 @@
@Inject
V
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41985628
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -109,12 +163,49 @@
@Inject
V
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41985759
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -122,13 +213,13 @@
cmdList.add(De
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41986510
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41986564
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41986636
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41986904
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41986950
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41986962
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41987747
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41987775
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41987892
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41988014
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -152,50 +243,179 @@ public NuageVspDeviceVO
a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/918#issuecomment-148038282
LGTM indeed! @remibergsma and @karuturi can you please merge this one in
your next batch?
---
If your project is set up for it, you can reply to this email and
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41988124
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -247,6 +467,26 @@ public boolean
deleteNuageV
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41988188
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +525,345 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41988458
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java
---
@@ -285,60 +525,345 @@ public boolean
deleteNuag
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41988797
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -262,15 +260,19 @@ public String getName() {
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41989312
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -360,32 +375,25 @@ private Answer
executeReques
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/930#discussion_r41989516
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -117,7 +117,7 @@ get_boot_params() {
if [ ! -e /dev/vport0
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/930#discussion_r41989612
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -128,7 +128,14 @@ get_boot_params() {
echo $pubkey >
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148042852
@bvbharatk Thanks for the PR, I'll test it today or tomorrow.
Did you run the BVT tests that reboot the cpm and ssvm? If not, please do.
If you did, please po
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41989728
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -403,20 +412,36 @@ private Answer executeRequest
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41989725
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -393,9 +401,10 @@ private Answer executeRequest(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41989708
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -360,32 +375,25 @@ private Answer
executeReques
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41989738
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -424,9 +449,10 @@ private Answer executeRequest(
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/932
CLOUDSTACK-8708: gson update and ArrayTypeAdaptor rewrite
unit test for RequestTest is passing in eclipse. On macosx 10.11 using java
1.8 or 1.7 it fails from the command line.
You can mer
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41989863
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -437,31 +463,79 @@ private Answer executeRequest
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41989853
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -424,9 +449,10 @@ private Answer executeRequest(
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41989892
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -437,31 +463,79 @@ private Answer executeRequest
1 - 100 of 152 matches
Mail list logo
