Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/926#discussion_r41961770
  
    --- Diff: server/src/com/cloud/server/StatsCollector.java ---
    @@ -310,8 +326,17 @@ private void init(Map<String, String> configs) {
                 _executor.scheduleAtFixedRate(new VmDiskStatsTask(), 
vmDiskStatsInterval, vmDiskStatsInterval, TimeUnit.SECONDS);
             }
     
    +        if (vmNetworkStatsInterval > 0) {
    +            if (vmNetworkStatsInterval < 300)
    +                vmNetworkStatsInterval = 300;
    +            _executor.scheduleAtFixedRate(new VmNetworkStatsTask(), 
vmNetworkStatsInterval, vmNetworkStatsInterval, TimeUnit.SECONDS);
    +        } else {
    +            s_logger.debug("vm.network.stats.interval - " + 
vmNetworkStatsInterval + " so not scheduling the vm network stats thread");
    --- End diff --
    
    Maybe explain here that a negative value is not allowed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to