Re: UI translation for 4.6

2015-10-10 Thread Go Chiba
Hi guys, I just finished to translate Japanese UI resources last night, and can you anyone merge it to 4.6? from my iPhone 2015/10/09 10:49、Sebastien Goasguen のメッセージ: > Milamber reminded me that before releasing 4.6 we should include the latest > translated strings for the UI. > If you care

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-147071706 @nlivens @KrisSterckx I have issues building this and I also see a Jenkins build error (but the job has been removed so I cannot see if it is similar). Would you

Re: KVM HA is broken, let's fix it

2015-10-10 Thread Remi Bergsma
Hi Lucian, Can you please explain what the issue is with KVM HA? In my tests, HA starts all VMs just fine without the hypervisor coming back. At least that is on current 4.6. Assuming a cluster of multiple nodes of course. It will then do a neighbor check from another host in the same cluster.

Re: KVM HA is broken, let's fix it

2015-10-10 Thread Nux!
Hi Remi, So we started here with Andrei (v4.5) complaining a slow NFS causes a mass reboot: http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201510.mbox/%3C18886119.904.1444382474932.JavaMail.andrei%40tuchka%3E My claim that the VM is not started until the HV is back is not based on per

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-147077287 @ustcweizhou Can you look at the jenkins error? Something very serious happened in this build Running org.apache.cloudstack.networkoffering.CreateNe

[GitHub] cloudstack pull request: Local cloudstack

2015-10-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/919#issuecomment-147078784 @sarathkouk is there an issue in jira for this? what does it test more precisely? People are more leanient on test code PRs then core code but I would like to s

Re: CCCEU15: on site discussions around QA and release of 4.6 report

2015-10-10 Thread Daan Hoogland
thanks guys, To bad I couldn't stay for this but I'll take some time to send you my nagging on this soon ;) I hope I can afford to spend a lot of time on generic quality issues on Leaseweb's accord. We will be discussing this on Monday. On Fri, Oct 9, 2015 at 6:07 PM, Pierre-Luc Dion wrote: > H

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-10 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/920#issuecomment-147081834 looks like all tests passed but in fact some did not run...someone needs to check what happened exactly --- If your project is set up for it, you can reply to this e

Re: UI translation for 4.6

2015-10-10 Thread Daan Hoogland
sebastien and Dutch users, I have translated some strings. I think we need to review each other on this as sometimes a translation holds the middle ground between ridiculous and over the top when done from english to dutch. I would like to translate everything (185 strings to go). On Sat, Oct 10,

Re: CLOUDSTACK-8793 (s2s fix) blocked by CLOUDSTACK-8890 (project bug)

2015-10-10 Thread Rohit Yadav
Hi Will, Sorry I missed this email. Looks like this bug has been fixed on master, does this still apply for 4.5 or do you want it to be backported on 4.5 for future 4.5.3 can have it? Regards. On Tue, Sep 22, 2015 at 8:00 PM, Will Stevens wrote: > It is very important that we get CLOUDSTACK-889

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-147089236 LGTM. Looks like jvm crashed while building the maven cloud-server project/module. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-147089251 @ustcweizhou can you do a push again to force travis/jenkins to re-run. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/916#issuecomment-147089352 @kansal LGTM. Looking at the JIRA issue, this looks like should apply to 4.6/master but can you update the ticket with the version details, more details on

[GitHub] cloudstack pull request: Pr 906 912 bug zone wizard and adv search...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/915#issuecomment-147089366 UI change LGTM. Thanks @milamberspace --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: another typo that appears when monitoring...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/913#issuecomment-147089443 LGTM, though we will need to check if these strings are consumed through any APIs so that we don't end up breaking backward/API compatibilies --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-8931: Fail to deploy VM instan...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/907#issuecomment-147089643 @kansal can you look at why travis failed, fix it; in case it was a travis issue, can you repush the change to re-trigger Travis. Thanks. --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-8902 Restart Network fails in ...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/898#issuecomment-147089698 LGTM, please merge once tested. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-147089728 LGTM (reviewed the changes, did not test it though) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8908 After copying the templat...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/896#issuecomment-147089792 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8913: Search box in Templates ...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/891#issuecomment-147089875 LGTM. Thanks (have seen this on both 4.5/master). Once this is merged on master, we'll need to backport this too 4.5 as well. --- If your project is set up for

[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/890#discussion_r41697298 --- Diff: api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java --- @@ -44,10 +44,10 @@

[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/888#issuecomment-147090129 Wait, I don't remember but did n't I merge this on master? I'm sure it is in 4.5. (sorry, in case I missed this fix). --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/888#issuecomment-147090137 LGTM, please merge once tested. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-147090189 LGTM (code-wise), let's merge this once tested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/880#discussion_r41697322 --- Diff: setup/db/db/schema-452to460.sql --- @@ -413,3 +413,4 @@ CREATE TABLE `cloud`.`ldap_trust_map` ( UNIQUE KEY `uk_ldap_trust_map__domain_id`

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-147090210 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-147090242 LGTM (did not test, just reviewed code), can you check why Jenkins failed and also re-push to trigger them if necessary. Thanks. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8896: allocated percentage of ...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/873#discussion_r41697351 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1736,7 +1737,10 @@ public boolean storagePoolHasEnoughSpace(List volumes, StorageP

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-147090386 LGTM, let's merge this once tested with both Windows and OSX clients. Thanks @jayapalu for the fix. --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-147090425 Any update on this @bvbharatk ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/864#issuecomment-147090446 LGTM, you rebase against latest master @bvbharatk and reply to Wido's comment. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/852#issuecomment-147090501 LGTM, thanks for the cleanup :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/849#issuecomment-147090524 LGTM, lets' merge it after some tests. Thanks @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-147090599 Rebased against latest master, now fixing the above mentioned issues. --- If your project is set up for it, you can reply to this email and have your reply appear o

Unable to compile 4.5 branch

2015-10-10 Thread cs user
Hi Folks, I'd really appreciate some help with this if anyone can spare a moment :-) So I've checked out the repo and got to this stage in git: [csuser@localhost cloudstack]$ git status # On branch origin/4.5 nothing to commit (working directory clean) I've then done a mvn clean, and all is

Re: Unable to compile 4.5 branch

2015-10-10 Thread cs user
Apologies, sent that too early, last bit should be : Apache Maven 3.0.4 (r1232337; 2012-01-17 08:44:56+) Maven home: /usr/local/apache-maven-3.0.4 Java version: 1.7.0_75, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.75.x86_64/jre Default locale: en_US, platform e

Re: Unable to compile 4.5 branch

2015-10-10 Thread Frank Maximus
Mvn.skip.tests=true will skip building the test jar. Running without that option should work. Regards, Frank Apologies, sent that too early, last bit should be : Apache Maven 3.0.4 (r1232337; 2012-01-17 08:44:56+) Maven home: /usr/local/apache-maven-3.0.4 Java version: 1.7.0_75, vendor: Oracl

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-14740 @nlivens @KrisSterckx Build issue resolved on my side. I've run the below tests and I see some failures. Rebasing against current master may resolve some of them

Re: Unable to compile 4.5 branch

2015-10-10 Thread Rohit Yadav
Can you try with: mvn clean install -pl api And then, try with the impatient profile skipping the tests. I’ve just built latest 4.5 branch and it works for me. Regards. On 10-Oct-2015, at 4:00 pm, cs user mailto:acldstk...@gmail.com>> wrote: Hi Folks, I'd really appreciate some help with th

[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/888#issuecomment-147111458 @svenvogel Something went wrong with the squashing as you now have 4 commits for this change. Can you make it a single commit please? Let me know if you need hel

[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/888#issuecomment-147111646 @svenvogel Please update the title to something like this: "CLOUDSTACK-8812 Fix CentOS 7 systemd-tmpfiles - Operation not permitted" as it is more descriptive.

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699435 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade452to460.java --- @@ -60,10 +60,25 @@ public boolean supportsRollingUpgrade() { @O

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699441 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +469,35 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed ...

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/787#issuecomment-147111984 @bhaisaab Can you have a look at the code please? @anshul1886 How can we test this? Thanks! --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699462 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699509 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundatio

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699540 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,214 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-147112377 Hi @pdube Jenkins failed, it's probably unrelated to your change: ``` [ERROR] Internal error: java.lang.IllegalStateException: Invalid object ID 14 i

[GitHub] cloudstack pull request: CLOUDSTACK-8825, CLOUDSTACK-8824 : Fixed ...

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/787#issuecomment-147112390 LGTM, let's merge this after testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699609 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,214 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-147112559 It's not only remote access VPN, also site-to-site VPN. When testing, one need to build a cloud with a systemvm template generated from this branch. Curr

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699647 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,88 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-147112657 @jayapalu Please rebase against current master, as in this branch the default route is broken so it doesn't work. Also, there's an open question on 'rightsubnetw

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699658 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,82 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/864#issuecomment-147112744 Once rebased we can run tests, otherwise we will find false positives. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-147112896 We won't merge this PR, we should merge #861 instead. Final call to @SudharmaJain to confirm if PR #861 also fixes your issue. If I do not get a response in the

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699715 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,82 @@ +//Licensed to the Apache Softwar

[GitHub] cloudstack pull request: CLOUDSTACK-8888: Xenserver 6.0.2 host stu...

2015-10-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/861#issuecomment-147113023 I commented on #883 and will merge this in a few days. Let's hope @SudharmaJain responds. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699728 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699743 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699765 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699770 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699776 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699779 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699781 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699787 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/UserVmDetailsDaoImpl.java --- @@ -0,0 +1,62 @@ +// Licensed to the Apache Software Fou

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699786 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,86 @@ +// Licensed to the Apache Software F

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-10-10 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-147113348 The jenkins job is created: build-systemvm64-GithubPullRequest and is currently building this branch as tests. will see the result of the job#1 ... --- If your pr

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699797 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaBalanceVO.java --- @@ -0,0 +1,127 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699804 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaCreditsVO.java --- @@ -0,0 +1,117 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699802 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaCreditsVO.java --- @@ -0,0 +1,117 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699807 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaEmailTemplatesVO.java --- @@ -0,0 +1,109 @@ +//Licensed to the Apache Software Fou

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699812 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaTariffVO.java --- @@ -0,0 +1,162 @@ +//Licensed to the Apache Software Foundation (

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699816 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/QuotaUsageVO.java --- @@ -0,0 +1,172 @@ +//Licensed to the Apache Software Foundation (A

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699826 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/UserVmDetailVO.java --- @@ -0,0 +1,83 @@ +//Licensed to the Apache Software Foundation (

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699824 --- Diff: framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java --- @@ -0,0 +1,336 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699833 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,136 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699835 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,136 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699838 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,147 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699841 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateUpdateCmd.java --- @@ -0,0 +1,122 @@ +//Licensed to the Apa

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699836 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,147 @@ +//Licensed to the Apache Software

Re: Unable to compile 4.5 branch

2015-10-10 Thread cs user
Hi Frank/Rohit, Many thanks to you both for getting back to me, very much appreciated. Running it without this: Mvn.skip.tests=true Appears to have fixed it for me... :-) Should have given it a try, I thought having that in there would be helping to get past this issue. So for anyone else who

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699842 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699840 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateListCmd.java --- @@ -0,0 +1,60 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699851 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java --- @@ -0,0 +1,95 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699848 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache Softwa

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699853 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffUpdateCmd.java --- @@ -0,0 +1,102 @@ +//Licensed to the Apache Sof

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699928 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java --- @@ -0,0 +1,153 @@ +//Licensed to the Apache So

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699930 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaBalanceResponse.java --- @@ -0,0 +1,153 @@ +//Licensed to the Apache So

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699949 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699953 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699961 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699964 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699970 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699975 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699976 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41699986 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r4160 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r4163 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota

2015-10-10 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r4173 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaStatementItemResponse.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apa

  1   2   >