Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-141662154
@DaanHoogland Why log when an exception is thrown? In a test when an
exception is thrown it should either fail, or when @Test(expected =
--exception.class--) is d
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-141683980
To get this PR going, you could extract the code â"%" + "replace(" +
domainHandle.getPath() + ", '%', '[%]')" + "%"â of line 357 to a method and
then c
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-141687462
Thanks for the suggestion. yes, I will follow the same. I will make an
another PR with the change and test file.
---
If your project is set up for it, you ca
GitHub user SudharmaJain opened a pull request:
https://github.com/apache/cloudstack/pull/851
CLOUDSTACK-8864: Not able to add TCP port forwarding rule in VPN for â¦
â¦specific ports
Setting port forwarding rules for port 500,1701 and 4500 after enabling
VPN, gives the er
GitHub user alexandrelimassantana opened a pull request:
https://github.com/apache/cloudstack/pull/852
Removal of DefaultUserAuthenticator empty class.
The DefaultUserAuthenticator is an empty class, extending from the
AdapterBase and implementing the UserAuthenticator interface.
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/853
Removed unnecessary @Local annotations and their respective imports
Following @rafaelweingartner 's findings in PR #714 that many spring beans
contained an @Local annotation, we've decided
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/854
Fixed return type Void to void in DataMotionStrategy.
The main changes are:
- Changing methods âVoidâ to âvoidâ.
- Removal of the method âVoid copyAsync(DataObject srcData
GitHub user alexandrelimassantana opened a pull request:
https://github.com/apache/cloudstack/pull/855
Removal of class AgentBasedStandaloneConsoleProxyManager
The AgentBasedStandaloneConsoleProxyManager class is neither manually
instatiated anywhere in the code nor via Spring. F
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/856
Removed the empty class 'com.cloud.deploy.PlannerBase'
Removed the PlannerBase class because it is does not bring contribution to
ACS' code.
We changed com.cloud.deploy.FirstFitPl
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/854#issuecomment-141711633
Hi @rodrigo93,
It seems there is a problem with your PR. Please in Eclipse go:
Window>Preferences>Java> Editor>Save Actions:
Then click on
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/853#issuecomment-141711752
Hi @critofolini, I think that there is a problem in your PR in class:
SecurityGroupManagerImpl
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/856#issuecomment-141712362
@pedro-martins that is good that you removed and unused method in
com.cloud.deploy.DeploymentPlanner, however you forgot to remove all of the
implementatio
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/854#issuecomment-141713041
@rodrigo93 nice commit.
Could you squash your commits?
Here is a link, if you do not know how to do that.
http://gitready.com/advanced/2009/
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-141720864
@nitin-maharana, you do not need to open a new PR. You can continue working
on this one, just do whatever is needed and commit to this branch.
---
If your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/852#issuecomment-141721291
Nice work @alexandrelimassantana, the class âDefaultUserAuthenticatorâ
does not bring anything new to the hierarchy. Moreover, it has a comment âUse
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-141721624
Hi @alexandrelimassantana,
I checked and also could not find any references for that class. That is
nice that you are removing some code that was left
16 matches
Mail list logo
