[GitHub] cloudstack pull request: Quota master

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951326 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134872980 Hi @ustcweizhou Can you use the merge-pr script next time? scripts is at https://github.com/apache/cloudstack/blob/master/tools/git/git-pr wiki explai

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/739#issuecomment-134872958 I've add a similar fix for listing iso/zone page and also added code that would de-dupe any isos and templates in the main list view. --- If your project is set up

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952261 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952242 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952248 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952280 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952296 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/740#issuecomment-134873788 I've updated the PR to fix the same issue for listing isos and also addition code to de-dupe list iso and template results. --- If your project is set up for it, y

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952287 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952257 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/741#discussion_r37952326 --- Diff: plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java --- @@ -449,12 +450,34 @@ public Answer CleanupNetwork

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952302 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134875242 HI @koushik-das I've reviewed the code in this PR and it looks pretty good. I really like what might seem like small things (lower-case on method na

[GitHub] cloudstack pull request: Quota master

Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-134875791 The Transaction open and close causing churn in database connection is based on the notion that these methods somehow open and close db connections. As

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/692#issuecomment-134876392 @DaanHoogland OK, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/735#discussion_r37953111 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java --- @@ -286,7 +287,11 @@ private void deleteExitingLinkLoca

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/744 CLOUDSTACK-8773 : NPE in CheckRouterTask, when a DomainRouter happens… … to be expunged at the same time You can merge this pull request into a Git repository by running: $ git pull htt

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134882707 @karuturi Sure, I tried before the merge, but got the following message: [root@git (master)]# git pr 730 /root/git/master/tools/git/730.json ERROR

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/741#discussion_r37955517 --- Diff: plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java --- @@ -449,12 +450,34 @@ public Answer CleanupNetworkRule

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/735#issuecomment-134890826 renamed the method, s/deleteExitingLinkLocalRouteTable/deleteExistingLinkLocalRouteTable/g --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/741#discussion_r37956660 --- Diff: plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java --- @@ -449,12 +450,34 @@ public Answer CleanupNetwork

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134895552 @miguelaferreira For running tests using simulator follow this https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes,

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/744 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134897494 I completely understand the reasoning behind the header text, I just don't agree that ".. following fixes .." is a good header for a commit. But given the cu

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/745 CLOUDSTACK-8773 : NPE in CheckRouterTask, when a DomainRouter happens… … to be expunged at the same time You can merge this pull request into a Git repository by running: $ git pull htt

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134899773 interesting... I do not see any such error while merging this pr It uses python to get the author info on the contents of the url https://api.github.com/repos/ap

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/735 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134901921 @miguelaferreira Sure a test can be added. Would you mind creating one and send out a PR? You can start with the smoke/test_scale_vm.py and tweak it to run only

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8754: VM migration triggered b...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/725#issuecomment-134902453 FWIW, this LGTM; @koushik-das please send a different PR in future if you decide to add tests and do further enhancements. Travis is green, merging now. -

[GitHub] cloudstack pull request: CLOUDSTACK-8754: VM migration triggered b...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/745#discussion_r37960337 --- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java --- @@ -251,8 +251,11 @@ public boolean remove(final Long id) { sc.setJ

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134905914 Sure, I can help you. I will write the test for this PR and then make another PR that you can merge into this one. PR of PR :) I love the github workflow!

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/745#issuecomment-134906322 A unittest to verify this case would be nice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-134909228 @koushik-das what are the volume attach/detach agent commands, if these are not being used? --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: [Automation]Volume migration between pool...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/742#issuecomment-134910967 I lack the infra to test this, but LGTM; but maybe fix that functional issue @sanju1010 has commented --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/745#issuecomment-134910642 LGTM, you can also use the method @karuturi has suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Build failed in Jenkins: simulator-4.5-singlerun #266

See -- Started by upstream project "build-4.5-simulator" build number 321 originally caused by: Started by upstream project "build-4.5" build number 518 originally caused by: Started by an

[GitHub] cloudstack pull request: CLOUDSTACK-8765: fix vm migration failure...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/736#issuecomment-134912144 @ustcweizhou interesting find and fix, we should also merge this on 4.5; LGTM. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134912770 Code LGTM (not tested on a real infra though), merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/728#discussion_r37961562 --- Diff: tools/marvin/marvin/config/test_data.py --- @@ -775,6 +775,15 @@ "ostype": "CentOS 5.6 (64-bit)" }, +"CentOS

[GitHub] cloudstack pull request: CLOUDSTACK-8755: xs-tools.iso missing fro...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/727#issuecomment-134913294 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-134913426 LGTM (not tested on a real infra), can you share output ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/745#issuecomment-134914138 @karuturi I've used the method you suggested, this problem occurs in a specific scenario which is hard to reproduce in a consistent way. --- If your project is set

[VOTE] Release Apache CloudStack EC2stack 0.8.0

Hi All, I've created a 0.8.0 release of EC2stack, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack-ec2stack.git Commit: a61d7c01129dfe4c31515a48e0f6b4a53436c208 There are no code changes from the time the code was donate

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/706#issuecomment-134915109 All, let's not do this for multiple reasons; - by closing a PR which has not got attention we risk forgetting about it and losing the contribution - gen

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/745#issuecomment-134916577 @nlivens thanks for the update. :+1: will merge in sometime once travis completes. I assigned you CLOUDSTACK-8773. please resolve it once this is merged. ---

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/696#issuecomment-134916799 LGTM. I second @wido. We should try to get rid of direct virsh commands, would you like to work on improving this to use libvirt-java? (and if bindings are lacking

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/729 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8765: fix vm migration failure...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: verify that when createTemplate is ued to...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/688#issuecomment-134918074 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/691#issuecomment-134917634 LGTM. @cloudsadhu are you improving it based on @ksowmya 's comment? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/728#discussion_r37962558 --- Diff: tools/marvin/marvin/config/test_data.py --- @@ -775,6 +775,15 @@ "ostype": "CentOS 5.6 (64-bit)" }, +"Cen

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/706#issuecomment-134919031 @bhaisaab OK, let's leave it for now and discuss later. I will close the PR. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-134919051 Can you add some tests, we'll need to test it before merging. @DaanHoogland have you looked at it, since you had recently made some related changes or might have ex

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/684#issuecomment-134919215 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/675#issuecomment-134919453 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134919656 Ping, update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/665#issuecomment-134920085 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: Coverity Issue: Null pointer dereferencin...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/629#issuecomment-134920622 @kansal LGTM, can you rebase against master; then we can merge this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8677: Call-home functionality ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/625#issuecomment-134922676 @wido can you implement this as a plugin instead of core feature? Also do we want cloudstack to report statistics on each run; I suggest to have it as a plugin with

[GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/732#discussion_r37963222 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java --- @@ -31,25 +31,36 @@ import org.apache.cloudstack.ap

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-134923025 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-134923368 maybe rebase and fix any issues, to get Travis green before merging this once @wido can review this. --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/665 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/675 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134925254 @bhaisaab What else is needed here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/554#issuecomment-134925991 LGTM, merging. Someone needs to add the unit test, later. I'm trying to build my skills around vmware related codebase. --- If your project is set up for it, you c

[GitHub] cloudstack pull request: CLOUDSTACK-8602. MigrateVirtualMachineWit...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/548#issuecomment-134926126 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8602. MigrateVirtualMachineWit...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134929360 @anshul1886 can you read and reply to some of the comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134928152 anyone working on progressing this PR, I really like it and it has some good things; if no one is I can help take over some things in future (cc @rsafonseca) ---

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37964142 --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java --- @@ -136,13 +136,13 @@ public String getInstanceName() { r

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134929830 @bhaisaab this came out from a roadmap item suggested by @pyr, but it seems he has not had time to review and comment. So this is a bit stuck I am afraid. --- If you

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-134929897 We should keep it open though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-134930046 @bhaisaab I am not sure what was the exact purpose of these agent commands. I believe these existed even before the code was donated to Apache. But if you look a

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134930757 @karuturi Just tried the code you posted, and this was the result: ```zsh jsonTmp=pr.json prAuthor=$(cat ${jsonTmp} | python -c " try:

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37964980 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2188,7 +2188,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws Resource

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134931329 @bhaisaab Lost in discussion and got only end result that all we need is here. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/696#issuecomment-134932108 Not sure if @bhaisaab's comment about improvement is directed at me or @wido. If it was at me, I'd prefer if this could be merged (as it's in the current style and I b

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/692#issuecomment-134932710 verified that conntrackd starts on redundant vpc routers. LGTM in that respect. Design wise i feel we need to refactor this, naming of copy_if_ne

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134933068 Thanks @miguelaferreira. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134934361 @remibergsma @karuturi @miguelaferreira The 730.json is empty. I finally find the repoName (folder name) should be "cloudstack". In my env, it it not. I will

[GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/730#issuecomment-134934893 @ustcweizhou good catch! The idea of that script was to be a simple collection of git commands and assumed that people already understood git. But th

[DISCUSS] Improving community experience for (new) contributors

Hi all, I’ve identified few issues around the recent changes that I don’t know how we can fix or improve but I hope to get feedback from the community. I understand that you may disagree with what I’m sharing which is alright, even in your disagreement I hope that you don’t take an offence on tha

[GitHub] cloudstack pull request: Made following fixes in simulator

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/741#issuecomment-134935544 Cool! I would that that once @miguelaferreira is done with the tests and the PR of PR, we can give a 2nd LGTM and then merge it. Thanks, Miguel!

[GitHub] cloudstack pull request: CLOUDSTACK-8773 : NPE in CheckRouterTask,...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/745 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134936210 @anshul1886 the only concern here is that this sort of breaks the API behaviour as in the past the details would set details (removing old details). LGTM; w

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-134936442 @koushik-das thanks for replying. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/696#issuecomment-134936732 @insom that was for Wido since he has experience in writing bindings in libvirt-java etc. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134938776 @remibergsma @bhaisaab Remi has already tested this and has given the LGTM. --- If your project is set up for it, you can reply to this email and have your reply

Re: [DISCUSS] Improving community experience for (new) contributors

> On Aug 26, 2015, at 12:20 PM, Rohit Yadav wrote: > > Hi all, > > I’ve identified few issues around the recent changes that I don’t know > how we can fix or improve but I hope to get feedback from the > community. > > I understand that you may disagree with what I’m sharing which is > alright

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-134940325 ah, I see merging now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/673 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Default to notify only script to handle n...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/696#issuecomment-134941139 @bhaisaab Yes, willing to do so. I even think that I started to work on this some time ago, but never finished it. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8758: Handle redirects in comm...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/737#discussion_r37968584 --- Diff: pom.xml --- @@ -1,12 +1,23 @@ - + --- End diff -- @pdion891 @miguelaferreira This change broke the debian packaging , be

  1   2   >