Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/745#discussion_r37960337
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -251,8 +251,11 @@ public boolean remove(final Long id) {
sc.setJoinParameters("networkRouter", "type",
Network.GuestType.Isolated);
final List<DomainRouterVO> routerIds = listBy(sc);
final List<DomainRouterVO> routers = new
ArrayList<DomainRouterVO>();
- for (final DomainRouterVO router : routerIds) {
- routers.add(findById(router.getId()));
+ for (DomainRouterVO router : routerIds) {
+ router = findById(router.getId());
--- End diff --
Can you use
`CollectionUtils.addIgnoreNull(routers,findById(router.getId()))`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
