[GitHub] cloudstack pull request: This branch implements the CSV and native...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-131701094 @devdeep Did you LGTM on this? Were you able to test / verify it with a hyper-v cluster? @anshul1886 Can you look at the commits and see if you can squas

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131701947 @cristofolini Thanks! As @koushik-das mentions, please squash the commits and force-push to your PR branch. @DaanHoogland Currently @wilderrodrigues is o

[GitHub] cloudstack pull request: This branch implements the CSV and native...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-131724787 @remibergsma Either we have to squash all commits to one commit or leave it as it is. In squashing all commits to one I will put all the relevant messages. These

[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/672#issuecomment-131736170 @remibergsma First part of snapshot improvements is not yet implemented. To test verify following operations VM snapshots and volume snapshots create

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/701 CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persisten… …t VR configuration changes Removed out-of-band VR reboot code Refer to the discussion on dev list

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131741834 @remibergsma @DaanHoogland Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: This branch implements the CSV and native...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-131745938 @anshul1886 Then I'd say squash them into one so you commit the whole functionality as one commit. Also, when you add new code, I'd expect new unit tests as well

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/695#issuecomment-131748203 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

RE: Urgent Question at VPC router:

Thanks for the information Simon, We do add more resource to current VPC/vR and test the max no. of concurrent HTTP connections. We do Static NAT internal VM to external address and port 80 only allowed on public. Currently HTTP connections established 2500 not crossing beyond that, expecting

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131756869 LGTM. one note of worry though. removing the configuration item is arguably a backwards incompatible change to the interface. I don't object to it, as stated by

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131761320 Thanks for picking this up @koushik-das LGTM @DaanHoogland I see your point, but the alternative is a setting that does nothing. I think that is worse. W

[GitHub] cloudstack pull request: CLOUDSTACK-8737: Remove out-of-band VR re...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/701 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: This branch implements the CSV and native...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/351#discussion_r37174039 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -2294,7 +2292,7 @@ private void orchestrateMigrateWithStorage(f

[GitHub] cloudstack pull request: This branch implements the CSV and native...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/351#discussion_r37174252 --- Diff: plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs --- @@ -978,14 +1025,58 @@ public JContainer

[GitHub] cloudstack pull request: This branch implements the CSV and native...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-131768698 I don't see any test, we can not release this to the public without limitation of warranty. extensive testing needs to be implemented to give any degree of cert

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131772545 I know, but he has been busy on this as well, are we in a hurry? On squashing: I agree with the observation that this is one of those exceptions where squashing

[GitHub] cloudstack pull request: CLOUDSTACK-8738: Added the two methods fo...

GitHub user ksowmya opened a pull request: https://github.com/apache/cloudstack/pull/702 CLOUDSTACK-8738: Added the two methods for enable and cancel maintena… Added the two methods for enable and cancel maintenance used in testpath_disablestoragepool Test results: Te

[GitHub] cloudstack pull request: Disablestorage pep8

GitHub user ksowmya opened a pull request: https://github.com/apache/cloudstack/pull/703 Disablestorage pep8 Fixed pep8 issues in script, most of them for E501 (long lines) with max-line-length set to default Test Result: Test Steps: ... === TestName: test_01_disable_en

[GitHub] cloudstack pull request: CLOUDSTACK-8733: Host stuck in rebalancin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/698#issuecomment-131791900 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: Disablestorage pep8

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/703#issuecomment-131792278 Hi @ksowmya Thanks for the PR! It seems this one contains the same commit (2a0eaaebd301c623879384801261c39ea73da305) as in PR #702? Could you please close that o

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/695 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8738: Added the two methods fo...

Github user ksowmya commented on the pull request: https://github.com/apache/cloudstack/pull/702#issuecomment-131794425 Closing since this is part of https://github.com/apache/cloudstack/pull/703/commits --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8738: Added the two methods fo...

Github user ksowmya closed the pull request at: https://github.com/apache/cloudstack/pull/702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Disablestorage pep8

Github user ksowmya commented on the pull request: https://github.com/apache/cloudstack/pull/703#issuecomment-131794674 @remibergsma , Thanks! I've updated this one to include both commits. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/695#issuecomment-131794896 Thanks for merging @remibergsma :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACK-8740: add custom.css to make c...

GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/704 CLOUDSTACK-8740: add custom.css to make custom UI styles easier You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/CLOUD

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37181982 --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java --- @@ -136,13 +136,13 @@ public String getInstanceName() {

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37182838 --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java --- @@ -136,13 +136,13 @@ public String getInstanceName() {

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37183139 --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java --- @@ -136,13 +136,13 @@ public String getInstanceName() {

[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/705 Refactored NicProfile.java for readability. Only changed names and reorganized them! No functional implementation change. See issue CLOUDSTACK-8736 for ongoing effort to clean up net

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37183568 --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java --- @@ -136,13 +136,13 @@ public String getInstanceName() { ret

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/673#discussion_r37183610 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2188,7 +2188,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUn

[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/705#issuecomment-131806145 :+1: this is one of the cases I would have liked to see more commits. lgtm in spite --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/705#issuecomment-131808466 @DaanHoogland I did the following; - Refactored NicProfile.java (in 1 go) - Changed names in every file llinked to NicProfile to make sure no regressi

[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/705#issuecomment-131810351 @borisroman first do internal restructure without changing the class interface and next change the accessors. never mind however don't do double work after I ma

[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/705#issuecomment-131812682 Pending the checks LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack pull request: CLOUDSTACK-8669: create volume failed due...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/695#issuecomment-131816390 @karuturi I'm trying to keep an eye on the PRs and merge those that meet the requirements to keep the list as short as possible :-) --- If your project is set u

[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Coverity Issue: Null pointer dereferencin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/629#issuecomment-131818528 @kansal Any update on this? Please rebase with current master. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

Build failed in Jenkins: build-master-noredist #4531

See Changes: [Boris Schrijver] Refactored NicProfile.java for readability. -- [...truncated 6757 lines...] at com.cloud.hypervisor.ovm3.objects.Xen.listVms(Xen.java:558)

[PROPOSAL] Closing PRs older than 1 month and without activity

Hi all, There are several PRs that are quite old. They haven't been updated by their author for over a month and there was no response to comments made. As a RM, I want to maintain an as-short-as-possible list of PRs that is actively worked on. It is perfectly fine if a PR is open for a longer

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131839611 Hi all, I tried squashing @cristofolini, but for some odd reason could not get the last two together. I had to reset to master and manually add his commits

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/706 Closing PRs older than 1 month and without activity As proposed here: http://cloudstack.markmail.org/search/?q=#query:+page:1+mid:rkptskqvajs7n7zj+state:results This will close thes

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/707 Refactored Nic.java for readability. Only changed names and reorganized them! No functional implementation change. See issue CLOUDSTACK-8736 for ongoing effort to clean up network co

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/700#discussion_r37198033 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpServerResource.java --- @@ -38,20 +32,12 @@ pr

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/700#discussion_r37198057 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpServerResource.java --- @@ -38,20 +32,12 @@ pr

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/700#discussion_r37198072 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer56FP1Resource.java --- @@ -36,18 +31,10 @@ public

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131858619 @rafaelweingartner @cristofolini I love your work, especially the fact the so many litle unit tests were added. It has some checkstyle errors unfortunately (in

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/706#issuecomment-131860676 https://github.com/apache/cloudstack/pull/508 was worked on 14 days ago by @resmo and @wilderrodrigues --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-131864788 80bcfb1 and af199e7 are not atomic then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/706#issuecomment-131864636 @DaanHoogland That's true. Although @wilderrodrigues will take over the PR and needs to create a new one. But let's stick to the proposal indeed. I'll remove #50

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/706#issuecomment-131866061 I did not send a :-1: to dev@. I did not omit that mail by mistake (sorry for the double negative). the proposal seems radical (17 july is phased out on 17 Aug

[GitHub] cloudstack pull request: Closing PRs older than 1 month and withou...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/706#issuecomment-131868071 @DaanHoogland Weekly basis is OK with me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131869268 Now, I am having troubles again with squash. I am using this command “git rebase -i HEAD~2” to squash the last to commits into one. The git pro

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-131871473 @DaanHoogland You are right. I squashed to commits together so there will not be a non-working commit left. --- If your project is set up for it, you can reply t

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131872061 @rafaelweingartner if you git rebase -i HEAD~2 and have $EDITOR set to something usable you will get and editor with instructions something like: ``` pic

RE: [PROPOSAL] Closing PRs older than 1 month and without activity

Remi, Would it be possible to give the closed PRs which are not merged due to inactivity or unfinished code-work a label? So the can be recognized when they are closed? Best regards, Boris Schrijver TEL: +31633784542 MAIL: bo...@pcextreme.nl > > On August 17, 2015 at 5:49 PM Somesh Naidu

RE: [PROPOSAL] Closing PRs older than 1 month and without activity

+1 Regards, Somesh -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: Monday, August 17, 2015 10:26 AM To: dev@cloudstack.apache.org Subject: [PROPOSAL] Closing PRs older than 1 month and without activity Hi all, There are several PRs that are quite old.

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131875279 Holly S... I am so sorry, when I got that screen with the text I was not even reading it, I thought it was just the comments on each commit, and that gi

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131877441 np, but the commit message is now not very clear and it seems you did not really squash them. There are still two commits in this PR. --- If your project is se

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

+1 Sounds reasonable On Mon, Aug 17, 2015 at 8:25 AM, Remi Bergsma wrote: > Hi all, > > There are several PRs that are quite old. They haven't been updated by > their author for over a month and there was no response to comments made. > > As a RM, I want to maintain an as-short-as-possible list

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131881064 Fixed the commit title and message. Is it appearing as two (2) commits for you? Here it shows as just one. --- If your project is set up for

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-131881916 @rafaelweingartner it seems fine now, let's await checks and merge --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

+1 for auto closing. I also agree with Boris that we need to distinguish discarded vs. Merged prs. On Mon, Aug 17, 2015 at 21:51 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: +1 Sounds reasonable On Mon, Aug 17, 2015 at 8:25 AM, Remi Bergsma > wrote: > Hi all, > > There are several

Build failed in Jenkins: build-master-slowbuild #2082

See Changes: [Boris Schrijver] Refactored NicProfile.java for readability. -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] >>> f

[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-131899397 Seems this PR breaks the addition of a public key on the Web UI. The reponse is : "Public key is invalid" (works successfully with Cloudmonkey

Re: Build failed in Jenkins: build-master-slowbuild #2082

Hi all, The error occurring is because the methods which are called had been renamed. I've fixed this in a new PR: https://github.com/apache/cloudstack/pull/707/. Fix: https://github.com/borisroman/cloudstack/blob/0e518f004fdd9eaa0b39be1e3c4eb391ea07e7cc/plugins/network-elements/nuage-vsp/src/com

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...

Not sure if that warrants a revert. It seems like something that should be fixed in the UI On Mon, Aug 17, 2015 at 7:34 PM, milamberspace wrote: > Github user milamberspace commented on the pull request: > > https://github.com/apache/cloudstack/pull/615#issuecomment-131899397 > > > Seems

Re: Build failed in Jenkins: build-master-slowbuild #2082

No worry Boris, travis only tests the core of the system. We remain responsible for apt reaction to failures. Also the pull-analysis build should give more info. On Mon, Aug 17, 2015 at 7:34 PM, Boris Schrijver wrote: > Hi all, > > The error occurring is because the methods which are called had

[GitHub] cloudstack pull request: Fixed typo

GitHub user radu-stefanache opened a pull request: https://github.com/apache/cloudstack/pull/708 Fixed typo Spotted this using Elasticsearch . You can merge this pull request into a Git repository by running: $ git pull https://github.com/radu-stefanache/cloudstack master Alte

[GitHub] cloudstack pull request: Fixed typo

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/708#issuecomment-131907084 Good catch! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-131911894 I wouldn't revert the commit either, we can probably fix this in the UI. @borisroman could you look at this maybe with @kevindierkx ? --- If your project is se

[GitHub] cloudstack pull request: Fixed typo

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/708#issuecomment-131912035 @radu-stefanache Thanks! Could you please remove the merge commit? You can do so by squashing them together and force push to your branch. The PR will then get u

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

Hi Boris, I like the idea, but this is a bit harder than it seems. We only have read-only access to GitHub, because it is a mirror of the actual git repo at Apache. That’s why we cannot simply close PRs etc. For the same reason, I cannot create labels or assign them. Not even for the PRs I subm

Re: [PROPOSAL] Closing PRs older than 1 month and without activity

Hi Rajani, If we truly “merge” PRs, which I think we should do (instead of applying a patch) then those will be in state “Merged” (purple) versus “Closed” (red). Regards, Remi On 17 Aug 2015, at 18:56, Rajani Karuturi mailto:raj...@apache.org>> wrote: +1 for auto closing. I also agree with B

Usage Records are still generating even VM removed.

Hi All, The usage records are still generating even if the vm is removed from cloudstack. The actual scenario is: The xenserver host went to alert state and the vms in it are not accessible. we have removed the vms from backend by updating vm_instance,volume table. can any one help me what is the

Build failed in Jenkins: build-master-slowbuild #2083

See -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-s

[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/709 Removed double encoding of Public Key from JS. See Cloudstack issue CLOUDSTACK-8742 & CLOUDSTACK-8649 for information. You can merge this pull request into a Git repository by running: $

[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-131960910 Looked into it. See PR #709 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-131968267 It was double encoded because encodeURIComponent() and jQuery.param() encoded it. The latter does this automatically because the request is of type post and the o

Build failed in Jenkins: build-master-slowbuild #2084

See -- [...truncated 25929 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-s

Build failed in Jenkins: build-master-slowbuild #2085

See -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-s

Re: Urgent Question at VPC router:

Have you taken a look at the logs on the VR? From: srinivas niddapu Sent: Sunday, August 16, 2015 9:21 PM To: us...@cloudstack.apache.org; dev@cloudstack.apache.org Subject: RE: Urgent Question at VPC router: Thanks for the information Simon, We do add m

[GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132067886 @cristofolini @DaanHoogland Are these unit tests adding any value? What type of value are they adding here? To me these seems to be burden on maintainer or develo

[GitHub] cloudstack pull request: This branch implements the CSV and native...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-132072709 @DaanHoogland Updated the code with review comments. Regarding unit tests I am identifying modules for which unit tests can be written. But be aware that

[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132072731 @borisroman does backend do double decoding? there was a patch for cloudmonkey regarding this: https://github.com/apache/cloudstack-cloudmonkey/commit/6bd92395592c1

[GitHub] cloudstack pull request: Fixed typo

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/708#issuecomment-132072808 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] cloudstack pull request: Removed double encoding of Public Key fro...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/709#issuecomment-132072846 so, the double encoding and double decoding lived happily together :) Now, jquery does the encoding from UI and decoding is done in ApiServlet.processRequestInC

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user devdeep commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-132072881 @DaanHoogland added some additional tests to validate the templates get scheduled for seeding. --- If your project is set up for it, you can reply to this email and

Build failed in Jenkins: build-master-slowbuild #2086

See -- [...truncated 25932 lines...] [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] >>> findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ cloud-plugin-network-s

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132073136 Updated code to use local.storage.path config instead of hard-coded /var/lib/libvirt/images/. Local Storage pool is also created using same config. Removed /usr

[GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/577#issuecomment-132073238 @remibergsma I've update the PR. There is still one issue open regarding the usage of /tmp --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/705#issuecomment-132076968 looks there are compilation errors in nuage plugin. jenkins builds failed http://jenkins.buildacloud.org/job/build-master-noredist/4531/consoleText http://j

Re: Usage Records are still generating even VM removed.

update the usage_event table with VM.DESTROY event for this vm. I would say create a vm, destroy it and observer the entries in usage_event table. create a similar entry for the manually destroyed vm. ~Rajani On Tue, Aug 18, 2015 at 12:12 AM, raja sekhar wrote: > Hi All, > > The usage records

[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/615#issuecomment-132091017 The PR #709 don't fix the issue for me. I can't add a SSH key pair without revert the #615. --- If your project is set up for it, you can reply to this e