[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-13 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/679#discussion_r36946797 --- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java --- @@ -125,6 +130,15 @@ public SecurityGroupResponse newSecurityGroupResponse(Se

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130564758 LGTM if you fix the brackets in the if-statement --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Quota master

2015-08-13 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/689 Quota master This pull request is for quota service implementation, divided into following two commits: 1. Quota server side implementation a. Quota Framework plugin contain

[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

2015-08-13 Thread pritisarap12
Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/668#issuecomment-130566681 Updated testpath to get single commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-13 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36949815 --- Diff: client/pom.xml --- @@ -478,6 +478,12 @@ + --- End

[GitHub] cloudstack pull request: CLOUDSTACK-8710: Fixed applying iptables ...

2015-08-13 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/690 CLOUDSTACK-8710: Fixed applying iptables rules for s2s vpn @remibergsma @wilderrodrigues Moved applying iptables rules apply after vpn configuration so that vpn specific rules also get app

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-13 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36952117 --- Diff: client/pom.xml --- @@ -478,6 +478,12 @@ + --- End di

[GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

2015-08-13 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/683#issuecomment-130587552 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-13 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/646#issuecomment-130588174 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: CLOUDSTACK-8710: Fixed applying iptables ...

2015-08-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/690#issuecomment-130593053 Hi @jayapalu I also worked on this, and but even with the firewall rules applied, the functionality still doesn't work because some rules are missing. So, this m

[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

2015-08-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/668#issuecomment-130598324 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

2015-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130600502 @borisroman Could you please squash the commits into 1 (or maybe 2 if you want the tests separate). --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-13 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/679#discussion_r36958780 --- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java --- @@ -125,6 +130,16 @@ public SecurityGroupResponse newSecurityGroupResp

[GitHub] cloudstack pull request: CLOUDSTACK-8710: Fixed applying iptables ...

2015-08-13 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/690#issuecomment-130602329 @remibergsma I thought you are only looking at the rules issue. You can look at the other issues in s2s vpn. You might have observed it but making it to yo

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-13 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130602430 @borisroman I have provided a code comment. Once you fix that and squash the commits as suggested by @remibergsma then its a LGTM from me. Thanks for the unit te

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/646 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Database consistency check

2015-08-13 Thread cs user
This would be fantastic if it can be written. On Mon, Aug 10, 2015 at 1:17 PM, Daan Hoogland wrote: > Norbert, I haven't begun to think about it. including dev@ to gather > ideas. > The db structure is based on updates since 4.0. A new install will be a 4.0 > DB which will then undergo a series

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130612388 @wido @remibergsma @koushik-das Folowed up on lastest comments by Remi and Koushik. --- If your project is set up for it, you can reply to this email and have yo

RE: Remi Bergsma joins the PMC

2015-08-13 Thread Paul Angus
Congratulations Remi! Regards, Paul Angus VP Technology/Cloud Architect D: +44 20 3468 5163 |S: +44 20 3603 0540 | M: +44 7711 418 784 | T: @CloudyAngus paul.an...@shapeblue.com -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: 11 August 2015 21:37 To: Su

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/679 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...

2015-08-13 Thread cloudsadhu
GitHub user cloudsadhu opened a pull request: https://github.com/apache/cloudstack/pull/691 CLOUDSTACK-8731-checking usage event for delete volume @summary: Test volume delete event generation in error state condition ... === TestName: test_volume_delete_event_errorState | Status :

Re: Release EC2stack 1.0.0

2015-08-13 Thread sebgoa
On Aug 13, 2015, at 12:00 AM, Ian Duffy wrote: > Hey Sebastien, > > Thank you for doing this. > > If there's any small jobs I can help out let me know, I'm allowed to work > on this type of stuff again once Friday the 14th passes. > we are missing a few badges in the readme. I think we had c

[GitHub] cloudstack pull request: [CLOUDSTACK-8427] Add missing localizatio...

2015-08-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/686#issuecomment-130646010 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-130647516 travis timeout LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Quota master

2015-08-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-130652414 one big chunk of work Abhi, I have skimmed it and the structure looks good. I must have missed some minor issues in these 7000+ lines of code, though. One ma

[GitHub] cloudstack pull request: CLOUDSTACK-8710: Fixed applying iptables ...

2015-08-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/690#issuecomment-130654437 @jayapalu happy you're helping out! If you found out more stuff already, feel free to post. Thanks! :-) --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

2015-08-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-130656396 @borisroman Please squash the commits here as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

Build failed in Jenkins: build-master-slowbuild #2045

2015-08-13 Thread jenkins
See -- [...truncated 27471 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

2015-08-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/680#issuecomment-130659980 @remibergsma Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request: Quota master

2015-08-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-130660478 @DaanHoogland I think the aim here is to bring the work out for everyone to review early on, Abhi tells me he's already working on unit and marvin tests. --- If yo

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-13 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/692 CLOUDSTACK-8725 RVR functionality is broken in case of isolated netwo… CLOUDSTACK-8725 RVR functionality is broken in case of isolated networks, conntrackd fails to start. You can mer

[GitHub] cloudstack pull request: Quota master

2015-08-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-130661556 @bhaisaab well it looks promising. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-13 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/692#discussion_r36970870 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py --- @@ -96,7 +96,7 @@ def _redundant_on(self): d = s.rep

Re: Release EC2stack 1.0.0

2015-08-13 Thread Carlos Reategui
> Has anyone used it lately with 4.5.x releases ? > Yes and it seems to work ok with a recent version (1.7.42) of the aws cli [1] once you tell it to use V2 signature. I have not tried it with the ec2 cli tools [2]. > > feedback welcome, otherwise I will just cut a release and send a vote > thr

RE: [Proposal] Replacing Openswan ipsec with Strongswan ipsec

2015-08-13 Thread Manasa Veloori
Hi , Planning to test this feature. Please find the test plan at : https://cwiki.apache.org/confluence/display/CLOUDSTACK/TestPlan+for+Replacing+openSwan+with+StrongSwan Review the test plan and provide your comments. Thanks, Manasa -Original Message- From: Jayapal Reddy Uradi [mailto

Build failed in Jenkins: build-master-slowbuild #2046

2015-08-13 Thread jenkins
See -- [...truncated 27471 lines...] [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] >>> findbugs-maven-plugi

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

2015-08-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/630#issuecomment-130696363 @mike-tutkowski LGTM if LGTY --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: Coverity regressions per 10 aug 2015

2015-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[SHARE] VM migrations failing with Ubuntu 14.04.3

2015-08-13 Thread Rohit Yadav
Hi all, I’ve been testing a bug on KVM which involves VM migration, and in that process I found that VM migrations failed in my environment twice even with clean setups of Ubuntu 14.04.3 (lastest and updated packages) based KVM hosts against CloudStack 4.5.2-SNAPSHOT (latest 4.5). I wanted to

Re: Release EC2stack 1.0.0

2015-08-13 Thread Ian Duffy
No problem. I'll look into those. I'd imagine Darren had them on a personal account or something. Any idea if we have an asf account on the related sites? If so Will need to open infra tickets to get them enabled for the ec2stack GitHub mirror. On Thursday, August 13, 2015, sebgoa wrote: > > On

Re: Database consistency check

2015-08-13 Thread Daan Hoogland
enter a feature request in jira and start poking. (i might join in) On Thu, Aug 13, 2015 at 12:07 PM, cs user wrote: > This would be fantastic if it can be written. > > On Mon, Aug 10, 2015 at 1:17 PM, Daan Hoogland > wrote: > > > Norbert, I haven't begun to think about it. including dev@ to ga

[PROMOTE] CloudStack Silicon Valley User Group Meetup - September 10th, 2015

2015-08-13 Thread Karen Vuong
Hi all, If you’re going to be in the Silicon Valley on September 10th - then join us! The next CloudStack Silicon Valley Meetup has been scheduled for Thursday, September 10th at Nuage Networks in Mountain View, CA. We have a packed agenda with talks around CloudStack, SDN, NFV and Virtualizatio

[GitHub] cloudstack pull request: CLOUDSTACK-8710: Fixed applying iptables ...

2015-08-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/690#issuecomment-130798498 Forgot to update this.. tested it and the rules are applied OK now. LGTM. I will add more firewall rules so the feature will work again. Let's also look

Re: Release EC2stack 1.0.0

2015-08-13 Thread Ian Duffy
> Yes and it seems to work ok with a recent version (1.7.42) of the aws cli [1] once you tell it to use V2 signature. I have not tried it with the ec2 cli tools [2]. Awesome! good spot. We(Myself and Darren) noticed it stopped working with the latest awscli due to changes in boto, our workaround

Re: Release EC2stack 1.0.0

2015-08-13 Thread Ian Duffy
@seboga opened a ticket for the coveralls stuff https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-10123 I believe the pypi submission doesn't like the readme as an md and it will render it weirdly on pypi (open to correction on this). I've added you on the pypi entry so you should

Re: Release EC2stack 1.0.0

2015-08-13 Thread Carlos Reategui
Hi Ian, PrivateDNSName *to me* would be something that one would be able to > resolve... if displayname.whatever-set-domain.tld is resolvable at some > point in the system then this change seems sane. Otherwise use a tag. > I suggested Name because that is what the hostname gets set to. You can a

Build failed in Jenkins: build-systemvm-master #592

2015-08-13 Thread jenkins
See Changes: [Daan Hoogland] coverity 1315774: improvement of code to negate false positive [Daan Hoogland] coverity 1315775: proper getting of networkLabel [mike.tutkowski] Fixing a FindBugs issue related to PR 674 [priti.

Re: [SHARE] VM migrations failing with Ubuntu 14.04.3

2015-08-13 Thread Milamber
Hello Rohit, On physical environment or a virtual environment (cloudstack under KVM?) ? I will try to setup the same env here to validate or not the issue. Milamber On 13/08/2015 13:06, Rohit Yadav wrote: Hi all, I’ve been testing a bug on KVM which involves VM migration, and in that proces

Re: Database consistency check

2015-08-13 Thread Rajani Karuturi
I remember seeing a PR for it long time ago. https://github.com/apache/cloudstack/pull/188 ~Rajani On Thu, Aug 13, 2015 at 6:33 PM, Daan Hoogland wrote: > enter a feature request in jira and start poking. (i might join in) > > On Thu, Aug 13, 2015 at 12:07 PM, cs user wrote: > > > This would b

[GitHub] cloudstack pull request: CLOUDSTACK-8725 RVR functionality is brok...

2015-08-13 Thread bvbharatk
Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/692#discussion_r37048693 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py --- @@ -96,7 +96,7 @@ def _redundant_on(self): d = s.replac

Re: [SHARE] VM migrations failing with Ubuntu 14.04.3

2015-08-13 Thread Rohit Yadav
On 14-Aug-2015, at 4:13 am, Milamber mailto:milam...@apache.org>> wrote: On physical environment or a virtual environment (cloudstack under KVM?) ? In my case I was running Ubuntu 14.04.3 KVM hosts as VMs (nested virtualization), in one test on top of a Ubuntu 15.04 host and in another on top

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

2015-08-13 Thread Sanjeev N
LGTM!! On Tue, Aug 11, 2015 at 4:56 PM, pritisarap12 wrote: > Github user pritisarap12 commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/675#discussion_r36734678 > > --- Diff: test/integration/testpaths/testpath_usage.py --- > @@ -2879,6 +2882,60

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-13 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-130971943 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-130972448 ![screen shot 2015-08-14 at 11 04 19 am](https://cloud.githubusercontent.com/assets/95203/9267876/3cadb766-4274-11e5-8b23-2c1dd49a1bc9.png) Discussed the PR

Build failed in Jenkins: build-4.5 #507

2015-08-13 Thread jenkins
See Changes: [Rohit Yadav] CLOUDSTACK-8566: Strips the username and password credentials from host details [Rohit Yadav] CLOUDSTACK-8613, CLOUDSTACK-6301: Dump KVM domain XML with secure flag --

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-08-13 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-130973969 Removed the MigrateCompleteCommand as per review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

Build failed in Jenkins: build-master-noredist #4520

2015-08-13 Thread jenkins
See Changes: [Rohit Yadav] CLOUDSTACK-8566: Strips the username and password credentials from host details [Rohit Yadav] CLOUDSTACK-8613, CLOUDSTACK-6301: Dump KVM domain XML with secure flag -

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/650#issuecomment-130988339 Added a unit test for SAML2AuthManager, will merge after Travis goes green --- If your project is set up for it, you can reply to this email and have your reply app

Build failed in Jenkins: build-master-jdk18 #273

2015-08-13 Thread jenkins
See Changes: [Rohit Yadav] CLOUDSTACK-8566: Strips the username and password credentials from host details [Rohit Yadav] CLOUDSTACK-8613, CLOUDSTACK-6301: Dump KVM domain XML with secure flag -

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2015-08-13 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-130996684 Unit test which is failing is testing KVM code and is not related to any changes in this file --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-13 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/650 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i