Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r36952117
--- Diff: client/pom.xml ---
@@ -478,6 +478,12 @@
<copy
todir="${basedir}/target/generated-webapp/WEB-INF/classes/scripts">
<fileset dir="${basedir}/../scripts"/>
</copy>
+ <copy
todir="${basedir}/target/generated-webapp/WEB-INF/classes/systemvm/js">
--- End diff --
Its good that it does not say that UT are meant to test "corner" cases or
"some uncertainity", as per your earlier understanding. It talks about TDD, in
which UT are not meant to be written post the code, its good to follow TDD if
we can write tests before the code. But if we missed it, and If we feel there
is a value add in writing some tests, which can benefit others and helps
testing the code in long run, its appreciated to add few, there is no harm. We
could see many commits coming are having UT recently. Some even made sure to
get near 100% coverage for their code. We know its not a new distinct module,
its up to you and whatever the community decides!!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
