Re: [GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

2015-08-10 Thread Sanjeev N
LGTM!! On Mon, Aug 10, 2015 at 11:34 AM, pritisarap12 wrote: > GitHub user pritisarap12 opened a pull request: > > https://github.com/apache/cloudstack/pull/668 > > > CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath > > -Adding "cls.hypervisor = cls.testClient.ge

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129334661 @koushik-das Check. If you fix the commits, I'll LGTM and merge. Let me know if you need help. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...

2015-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/662 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129335984 @remibergsma I have fixed the commits, please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/658#issuecomment-129336998 @manuiiit Thanks! Final request: please squash the 3 commits you have now into one. After that, force push to this branch. Once done, I'll LGTM and merge. --- I

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/547#issuecomment-129337423 @mike-tutkowski Thanks! It seems the testing / verification is still to do and that is the work. Merging itself can be done with a one-liner. Are you able to ver

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/669 Made the adding new keyboard language support easier This branch has implemented following improvements in console proxy keyboard language support 1) ajaxviewer.js and ajaxkeys.js ar

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36608900 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59 @@ +/*

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36609019 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1279,6 +1285,27 @@ private static DiskTO getIs

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36609071 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1279,6 +1285,27 @@ private static DiskTO getIs

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36609212 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59 @@ +/*

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36609278 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59 @@ +/*

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36609308 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -595,6 +597,25 @@ private PlugNicA

Re: Revisit Process for creating Blocker bugs

2015-08-10 Thread Sebastien Goasguen
> On Aug 6, 2015, at 7:35 AM, Raja Pullela wrote: > > Looks like there are few of us who differ with the current > process/restriction. > Just to close this thread - there are already guidelines that exist currently > and we should continue to adopt or follow those.Let the Release Manage

Re: [DISCUSS][PROPOSAL] cleanup repo

2015-08-10 Thread Sebastien Goasguen
I’d just be a bit careful here. There might be some tale branches that still have useful info. like the ‘docker’ branch. it might just be 100 LOC that are interesting but yet, that’s where they are. > On Aug 3, 2015, at 6:06 PM, Remi Bergsma wrote: > > +1 > >> On 02 Aug 2015, at 15:46, Daan H

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129365283 Travis failure is due to timeout. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Revisit Process for creating Blocker bugs

2015-08-10 Thread Sebastien Goasguen
> On Aug 4, 2015, at 6:48 PM, Ramanath Katru wrote: > > Daan, > > I beg to differ. This is very much a product issue. We cannot knowingly > release with an existing/working functionality broken. Especially if it is > one of the features that users expect to be there. Remote Access VPN is an

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611014 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1279,6 +1285,27 @@ private static DiskTO get

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611046 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -1279,6 +1285,27 @@ private static DiskTO get

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611140 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -595,6 +597,25 @@ private PlugNi

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611175 --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java --- @@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands cmds

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611238 --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java --- @@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands cmds

Re: Ec2stack not working with current aws cli

2015-08-10 Thread Sebastien Goasguen
since we don’t have docs for ec2stack yet. Can you make a PR that updates the README with this config option… thanks > On Aug 6, 2015, at 3:07 AM, Carlos Reategui wrote: > > BTW I figured out how to force the cli to send v2. It would still be nice > to update Ec2Stack though: > > aws configu

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611296 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59 @@ +/*

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611512 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -595,6 +597,25 @@ private PlugNicA

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611661 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59 @@ +/*

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

2015-08-10 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/158#issuecomment-129368171 -1 Without changes it works fine, because if we don't specify the "enabled" attribute for the zone in the config file, it will enable the zone by default. Even

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129368352 @koushik-das Thanks, glad the merge commit is gone now. Do you want to keep two commits? I'd say squash them together. From the subject line I cannot tell the di

[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/668#issuecomment-129368593 @pritisarap12 Please remove the merge commit and force push again. See PR #656 on how to do this. Thanks! --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36611905 --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java --- @@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands cm

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129371706 @remibergsma Yes the commits can be squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36612331 --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java --- @@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands cm

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36612463 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -595,6 +597,25 @@ private PlugNi

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36612869 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59 @@ +/*

Re: [DISCUSS][PROPOSAL] cleanup repo

2015-08-10 Thread Daan Hoogland
I will, Sebastien. I know that some of this is gems. A lot of it has been merged or really abandoned and superseded by other code. I know you and Pierre-Luc are working on docker so I would definitely inquire with you guys about this branch. On Mon, Aug 10, 2015 at 10:29 AM, Sebastien Goasguen wr

happy birthday dear cloudstack.git

2015-08-10 Thread Daan Hoogland
Ladies and gentleman, At the 11th of August 2010, Manuel Amador made the first commit in our repository. I never met the guy but want to take the occasion to congratulate him and all other contributors with the 5th aniversary of our repository. ​:beer::cake::clappinghands:​ -- Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129374324 @koushik-das Check, please squash and then force push again. After that I'll merge it. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

2015-08-10 Thread kevindierkx
GitHub user kevindierkx opened a pull request: https://github.com/apache/cloudstack/pull/670 Made interface changes related to CLOUDSTACK-8580 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevindierkx/cloudstack CLOUDSTACK-8580

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

2015-08-10 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/635#discussion_r36613344 --- Diff: api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java --- @@ -60,6 +61,15 @@ description =

Re: happy birthday dear cloudstack.git

2015-08-10 Thread Wido den Hollander
Congrats! Great :-) On 10-08-15 11:17, Daan Hoogland wrote: > Ladies and gentleman, > > At the 11th of August 2010, Manuel Amador made the first commit in our > repository. I never met the guy but want to take the occasion to > congratulate him and all other contributors with the 5th aniversary o

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

2015-08-10 Thread sanju1010
GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/671 CLOUDSTACK-8720: Handle corner case in remove nic from vm Please see the bug for more details You can merge this pull request into a Git repository by running: $ git pull https://github.c

[GitHub] cloudstack pull request: Allow VM snapshots and volume snapshots t...

2015-08-10 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/672 Allow VM snapshots and volume snapshots to exist together This branch fixes issues involved in allowing VM snapshots and volume snapshots to exist together. You can merge this pull request i

Re: happy birthday dear cloudstack.git

2015-08-10 Thread Punith S
Wow! happy birthday cloudstack :) On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander wrote: > Congrats! Great :-) > > On 10-08-15 11:17, Daan Hoogland wrote: > > Ladies and gentleman, > > > > At the 11th of August 2010, Manuel Amador made the first commit in our > > repository. I never met the

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

2015-08-10 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/671#issuecomment-129378007 Test to verify remove nic from vm if the nic ip is same as another vm ip in another network ... === TestName: test_29_remove_nic_CS22503 | Status : SUCCESS ===

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

2015-08-10 Thread kevindierkx
Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/670#issuecomment-129381995 Looks like the changes to listCapabilities aren't merged yet. (@borisroman) Ignore this pull-request =D --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: Made interface changes related to CLOUDST...

2015-08-10 Thread kevindierkx
Github user kevindierkx closed the pull request at: https://github.com/apache/cloudstack/pull/670 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: happy birthday dear cloudstack.git

2015-08-10 Thread Sebastien Goasguen
> On Aug 10, 2015, at 11:17 AM, Daan Hoogland wrote: > > Ladies and gentleman, > > At the 11th of August 2010, Manuel Amador made the first commit in our > repository. I never met the guy but want to take the occasion to > congratulate him and all other contributors with the 5th aniversary of o

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129396359 @koushik-das Thank you! LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/656 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

2015-08-10 Thread pavanb018
Github user pavanb018 commented on the pull request: https://github.com/apache/cloudstack/pull/671#issuecomment-129398162 Looks Good to me. Probably remove_nic might return an error if the NIC is not removed , but just wondering if a check is needed in the below step , to val

Cisco ACI SDN

2015-08-10 Thread Erik Weber
Hi devs, Just wondering if anyone is looking at implementing Cisco ACI support in CloudStack? -- Erik

[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

2015-08-10 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/671#issuecomment-129401139 Looks Good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-10 Thread anshul1886
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/673 CLOUDSTACK-8721: Fixed Setting details of VM through API results in removal of all other details except the one passed in API You can merge this pull request into a Git repository by runnin

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129405117 @remibergsma ahum,... LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-10 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-129407249 cloudstack-pull-requests #945 failure is because of some random error in git fetching --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-129407180 @DaanHoogland You already gave your LGTM? See here: https://github.com/apache/cloudstack/pull/656#issuecomment-127529005 --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

2015-08-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-129408998 @devdeep How about testing if the right (number of) threads are being started? Does my comment make any sense? --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

2015-08-10 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/635#discussion_r36620562 --- Diff: api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java --- @@ -60,6 +61,15 @@ description = "

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-10 Thread shwetaag
Github user shwetaag commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/646#discussion_r36620849 --- Diff: test/integration/component/maint/test_escalation_templates.py --- @@ -0,0 +1,394 @@ +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-10 Thread shwetaag
Github user shwetaag commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/646#discussion_r36621050 --- Diff: test/integration/component/maint/test_escalation_templates.py --- @@ -0,0 +1,394 @@ +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-10 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/650#discussion_r36621140 --- Diff: plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java --- @@ -322,21 +306,11 @@ public St

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

2015-08-10 Thread devdeep
Github user devdeep commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-129411154 @DaanHoogland That is what I am looking into; how to get the number of threads that have been started by the executor service. --- If your project is set up for it,

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-10 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/650#discussion_r36621580 --- Diff: plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java --- @@ -322,21 +306,11 @@ publi

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

2015-08-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-129412845 You can mock the call and verify how often it has been called with mockito. --- If your project is set up for it, you can reply to this email and have your repl

acs github branch 4.5 - compiling error

2015-08-10 Thread Tomasz Zięba
Hello, We have problems with compiling 4.5 branch. We think that this problem occurs for last week. Cound someone confirm this ? Step to reproduce: 1. Download source https://github.com/apache/cloudstack/archive/4.5.zip 2. mvn install 3. errror Running rdpclient.MockServerTest Error in mock s

Re: happy birthday dear cloudstack.git

2015-08-10 Thread Rohit Yadav
Fantastic :) On 10-Aug-2015, at 3:07 pm, Punith S mailto:punit...@cloudbyte.com>> wrote: Wow! happy birthday cloudstack :) On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander mailto:w...@widodh.nl>> wrote: Congrats! Great :-) On 10-08-15 11:17, Daan Hoogland wrote: Ladies and gentleman, At

Re: happy birthday dear cloudstack.git

2015-08-10 Thread Remi Bergsma
Awesome! Happy birthday :-) On 10 Aug 2015, at 13:39, Rohit Yadav mailto:rohit.ya...@shapeblue.com>> wrote: Fantastic :) On 10-Aug-2015, at 3:07 pm, Punith S mailto:punit...@cloudbyte.com>> wrote: Wow! happy birthday cloudstack :) On Mon, Aug 10, 2015 at 3:03 PM, Wido den Hollander mailto:w

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

2015-08-10 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-129423682 WRT master/4.6 4.5.2 was assumed frozen. There are other changes in 452to462 sql as well which may/maynot be bug fixes. A separate PR needs to be done for 451to

[GitHub] cloudstack pull request: test case automated for list template pag...

2015-08-10 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/646#issuecomment-129424914 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

Re: Database consistency check

2015-08-10 Thread Daan Hoogland
Norbert, I haven't begun to think about it. including dev@ to gather ideas. The db structure is based on updates since 4.0. A new install will be a 4.0 DB which will then undergo a series of upgrade steps. A validation of the db could be divided in a basic part and an incremental part, maybe. A go

Re: [DISCUSS] Improving API reference pages

2015-08-10 Thread Rajsekhar K
Hi, Dave, Somesh, Thanks for your feedback. Thanks for the help that you promised on this task. Hi, Dave, Thanks for providing the Style Guide for the API Guides and some good pointers on improving the API content. This is helpful. Hi, Somesh, Thanks for your willingness to help with the conte

New Defects reported by Coverity Scan for cloudstack

2015-08-10 Thread scan-admin
Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan. 17 new defect(s) introduced to cloudstack found with Coverity Scan. 55 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defec

RE: happy birthday dear cloudstack.git

2015-08-10 Thread Somesh Naidu
Happy Birthday Cloudstack :) @Daan - IIRC, Manuel moved the source code from sccs to git so all the commits, since 2008 until this date, reflect his name :) Regards, Somesh -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: Monday, August 10, 2015 7:48 AM

RE: Revisit Process for creating Blocker bugs

2015-08-10 Thread Somesh Naidu
> I did not see (or understand) a major change proposed or needed in this > thread. The primary topic of discussion is categorization of a defect as Blocker, that is, how to qualify a defect as Blocker. The discussion scope widened and included process to raise an issue as "Blocker". The issue

Remi Bergsma joins the PMC

2015-08-10 Thread Daan Hoogland
LS, Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say that he accepted. Please join me in congratulating Remi. ​regards,​ -- Daan

Re: Remi Bergsma joins the PMC

2015-08-10 Thread Todd Pigram
Congrats!! On Monday, August 10, 2015, Daan Hoogland wrote: > LS, > > Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say > that he accepted. Please join me in congratulating Remi. > > ​regards,​ > -- > Daan > -- Todd Pigram http://about.me/ToddPigram www.linkedin.co

Re: Remi Bergsma joins the PMC

2015-08-10 Thread Simon Weller
Congratulations Remi! From: Daan Hoogland Sent: Monday, August 10, 2015 12:08 PM To: dev Subject: Remi Bergsma joins the PMC LS, Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say that he accepted. Please join me in congratulati

Re: Remi Bergsma joins the PMC

2015-08-10 Thread Milamber
Congrats Remi! On 10/08/2015 18:08, Daan Hoogland wrote: LS, Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say that he accepted. Please join me in congratulating Remi. ​regards,​

Re: Remi Bergsma joins the PMC

2015-08-10 Thread Ahmad Emneina
Congrats Remi! Well deserved. Ahmad E > On Aug 10, 2015, at 10:08 AM, Daan Hoogland wrote: > > LS, > > Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say > that he accepted. Please join me in congratulating Remi. > > ​regards,​ > -- > Daan

Re: Remi Bergsma joins the PMC

2015-08-10 Thread Mike Tutkowski
Congratulations, Remi! On Mon, Aug 10, 2015 at 11:08 AM, Daan Hoogland wrote: > LS, > > Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say > that he accepted. Please join me in congratulating Remi. > > ​regards,​ > -- > Daan > -- *Mike Tutkowski* *Senior CloudStack D

Re: Anyone wants to take over these orphaned PRs?

2015-08-10 Thread Mike Tutkowski
I should be able to test it. Talk to you soon, Mike On Sun, Aug 9, 2015 at 10:40 PM, Remi Bergsma wrote: > Hi Mike, > > Thanks! It seems the testing / verification is still to do and that is the > work. Merging itself can be done with a one-liner. > > Are you able to verify the fix in your lab?

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

2015-08-10 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/158#issuecomment-129546119 Folks, i am closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

2015-08-10 Thread srikanteswartalluri
Github user srikanteswartalluri closed the pull request at: https://github.com/apache/cloudstack/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

Re: Remi Bergsma joins the PMC

2015-08-10 Thread Erik Weber
On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland wrote: > LS, > > Today the PMC has invited Remi Bergsma to join its ranks. I am happy to say > that he accepted. Please join me in congratulating Remi. > > Congratulations Remi :-) -- Erik

Re: Anyone wants to take over these orphaned PRs?

2015-08-10 Thread Remi Bergsma
Hi Suresh, Thanks for picking this up! Some PRs got feedback, it’d be great if that could be addressed. In a perfect world, changes are submitted with tests. I see many reviewers ask for them, so adding them definitely helps in getting LGTMs. Not 100% sure what you mean by “Can we take up the

RE: Remi Bergsma joins the PMC

2015-08-10 Thread Somesh Naidu
Congratulations Remi! Regards, Somesh -Original Message- From: Erik Weber [mailto:terbol...@gmail.com] Sent: Monday, August 10, 2015 2:13 PM To: dev Subject: Re: Remi Bergsma joins the PMC On Mon, Aug 10, 2015 at 7:08 PM, Daan Hoogland wrote: > LS, > > Today the PMC has invited Remi

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-129572848 @anshul1886 I want to test this but haven't used the 'details' feature before. In what format am I supposed to send the key/value pairs? If you have a CloudMonke

RE: Remi Bergsma joins the PMC

2015-08-10 Thread Boris Schrijver
Congrats Remi! Best regards, Boris Schrijver TEL: +31633784542 MAIL: bo...@pcextreme.nl > > On August 10, 2015 at 8:57 PM Somesh Naidu > wrote: > > > Congratulations Remi! > > Regards, > Somesh > > > -Original Message- > From: Erik Weber [mailto:terbol...@

Re: Remi Bergsma joins the PMC

2015-08-10 Thread Ian Rae
Fantastic, well deserved Remi! On Mon, Aug 10, 2015 at 4:10 PM, Boris Schrijver wrote: > Congrats Remi! > > Best regards, > > Boris Schrijver > > TEL: +31633784542 > MAIL: bo...@pcextreme.nl > > > > > On August 10, 2015 at 8:57 PM Somesh Naidu > > wrote: > > > > > > Congratulations Remi

Re: Ec2stack not working with current aws cli

2015-08-10 Thread Carlos Reátegui
> > Can you make a PR that updates the README with this config option… Done. > > thanks > >> On Aug 6, 2015, at 3:07 AM, Carlos Reategui wrote: >> >> BTW I figured out how to force the cli to send v2. It would still be nice >> to update Ec2Stack though: >> >> aws configure set profile..

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-10 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/674 getUsedBytes should query the SolidFire cluster to acquire the size o… …f the given volume if there is no volume_details info for that volume (and then create a volume_details row for

Anyone able to review PR 674 (it should be quick to do)?

2015-08-10 Thread Mike Tutkowski
Hi, I just opened the following PR: https://github.com/apache/cloudstack/pull/674 This only impacts the SolidFire storage plug-in. Anyone able to spend a few minutes reviewing it for me? Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com

Re: Revisit Process for creating Blocker bugs

2015-08-10 Thread Mike Tutkowski
"3. In case the reporter feels the defect qualifies as a Blocker, they should raise it as Blocker and create a discussion/voting thread on the ML for the same." This is what I always do these days and I think it makes a lot of sense: Go ahead and mark the bug as a Blocker, but then send out an obv

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Anyone wants to take over these orphaned PRs?

2015-08-10 Thread Mike Tutkowski
I went ahead and tested, then checked in PR 547: https://github.com/apache/cloudstack/pull/547/files I also resolved and closed the JIRA ticket for it: https://issues.apache.org/jira/browse/CLOUDSTACK-8601 On Mon, Aug 10, 2015 at 11:43 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote:

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36704745 --- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java --- @@ -1425,19 +1423,39 @@ public boolean finalizeCommandsOnStart(Commands cmds

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36705033 --- Diff: systemvm/js/ajaxviewer.js --- @@ -184,7 +205,7 @@ KeyboardMapper.prototype = { if(eventType == AjaxViewer.KEY_UP && (cod

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36705202 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -595,6 +597,25 @@ private PlugNicA

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36705320 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59 @@ +/*

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2015-08-10 Thread sedukull
Github user sedukull commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r36705867 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java --- @@ -0,0 +1,59 @@ +/*

  1   2   >