Re: Build failed in Jenkins: cloudstack-rat-master #6740

in the top level pom.xml On Tue, Aug 4, 2015 at 4:28 AM, Pierre-Luc Dion wrote: > Hi Daan, > > My fault, I've moved the file, where do I change the path for this error? > > > Le lundi 3 août 2015, Daan Hoogland a écrit : > >> Pierre-Luc, Any idea about this failure. I got it on a commit of mine

[GitHub] cloudstack pull request: Added missed esp policy

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/655#issuecomment-127503187 Thanks, @jayapalu In order to give a LGTM, I checked the way it was used with the ipsectunnel.sh script. Indeed, it should be esp_policy instead of

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/656 CLOUDSTACK-8704: Schedule restart of router VMs ahead of user VMs as … …part of HA VRs are scheduled for HA ahead of user VMs. Refer to the bug for more details. You ca

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36166324 --- Diff: utils/src/com/cloud/utils/AutoCloseableUtil.java --- @@ -0,0 +1,20 @@ +package com.cloud.utils; --- End diff -- License? -

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36166742 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/SnapshotDescriptor.java --- @@ -166,12 +168,7 @@ public void removeDiskReferenceFromSnapshot(

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36167090 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/SnapshotDescriptor.java --- @@ -166,12 +168,7 @@ public void removeDiskReferenceFromSnapshot

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/656#discussion_r36167770 --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java --- @@ -261,25 +264,21 @@ public void scheduleRestartForVmsOnHost(final HostVO hos

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/656#discussion_r36168074 --- Diff: server/test/com/cloud/ha/HighAvailabilityManagerImplTest.java --- @@ -113,12 +110,18 @@ public void setup() throws IllegalArgumentE

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/656#issuecomment-127529005 code LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/656#discussion_r36168376 --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java --- @@ -261,25 +264,21 @@ public void scheduleRestartForVmsOnHost(final HostVO host

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/653#issuecomment-12753 great. thanks for the update @mike-tutkowski. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/653#issuecomment-127532378 Changes LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Added missed esp policy

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/655#issuecomment-127534445 Removed convert_sec_to_h() on esp_policy. @wilderrodrigues Please review this commit also --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Only admin or owner of the template can c...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/648#discussion_r36170620 --- Diff: server/src/com/cloud/template/TemplateManagerImpl.java --- @@ -1354,6 +1354,10 @@ public boolean updateTemplateOrIsoPermissions(BaseUpdateTe

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/656#discussion_r36170828 --- Diff: server/test/com/cloud/ha/HighAvailabilityManagerImplTest.java --- @@ -113,12 +110,18 @@ public void setup() throws IllegalArgumentEx

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/657 CLOUDSTACK-8696: Create Region fails with exception 'id' in the region table should not be an autoincrement unlike other tables. This is because, region ids must be in sync across installs a

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-127548502 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: [WIP] Cloudstack 8656: do away with more ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36173727 --- Diff: utils/src/com/cloud/utils/AutoCloseableUtil.java --- @@ -0,0 +1,20 @@ +package com.cloud.utils; --- End diff -- thanks will

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-127555462 @karuturi @bhaisaab this must be fixed *before* 4.5.2 so it shouldn't be in the 452to460 file. If we put it there we are saying the bug will be in an unreleased

[GitHub] cloudstack pull request: CLOUDSTACK-8696: Create Region fails with...

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/657#issuecomment-127560212 @karuturi This issue exists in releases > 4.5.0 Shouldn't this be fixed in 4.5.0, 4.5.1 and merged forward as per the new release process? Or is the new

RE: Revisit Process for creating Blocker bugs

While we can say if a bug doesn’t effect "majority" of current users, we can go ahead and release, but we should also look at a product perspective not just release perspective. There are some features that are important for cloudstack as a product and these cannot be broken in a release. If we

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/651#issuecomment-127569273 Reviewed the code. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

Re: Revisit Process for creating Blocker bugs

Ram, This is a marketing issue, not a release issue. making a release or marketing it to the general public are two different things. Daan On Tue, Aug 4, 2015 at 12:41 PM, Ramanath Katru wrote: > While we can say if a bug doesn’t effect "majority" of current users, we can > go ahead and releas

[GitHub] cloudstack pull request: CLOUDSTACK-8703: Fixed issue when listing...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/651 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request:

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/commit/7b47c49bb060df431bc2ea67403e19cc322befe0#commitcomment-12514325 nice git comment ;) @remibergsma --- If your project is set up for it, you can reply to this email and have your reply

Build failed in Jenkins: simulator-4.5-singlerun #258

See -- Started by upstream project "build-4.5-simulator" build number 313 originally caused by: Started by upstream project "build-4.5" build number 505 originally caused by: Started by an

RE: Revisit Process for creating Blocker bugs

Daan, I beg to differ. This is very much a product issue. We cannot knowingly release with an existing/working functionality broken. Especially if it is one of the features that users expect to be there. Remote Access VPN is an example. Right now this functionality is broken. Ram Katru -O

Re: Revisit Process for creating Blocker bugs

Yes we can if there is a group of users that don't use it but are in dire need far another feature. We just have to document and market it properly On Tue, Aug 4, 2015 at 6:48 PM, Ramanath Katru wrote: > Daan, > > I beg to differ. This is very much a product issue. We cannot knowingly > release

RE: Revisit Process for creating Blocker bugs

Wow. I think we need a consensus here. When a feature needs to be added, we go through proposals and a healthy discussion on whether the feature can be added or not. We need to do the same if an important feature support is to be removed. It cannot be a call to be made at the time of release and

RE: Revisit Process for creating Blocker bugs

+1 I agree with Ram. -Original Message- From: Ramanath Katru [mailto:ramanath.ka...@citrix.com] Sent: Wednesday, August 5, 2015 9:41 AM To: dev@cloudstack.apache.org Subject: RE: Revisit Process for creating Blocker bugs Wow. I think we need a consensus here. When a feature needs to be a

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

Github user devdeep commented on the pull request: https://github.com/apache/cloudstack/pull/635#issuecomment-127850003 @DaanHoogland Added unit tests for prepare template functionality too. Can you take a look. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: Added missed esp policy

Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/655#issuecomment-127855771 @jayapalu LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

Re: Revisit Process for creating Blocker bugs

If there is a group of users in dire need for a specific feature they can always take the code and use it. No need to wait for an official release. Official release should adhere to quality guidelines (at least in terms of any reported regressions) even if it means release getting delayed. On

Re: [DISCUSS] 4.5.2 bugfix sprint

Hi Rohit, Any update on the release timelines for 4.5.2? I think based on the current upgrade path, we have to do 4.5.2 before 4.6.0. Else upgrade path needs to changed. Thoughts? ~Rajani On Fri, Jul 3, 2015 at 1:00 AM, Remi Bergsma wrote: > Hi Rohit, > > Could you see if you can add this bug

[GitHub] cloudstack pull request: Issue:Domian admin can view templates in ...

Github user manasaveloori closed the pull request at: https://github.com/apache/cloudstack/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/158#issuecomment-127891937 enabled = enabled if enabled else 'true' will set enable to true if enable is false or None which is unexpected, ideally enable should be false i