Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/654#discussion_r36167090
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/SnapshotDescriptor.java ---
@@ -166,12 +168,7 @@ public void removeDiskReferenceFromSnapshot(String
diskFileName) {
assert (false);
s_logger.error("Unexpected exception ", e);
} finally {
- if (out != null) {
- try {
- out.close();
- } catch (IOException e) {
- }
- }
+ closeAutoCloseable(out, "buffered write for bytestream");
--- End diff --
Yes, due to the amount of tedious work I am choosing try-with-resource only
when it is easy. It is in this case so I will change it, thanks @koushik-das
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
