Re: Review Request: Fix for CLOUDSTACK-2181: Scale down is allowed, which is not expected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11936/#review22158 --- Ship it! Ship It! - Nitin Mehta On June 18, 2013, 2:38 p.m., Har

Re: fixPath (was: committer wanted for review)

I am not authorized to access the link you are sending Edison, but interested in the contents. Could you send it please? On Wed, Jun 19, 2013 at 10:26 PM, Edison Su wrote: > The double slash can happen in every where, there is bug fix long time ago( > http://bugs.cloud.com/show_bug.cgi?id=14066

Re: Some commands didn't show up in the marvin test API

On Wed, Jun 19, 2013 at 05:46:06PM -0700, Sheng Yang wrote: > Hi, > > I just found out that some commands (e.g. AddBaremetalHostCmd, > AddBaremetalKickStartPxeCmd) didn't show in the marvin's > API(tools/marvin/marvin/cloudstackAPI), make it hard for me to write marvin > test case for them. > > T

TemplateAdapterBase broken

A conflict was checked in with 97f8c52. Regards,

Re: Hack Day at CloudStack Collaboration Conference

Any great ruby lovers out there ? I created a session on Deltacloud, we should create a cloudstack driver for it. With couple great ruby guys we could knock this off in 6 hours chrono :) I will buy the beers, -sebastien On Jun 19, 2013, at 10:03 PM, David Nalley wrote: > It is completely ope

RE: PCI-Passthrough with CloudStack (Improved)

Hi, Will you be looking at/documenting the need to enable PCI pass-through by creating a customised kernel for KVM hosts? [we've needed to change the DMAR flag to 'on' by default] Regards, Paul Angus S: +44 20 3603 0540 | M: +447711418784 paul.an...@shapeblue.com -Original Message- F

Re: Hack Day at CloudStack Collaboration Conference

I'd like that but my ruby experience is limited and my prios are dictated (kind of), so the datastore sessions by John and myself go first. On Thu, Jun 20, 2013 at 10:40 AM, Sebastien Goasguen wrote: > Any great ruby lovers out there ? > > I created a session on Deltacloud, we should create a cl

Re: TemplateAdapterBase broken

Edison burning the midnight oil. He's fixed it in the subsequent commit however. On Thu, Jun 20, 2013 at 08:38:47AM +, Daan Hoogland wrote: > A conflict was checked in with 97f8c52. > > Regards, -- Prasanna., Powered by BigRock.com

Re: TemplateAdapterBase broken

On Thu, Jun 20, 2013 at 10:50 AM, Prasanna Santhanam wrote: > He's fixed it in the subsequent > commit however > Yeah, I apologized for the early noise making ;)

Re: Review Request: (CLOUDSTACK-2017) implement network bandwidth rate limits for VMs for KVM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10428/#review22160 --- Commit 289939580815c46cc2e162a7e6e232a4977a7950 in branch refs/heads

Re: TemplateAdapterBase broken

On Thu, Jun 20, 2013 at 11:20:54AM +0200, Daan Hoogland wrote: > On Thu, Jun 20, 2013 at 10:50 AM, Prasanna Santhanam wrote: > > > He's fixed it in the subsequent > > commit however > > > > Yeah, I apologized for the early noise making ;) Not at all. Prompted me to look at other broken stuff po

Re: starting VM and get error of "unable to create a deployment for VM[user|i-2-107-VM]"

The error seems to be somewhere between these logs. Are there more logs in between these ones ? Also are you hitting it consistently ? Retry and also check XS logs 8b966be61006","deviceId":0},{"id":107,"name":"Ubuntu12.04 (Manwin EU)","size":0,"type":"ISO","storagePoolType":"ISO","deviceId":3

Review Request: Fix for CLOUDSTACK-2916, CLOUDSTACK-2457: validation for weight based configuration parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11989/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Description

Error while update cloudstack from version 3.0.2 to 4.0.1

Hi all: There is an error when i upgrade the version of cloudstack from 3.0.2 to 4.0.1.The following are my steps: 1. Use CloudStack-oss-3.0.2-1-rhel6.2.tar.gz. Execute ./install choose M and D. 2. Create zone and creat an instance. 3. Stop cloud-management service. 4. upgrade cloudstack from 3.0.2

Re: UI Plugin Internationalization

On Jun 18, 2013, at 2:08 PM, Brian Federle wrote: > FYI, I created an improvement ticket for plugin localization: > https://issues.apache.org/jira/browse/CLOUDSTACK-3058 Hi folks, how does this play out with the translation efforts which populates the properties files in: client/WEB-INF/class

Re: Review Request: Fix for CLOUDSTACK-2916, CLOUDSTACK-2457: validation for weight based configuration parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11989/#review22161 --- Ship it! Ship It! - Nitin Mehta On June 20, 2013, 9:42 a.m., Har

Review Request: prevent destroy vm with mounted iso

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11990/ --- Review request for cloudstack. Description --- refuse to destroy a vm when

small patch this time

H, can someone have a look? https://reviews.apache.org/r/11990/

RE: UI Plugin Internationalization

This is a very valid question and I think the file containing the translation strings for support for other languages would also have to be taken care off when the standard English strings are being dynamically added to the dictionary from the plugin. -Original Message- From: Sebastien

Review Request: Automation: Resolution for issue 3060. test_routers.py - added condition for vmware while getting process status

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11991/ --- Review request for cloudstack. Description --- Added condition for "vmware

NonOSS build fails?

Does anyone have problem building non oss? The build is failing at: http://jenkins.buildacloud.org/view/master/job/build-master-nonoss/503/console Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-plugin-hypervisor-vmware: Com

Re: NonOSS build fails?

Hi, I am also getting the same error. Thanks, Jayapal On 20-Jun-2013, at 5:04 PM, Prasanna Santhanam wrote: > Does anyone have problem building non oss? The build is failing at: > > http://jenkins.buildacloud.org/view/master/job/build-master-nonoss/503/console > > Failed to execute goal > o

Test Logs

I'm looking for JSON serialised samples of the attach and detach commands. These will be in logs generated during testing. Where can I look to find such logs? DL

Test Logs

(apologies for rebroadcast, used wrong dev list at first) I'm looking for JSON serialised samples of the attach and detach commands. These will be in logs generated during testing. Where can I look to find such logs?

Review Request: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11992/ --- Review request for cloudstack, Sateesh Chodapuneedi, edison su, Alex Huang, and

Re: Review Request: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11992/ --- (Updated June 20, 2013, 11:53 a.m.) Review request for cloudstack, Sateesh Chod

Re: Review Request: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11992/#review22162 --- Ship it! there is a lot of code cleaning in with the functional cha

easy bug to fix for new comer

Hi, Here is an easy bug to fix for a newcomer to cloudstack: https://issues.apache.org/jira/browse/CLOUDSTACK-3096 install pep8 on your machine git clone cloudstack repo go to the marvin directory run pep8 like I show in the bug. edit the python scripts to fix the errors once pep8 is clean, g

[VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

Devs, I would like to call a vote on the following modification to our by-laws. This is in response to the Summary of changes: * Addition of "3.4.2. Non-Technical Decisions" section. This specifies that non-technical decisions can be made on any appropriate list (i.e. marketing@) and also allows

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

Uh... [This is in response to the] quoted thread wherein Sebastian highlights that we have nothing in our by-laws to tell us how to make general non-technical decisions. On 20 June 2013 14:21, Noah Slater wrote: > Devs, > > I would like to call a vote on the following modification to our by-law

RE: easy bug to fix for new comer

Sure, One file at a time! -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: donderdag 20 juni 2013 14:35 To: dev@cloudstack.apache.org Subject: easy bug to fix for new comer Hi, Here is an easy bug to fix for a newcomer to cloudstack: https://issues.apache.or

Re: Review Request: prevent destroy vm with mounted iso

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11990/#review22164 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: small patch this time

Daan, Looks good. I had some small comments which should be very quick to address. Thanks, -John On Jun 20, 2013, at 6:14 AM, Daan Hoogland wrote: > H, > > can someone have a look? > https://reviews.apache.org/r/11990/

Review Request: Fix for CLOUDSTACK-3021: fixed for TesttemplateHierachy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11994/ --- Review request for cloudstack and Prasanna Santhanam. Description --- Fixe

RE: small patch this time

Sure, I read it. I retracted the submission, due to difficulties in reproducing the error state I am trying to solve. I will adjust according to your comment when I get a better feel of the necessity of the fix. thanks -Original Message- From: John Burwell [mailto:jburw...@basho.com] S

Re: NFS Cache storage query

On Wed, Jun 19, 2013 at 07:11:19PM +, Edison Su wrote: > > > > -Original Message- > > From: John Burwell [mailto:jburw...@basho.com] > > Sent: Wednesday, June 19, 2013 11:43 AM > > To: Edison Su > > Cc: dev@cloudstack.apache.org > > Subject: Re: NFS Cache storage query > > > > Edison

Review Request: pep8 fix for testSetupSuccess.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11995/ --- Review request for cloudstack and Sebastien Goasguen. Description --- one

Re: easy bug to fix for new comer

cloudstackConnection was pep8 compliant but seems to have flouted it again. I'll look at setting up a jenkins job for style check when the full pep8 compliance is done. On Thu, Jun 20, 2013 at 01:42:36PM +, Daan Hoogland wrote: > Sure, > > One file at a time! > > -Original Message- >

RE: easy bug to fix for new comer

Btw Sebastien, Newcomer as I am; how do I test the test-code tests? -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: donderdag 20 juni 2013 15:43 To: 'dev@cloudstack.apache.org' Subject: RE: easy bug to fix for new comer Sure, One file at a time!

RE: easy bug to fix for new comer

I noticed some are very small. Doing those first and I am still doing them one file at a time! -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: donderdag 20 juni 2013 16:02 To: dev@cloudstack.apache.org Subject: Re: easy bug to fix for new comer cloudstackConne

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

On Thu, Jun 20, 2013, at 08:21 AM, Noah Slater wrote: > Devs, > > I would like to call a vote on the following modification to our by-laws. > This is in response to the > > Summary of changes: > > * Addition of "3.4.2. Non-Technical Decisions" section. This specifies > that > non-technical decis

Re: TemplateAdapterBase broken

On Thu, Jun 20, 2013 at 03:01:28PM +0530, Prasanna Santhanam wrote: > On Thu, Jun 20, 2013 at 11:20:54AM +0200, Daan Hoogland wrote: > > On Thu, Jun 20, 2013 at 10:50 AM, Prasanna Santhanam > > wrote: > > > > > He's fixed it in the subsequent > > > commit however > > > > > > > Yeah, I apologize

Review Request: __init__.py cleansed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11996/ --- Review request for cloudstack and Sebastien Goasguen. Description --- __in

Review Request: setup.py pep8'ed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11998/ --- Review request for cloudstack and Sebastien Goasguen. Description --- setu

Review Request: remoteSSHClient.py cleansed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12001/ --- Review request for cloudstack and Sebastien Goasguen. Description --- remo

VMWare changing the default vSwitch Name

Hi All, I am currently working on a Cloudstack VMWare integration project and we have setup up a dedicated vSwitch and PortGroup for cloudstack. On reading the VMware vSphere Installation and Configuration ( http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Installation_Guide/v

Re: [GSOC]CloudStack deployment questions

On Wed, 19 Jun 2013 22:16:40 +0530, Prasanna Santhanam wrote: On Wed, Jun 19, 2013 at 10:53:37AM -0400, Han,Meng wrote: > >You can run all the management server code from your laptop as a >development environment and add an external hypervisor host (Either >Xen/KVM) to it. The guests, system VMs

Review Request: marvinPlugin cleansed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12005/ --- Review request for cloudstack and Sebastien Goasguen. Description --- marv

RE: easy bug to fix for new comer

Halting now, will take on the bigger ones tonight/-morow -Original Message- From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] Sent: donderdag 20 juni 2013 16:12 To: 'dev@cloudstack.apache.org' Subject: RE: easy bug to fix for new comer I noticed some are very small. Doing those f

Re: easy bug to fix for new comer

thanks, I will check your patches now On Jun 20, 2013, at 10:54 AM, Daan Hoogland wrote: > Halting now, will take on the bigger ones tonight/-morow > > -Original Message- > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > Sent: donderdag 20 juni 2013 16:12 > To: 'dev@cloud

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

I don't consider a website change to be technical. On 20 June 2013 15:14, Joe Brockmeier wrote: > On Thu, Jun 20, 2013, at 08:21 AM, Noah Slater wrote: > > Devs, > > > > I would like to call a vote on the following modification to our by-laws. > > This is in response to the > > > > Summary of c

Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)

Less terse follow up... ;) Note that our current by-laws effectively state that any technical decision needs to happen on dev@. I am just clarifying the intent. Note also that we currently do not define what a "technical decision" is, but it is my opinion that this is any decision which relates t

Re: Review Request: pep8 fix for testSetupSuccess.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11995/#review22166 --- Ship it! applied to master with e8f0b2a48b6519b296230705057772d

Re: Review Request: __init__.py cleansed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11996/#review22167 --- Ship it! committed to master with 4ca3f5c5e93e9493f56eaf4030808c5db

RE: VMWare changing the default vSwitch Name

> -Original Message- > From: Noel King [mailto:noelk...@gmail.com] > Sent: 20 June 2013 20:16 > To: dev@cloudstack.apache.org > Subject: VMWare changing the default vSwitch Name > > Hi All, > > I am currently working on a Cloudstack VMWare integration project and we have > setup up a ded

Re: Review Request: setup.py pep8'ed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11998/#review22169 --- Ship it! applied to master with 30c6e2707a8c53daeb0907b547e1ad1bfec

Re: Review Request: remoteSSHClient.py cleansed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12001/#review22170 --- Ship it! applied to master with fa580808070c8ece13056b34d772858ee57

Re: Review Request: marvinPlugin cleansed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12005/#review22171 --- Ship it! applied to master with cd221fc33e755abdc7ecb2b31c98d6f2aa0

Re: easy bug to fix for new comer

Daan, Your patches applied cleanly and have been committed to master. Please mark the review as submitted In your next patches try to use the bug id in at the start of the comment, that way the commit will automatically show up in JIRA and review board…magic. do something like that: git commit

Re: easy bug to fix for new comer

Daan, also assign the bug to yourself in JIRA… If you cannot do it, we need to give you "karma" On Jun 20, 2013, at 1:04 PM, Sebastien Goasguen wrote: > Daan, > > Your patches applied cleanly and have been committed to master. > Please mark the review as submitted > > In your next patches try

Re: VMWare changing the default vSwitch Name

Hi Sateesh Thanks for your reply, I have made those changes and restarted but with no joy and am still seeing vSwitch0 being used in the log and my portgroup is returning "Message: Uable to find management port group MyPortGroup" INFO [vmware.resource.VmwareResource] (ClusteredAgentManager Timer

RE: VMWare changing the default vSwitch Name

> -Original Message- > From: Noel King [mailto:noelk...@gmail.com] > Sent: 20 June 2013 22:37 > To: dev@cloudstack.apache.org > Subject: Re: VMWare changing the default vSwitch Name > > Hi Sateesh > > Thanks for your reply, I have made those changes and restarted but with no > joy and am

RE: VMWare changing the default vSwitch Name

Apologies if I did not state that, but had restarted the management server and error message sent was after the restart. So looks like its not picking up the change. thanks Noel On Jun 20, 2013 6:16 p.m., "Sateesh Chodapuneedi" < sateesh.chodapune...@citrix.com> wrote: > > -Original Message

RE: TemplateAdapterBase broken

I am fixing bugs related to object_store merge, didn't aware there are so many changes on the master related to storage code just in this Monday. Sorry guys. > -Original Message- > From: Prasanna Santhanam [mailto:t...@apache.org] > Sent: Thursday, June 20, 2013 7:15 AM > To: dev@cloudst

Re: VMWare changing the default vSwitch Name

Hi Sateesh, Sorry replied too quick from phone when I away from my desk, Are those global config changes in 4.1 as well as I dont see them but will have a quick search in docs for them. "private.network.vswitch.name "public.network.vswitch.name" "guest.network.vswitch.name" Thanks Noel On 20 J

Re: Review Request: SolidFire storage plug-in and enhancements to the storage framework and GUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11479/ --- (Updated June 20, 2013, 5:35 p.m.) Review request for cloudstack, edison su and

Re: NonOSS build fails?

I am looking at this, it might be caused by last night's object_store branch merge, will provide a fix soon. -min On 6/20/13 4:51 AM, "Jayapal Reddy Uradi" wrote: >Hi, > >I am also getting the same error. > >Thanks, >Jayapal >On 20-Jun-2013, at 5:04 PM, Prasanna Santhanam > wrote: > >> Does an

Re: Review Request: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

> On June 20, 2013, 12:20 p.m., daan Hoogland wrote: > > there is a lot of code cleaning in with the functional change. I'd submit > > two changes. No blocking remarks, though. Thanks Daan for the review and comments. this patch can be submit in two parts. - Rajesh

Re: disk_io_throttle and solidfire Patch Review Status

Mike, I am booked up this afternoon. I will start my review tomorrow and complete as necessary on the flight Saturday. Thanks, -John On Jun 20, 2013, at 1:39 PM, Mike Tutkowski wrote: > You've possibly seen the auto-generated e-mail that I updated Review Board > with a new diff. This third

Re: disk_io_throttle and solidfire Patch Review Status

You've possibly seen the auto-generated e-mail that I updated Review Board with a new diff. This third diff is comprehensive in that it includes all of the changes I've made for this feature. I believe I have now completed all actions that were required of me. Please let me know if you have quest

[DISCUSS] Do we need code review process for code changes related to storage subsystem?

For interface/API changes, we'd better have a code review, as more storage vendors and more developers outside Citrix are contributing code to CloudStack storage subsystem. The code change should have less surprise for everybody who cares about storage subsystem.

Re: VMWare changing the default vSwitch Name

Hi Sateesh, Did not realise unitl I started looking at the code that you contributed greatly to it, great to get reply from you.I have done some investigation around the VmwareManagerImpl.java which uses this configuration and see that change was made for 4.2 branch, sadly. Do you have any f

Re: easy bug to fix for new comer

My karma is fine. I overlooked this detail Verzonden vanaf mobiel Oorspronkelijk bericht Van: Sebastien Goasguen Datum: 2013-06-20 19:05 (GMT+01:00) Aan: dev@cloudstack.apache.org Onderwerp: Re: easy bug to fix for new comer Daan, also assign the bug to yourself in JIR

RE: fixPath (was: committer wanted for review)

I uploaded the patch to dropbox: https://www.dropbox.com/s/d9fn17xmho19fdc/cloud-3.0.1-bug14066.patch, can you access it? The patch is cooked by Fred Wittekind one year ago. > -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Thursday, June 20, 2013 12:1

Re: disk_io_throttle and solidfire Patch Review Status

No problem :) Just wanted to let you know that it's there and that I believe I've completed all of what you, Wei, and I talked about. Thanks! On Thu, Jun 20, 2013 at 11:42 AM, John Burwell wrote: > Mike, > > I am booked up this afternoon. I will start my review tomorrow and > complete as nec

Re: [DISCUSS] Do we need code review process for code changes related to storage subsystem?

I agree. I've had to make slight changes to the interface a storage plug-in implements (around createAsync and deleteAsync), but that should be fine since 4.2 is the first release to expose this interface. On Thu, Jun 20, 2013 at 11:59 AM, Edison Su wrote: > For interface/API changes, we'd bet

Re: fixPath (was: committer wanted for review)

Yes, got it. It is quite big. It is dealing with more than just a path format, isn't it? On Thu, Jun 20, 2013 at 8:53 PM, Edison Su wrote: > I uploaded the patch to dropbox: > https://www.dropbox.com/s/d9fn17xmho19fdc/cloud-3.0.1-bug14066.patch, can > you access it? The patch is cooked by Fred

Re: [GSOC]CloudStack deployment questions

On Jun 20, 2013, at 10:50 AM, "Han,Meng" wrote: > On Wed, 19 Jun 2013 22:16:40 +0530, Prasanna Santhanam wrote: >> On Wed, Jun 19, 2013 at 10:53:37AM -0400, Han,Meng wrote: >>> > >>> >You can run all the management server code from your laptop as a >>> >development environment and add an externa

[GSoC] Update

Dharmesh, Shiva, how are you guys doing ? -sebastien

RE: fixPath (was: committer wanted for review)

> -Original Message- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Thursday, June 20, 2013 1:03 PM > To: dev > Subject: Re: fixPath (was: committer wanted for review) > > Yes, got it. It is quite big. It is dealing with more than just a path > format, isn't it? > Yah,

Review Request: jsonHelper.py cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12017/ --- Review request for cloudstack and Sebastien Goasguen. Description --- .jso

Re: fixPath (was: committer wanted for review)

Edison, As I mentioned in a previous email, it feels like a good place for Path value object that encapsulates behavior. I propose we throw this topic on the board for Sunday's Storage Architecture session, and bring the resulting proposals back to the ML. To my mind, we overuse String throug

Re: Review Request: CLOUDSTACK-2571 ZWPS issues with Enabling/Clearing the Maintenance State of the Storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11992/#review22204 --- server/src/com/cloud/storage/StoragePoolAutomationImpl.java

Re: Review Request: Fix primary datastore NPE/incorrect db entry/exception propagation for KVM on cloudstack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11984/#review22205 --- engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/D

Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9818/#review22206 --- NFS secondary storage is not stored in host table any more. Yes, fina

Re: PCI-Passthrough with CloudStack (Improved)

Hi Paul, I think that is more or less dependent on the hardware quirks. For my case I only had to add intel_iommu=on to the kernel cmdline to get PCI Passthrough working. An additional cmdline, pci=nocrs, was needed to get SR-IOV mode of the Mellanox ConnectX-2 card working. Best Regards, Pawit

Re: [DISCUSS] Do we need code review process for code changes related to storage subsystem?

On Thu, Jun 20, 2013 at 05:59:01PM +, Edison Su wrote: > For interface/API changes, we'd better have a code review, as more storage > vendors and more developers outside Citrix are contributing code to > CloudStack storage subsystem. The code change should have less surprise for > everybody

Re: ACS 4.1.1 release - bugfixes to backport

I found there is an issue about versioning. When we cut 4.1.1 release, we have to patch like this: --- diff --git a/server/src/com/cloud/upgrade/dao/Upgrade40to41.java b/server/src/com/cloud/upgrade/dao/Upgrade40to41.java index 9e386b9..89f54bc 100644 --- a/server/src/com/clo

Re: [Review Request] Re-enabling baremetal on master

Hi, I've updated baremetal-4.2 branch, added integration test for some of baremetal related APIs, also fixed a bunch of baremetal API issues exposed by the testing. Thanks! --Sheng On Wed, Jun 19, 2013 at 11:41 AM, Chip Childers wrote: > On Wed, Jun 19, 2013 at 11:36:11AM -0700, Sheng Yang

Re: [Review Request] Re-enabling baremetal on master

Nice! I'm glad the feature has the benefit of tests now. Thanks for doing this Sheng! David - are you comfortable with this, and will you now +1 the feature? On Thu, Jun 20, 2013 at 9:55 PM, Sheng Yang wrote: > Hi, > > I've updated baremetal-4.2 branch, added integration test for some of > bar

Re: [Review Request] Re-enabling baremetal on master

Yes Happy to +1. Sheng, thanks for stepping up and getting this done. --David On Jun 20, 2013 7:19 PM, "Chip Childers" wrote: > Nice! I'm glad the feature has the benefit of tests now. Thanks for > doing this Sheng! > > David - are you comfortable with this, and will you now +1 the feature? >

Re: [GSoC] Update

I am studying the current ui and still working on the prototype with angular.js. Hoping to finish it by sunday. On Fri, Jun 21, 2013 at 2:17 AM, Sebastien Goasguen wrote: > Dharmesh, Shiva, how are you guys doing ? > > -sebastien >

Re: fixPath (was: committer wanted for review)

On Thu, Jun 20, 2013 at 06:07:05PM -0400, John Burwell wrote: > Edison, > > As I mentioned in a previous email, it feels like a good place for > Path value object that encapsulates behavior. I propose we throw > this topic on the board for Sunday's Storage Architecture session, > and bring the re

Re: [DISCUSS] Do we need code review process for code changes related to storage subsystem?

On Thu, Jun 20, 2013 at 08:41:56PM -0400, Chip Childers wrote: > On Thu, Jun 20, 2013 at 05:59:01PM +, Edison Su wrote: > > For interface/API changes, we'd better have a code review, as more > > storage vendors and more developers outside Citrix are > > contributing code to CloudStack storage s

Re: [DISCUSS] Do we need code review process for code changes related to storage subsystem?

Prasanna, I believe the problem Edison is trying to address is high churn and rework incurred by long review cycles. I find it hard to review interfaces in isolation without implementations depicting actual usage. I would also like to see process ceremony kept to minimum to reduce drag on the o

Review Request: Test Volumes Services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12021/ --- Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.

Re: easy bug to fix for new comer

One other thing: You can skip pep8-ing the integration module since that will be deprecated in the future. There's a lot of classes in there so it'll save you time. On Thu, Jun 20, 2013 at 01:04:55PM -0400, Sebastien Goasguen wrote: > Daan, > > Your patches applied cleanly and have been committed

Re: easy bug to fix for new comer

On Thu, Jun 20, 2013 at 02:01:54PM +, Daan Hoogland wrote: > Btw Sebastien, > > Newcomer as I am; how do I test the test-code tests? The first step would be to see if you are able to build marvin $ mvn -Pdeveloper -pl :cloud-marvin clean install You can run tests suitable for basic zone wit

Re: Review Request: Test Snapshot Services

> On June 18, 2013, 6:40 a.m., Prasanna Santhanam wrote: > > This test actually passes on jenkins. What are we changing here? > > sanjeev n wrote: > In an environment created with apche master, I see ssvm type as > "SecondaryStorageVM" in host table. So I modified the script accordingly. I

Re: Review Request: jsonHelper.py cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12017/#review22240 --- Ship it! c03ba0c8e6904b86d46d86055f05a0c047af190d - Prasanna Santh

  1   2   >