Daan, Your patches applied cleanly and have been committed to master. Please mark the review as submitted
In your next patches try to use the bug id in at the start of the comment, that way the commit will automatically show up in JIRA and review board…magic. do something like that: git commit -m "CLOUDSTACK-3096: blah blah blah…." You can also send everything as a single commit…just edit the files, stage them, git add….and do a single commit. thanks a lot…I told you this was an easy one :) -sebastien On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <run...@gmail.com> wrote: > thanks, I will check your patches now > > > On Jun 20, 2013, at 10:54 AM, Daan Hoogland <dhoogl...@schubergphilis.com> > wrote: > >> Halting now, will take on the bigger ones tonight/-morow >> >> -----Original Message----- >> From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] >> Sent: donderdag 20 juni 2013 16:12 >> To: 'dev@cloudstack.apache.org' >> Subject: RE: easy bug to fix for new comer >> >> I noticed some are very small. Doing those first and I am still doing them >> one file at a time! >> >> -----Original Message----- >> From: Prasanna Santhanam [mailto:t...@apache.org] >> Sent: donderdag 20 juni 2013 16:02 >> To: dev@cloudstack.apache.org >> Subject: Re: easy bug to fix for new comer >> >> cloudstackConnection was pep8 compliant but seems to have flouted it again. >> I'll look at setting up a jenkins job for style check when the full pep8 >> compliance is done. >> >> On Thu, Jun 20, 2013 at 01:42:36PM +0000, Daan Hoogland wrote: >>> Sure, >>> >>> One file at a time! >>> >>> -----Original Message----- >>> From: Sebastien Goasguen [mailto:run...@gmail.com] >>> Sent: donderdag 20 juni 2013 14:35 >>> To: dev@cloudstack.apache.org >>> Subject: easy bug to fix for new comer >>> >>> Hi, >>> >>> Here is an easy bug to fix for a newcomer to cloudstack: >>> >>> https://issues.apache.org/jira/browse/CLOUDSTACK-3096 >>> >>> install pep8 on your machine >>> git clone cloudstack repo >>> go to the marvin directory >>> >>> run pep8 like I show in the bug. >>> >>> edit the python scripts to fix the errors >>> >>> once pep8 is clean, git commit everything, create a patch and send to >>> review board. >>> >>> Any takers ? >>> >>> -Sebastien >> >> -- >> Prasanna., >> >> ------------------------ >> Powered by BigRock.com >> >
