Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1530
Packaging result: âcentos6 âcentos7 âdebian. JID-223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1530
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1530
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1530
@swill @jburwell is this one ok?
@bvbharat I don't see anything in the link in your comment so I must assume
the failure is in the test itself
If we don't merge this I will close the
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1530
### ACS CI BVT Run
**Sumarry:**
Build Number 180
Hypervisor xenserver
NetworkType Advanced
Passed=69
Failed=1
Skipped=3
_Link to logs Folder (search b
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402502
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64397004
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Log
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64395993
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1530#issuecomment-221211912
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64353975
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent) thr
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64353084
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) t
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64352201
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) t
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1530#issuecomment-217442913
@DaanHoogland I am having surgery this afternoon, so I will be unable to
get it to it today (6 May 2016). I will try to put together a PR later this
weekend or ea
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1530
Vmdk findbugs
replacing #1351
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs
Alternatively
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1530#issuecomment-217370549
@jburwell Even when out of scope, your comments may make sense. please send
a pull request to my branch and we can discuss those.
---
If your project is set u
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -216,10 +226,12 @@ public String getAdapterType() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282559
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -144,10 +151,12 @@ public String getAdapterType() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282499
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282456
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) throw
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282416
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent) throw
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1530
Vmdk findbugs
replacing #1351
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs
Alternatively
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1530
Vmdk findbugs
replacing #1351
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs
Alternatively
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216515896
@rhtyd you are right, I rebased against master instead of 4.7, sorry, will
close and reopen against master
---
If your project is set up for it, you can reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216442417
@DaanHoogland I'm seeing a lot of commits, can you rebase against 4.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216225603
@rhtyd & @DaanHoogland I don't have the ability to test this as I have a
KVM setup, can one of you post some test results using VMware?
---
If your project is set u
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216221100
@DaanHoogland can you rebase it once again and push -f
Once CI tested, we should be able to merge this cc @swill
tag:easypr
---
If your project is
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-206250177
+1 for code changes and based on the test report from @bvbharatk.
Since the changes are specific to VMware and the test results are for XS,
not sure how to t
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-204046109
#1438 covers this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-204045871
I opened #1427 and I agree, @rafaelweingartner and @swill so please go
ahead. I will close #1427
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-204006448
I agree, but I was the one that opened the PR, so in my opinion, my opinion
should no count much here :)
---
If your project is set up for it, you can re
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-204005852
I think we should probably merge this one and not #1427. Do you agree?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-204001802
Tests were performed and reviews executed; so, should we merge this or the
#1427?
---
If your project is set up for it, you can reply to this email and h
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-203997224
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1438#discussion_r57527860
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -395,16 +391,9
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-201476824
I don't think these tests failing are relevant to this change. We agree
this is ready to be merged? Only against master?
---
If your project is set up for it, you
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1438#discussion_r57485802
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -395,16 +391,9 @@ protected
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-200255385
@swill @DaanHoogland tested this PR - LGTM.
All BVTs have passed with the exception of the following tests
- test_07_list_default_iso - iso didn't exist.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-200074256
### ACS CI BVT Run
**Sumarry:**
Build Number 120
Hypervisor xenserver
NetworkType Advanced
Passed=106
Failed=12
Skipped=4
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-198490086
LGTM
Ran BVT with XS 6.5 - all the test passed with the exception of the
following tests due to env issues:
test_01_create_volume - ssh issue.
test_0
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1438#discussion_r55938944
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -395,16 +391,9
GitHub user rafaelweingartner opened a pull request:
https://github.com/apache/cloudstack/pull/1438
Fix new error found in findbugs slow build #3455
Fix new find bug error that was introduced in PR #1361
Report:
http://jenkins.buildacloud.org/job/build-master-slowbuild/3455
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-191424588
Haha. Fair enough. I will let Raja test, but otherwise it LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-19145
:) @swill it is the only part I typed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-191389512
It looks like your IDE had a field day with this class. So other than the
reordering of imports, adding `final` to a ton of variables and removing some
unneeded brac
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1427
findbugs: new found old instance of DM_DEFAULT_ENCODING fixed
this quick fix to silence the findbugs
which seems to think this is a new issue
You can merge this pull request into
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-176195149
LGTM, did not test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-176191880
Seems good to me looking at it. Don't know how to test it properly, but
code-wise the changes look sane to me.
---
If your project is set up for it, you can reply to
https://github.com/apache/cloudstack/pull/1351 is still open for the last
two issues to silence findbugs. please all have a look.
--
Daan
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1351
Vmdk findbugs
these are two of the findbugs errors coming out of our jenkins all the
time. The author seems to be unavailable so I kicked and screamed at it.
notice that this is
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-172917596
note that jenkins isn't responding to the PR (so far)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1351
Vmdk findbugs
these are two of the findbugs errors coming out of our jenkins all the
time. The author seems to be unavailable so I kicked and screamed at it.
notice that this is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-158753796
Since the commits changed I run the tests again. Still LGTM.
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_h
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-154403803
Did run the tests before, forgot to post them.
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-153681753
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-153579131
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-152998269
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-152982076
@karuturi at your service
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1019#discussion_r43614066
--- Diff:
plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java
---
@@ -296,7 +296,7 @@ private void setHttpHeade
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-152976291
though its beyond what this PR want to fix, maybe we could fix L403(hash ==
HASH_CONFLICT) and L406(hash != HASH_IGNORE) as well.
---
If your project is set u
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1019#discussion_r43612367
--- Diff:
plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java
---
@@ -296,7 +296,7 @@ private void setHttpHeader(fi
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1019#discussion_r43609915
--- Diff:
plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java
---
@@ -296,7 +296,7 @@ private void setHttpHeade
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1019#discussion_r43605823
--- Diff:
plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java
---
@@ -296,7 +296,7 @@ private void setHttpHeader(fi
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1019#discussion_r43602513
--- Diff:
plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java
---
@@ -296,7 +296,7 @@ private void setHttpHeade
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-152939410
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1019#discussion_r43601287
--- Diff:
plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java
---
@@ -296,7 +296,7 @@ private void setHttpHeader(fi
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1019
findbugs: ! equals instead of !=
simple pmd warning fixed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack PMD
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/779#issuecomment-138214857
Thanks everyone for the quick merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/779
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/779#issuecomment-138197048
LGTM no. 3 ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sedukull commented on the pull request:
https://github.com/apache/cloudstack/pull/779#issuecomment-138193843
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/779#issuecomment-138191794
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/779
Fixing findbugs error due to PR #755 merge
issue: Boxing/unboxing to parse a primitive
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user karuturi closed the pull request at:
https://github.com/apache/cloudstack/pull/764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/764#issuecomment-136590200
closing in favor of a better fix @ #762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/764#issuecomment-136332126
@karuturi please have a look at
https://github.com/apache/cloudstack/pull/762/files Your solution will work but
I like the other one as well.
---
If your proj
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/764
Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High
ex.printStacktrace prints to System.err by default. Used it and removed
the printwriter which was causing the findbugs issue
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/573#issuecomment-121528428
@bhaisaab this PR didn't auto close. You think your ref from
shapeblue/cloudstack to here might have anything to do with it?
---
If your project is set up for
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/573
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/573#issuecomment-121139921
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/573#issuecomment-121137019
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-120541217
@DaanHoogland some weird confusion, nevermind
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-120524298
yes this is on master. is there doubt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-120495209
@DaanHoogland was this committed to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/573#issuecomment-120456014
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/573
Findbugs issues with instance acces to static fields
I wonder if these fields are used solely on the host or on the management
server as well.
If the code is running on both it is not
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/539#discussion_r34026647
--- Diff: server/src/com/cloud/api/auth/APIAuthenticationManagerImpl.java
---
@@ -52,17 +55,25 @@ public void
setApiAuthenticators(List authenticators)
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-119151038
changes looks good. Please go ahead with the merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/539#issuecomment-119087564
@bhaisaab @karuturi @jburwell @everyone: can I get a second LGTM?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-119087493
@bhaisaab @karuturi @jburwell @everyone: can I get a second LGTM?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/535#issuecomment-118883451
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
1 - 100 of 522 matches
Mail list logo
