Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1019#discussion_r43602513
--- Diff:
plugins/network-elements/bigswitch/src/com/cloud/network/bigswitch/BigSwitchBcfApi.java
---
@@ -296,7 +296,7 @@ private void setHttpHeader(final HttpMethodBase m) {
m.setRequestHeader(CONTENT_TYPE, CONTENT_JSON);
m.setRequestHeader(ACCEPT, CONTENT_JSON);
m.setRequestHeader(HTTP_HEADER_INSTANCE_ID, CLOUDSTACK_INSTANCE_ID
+ "-" + zoneId);
- if (hash != "" ) {
+ if (! "".equals(hash)) {
--- End diff --
sure but why two calls (isNotEmpty calls isEmpty) while this is all we
need? Don't mistake my question for sarcasm. I want to know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
