anks!
Mike
From: Will Stevens
Sent: Friday, May 20, 2016 5:30 PM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents
Unless that PR was not already accounted for in a grandfathered exception.
On May 20, 2016 7:26
, May 20, 2016 5:30 PM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents
Unless that PR was not already accounted for in a grandfathered exception.
On May 20, 2016 7:26 PM, "Daan Hoogland" wrote:
> In the mutiny PR I had to change the names that I
gt;
> > > *CloudOps* *| *Cloud Solutions Experts
> > > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > > w cloudops.com *|* tw @CloudOps_
> > >
> > > On Fri, May 20, 2016 at 12:49 PM, Tutkowski, Mike <
> > > mike.tutkow...@netapp.com
&
gt; > Also, does this mean that we have zero Hyper-V integration tests run
> > > during CI?
> > >
> > > From: Tutkowski, Mike
> > > Sent: Friday, May 20, 2016 10:47 AM
> > > To: dev@cloudstack.apache.org
> &g
> >
> > From: Tutkowski, Mike
> > Sent: Friday, May 20, 2016 10:47 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Variable renaming in classes meant for Agents
> >
> > Yeah, it has to go into 4.9. :) Unless n
ing CI?
> >
> > From: Tutkowski, Mike
> > Sent: Friday, May 20, 2016 10:47 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Variable renaming in classes meant for Agents
> >
> > Yeah, it has to go into 4.9. :)
utkowski, Mike
> Sent: Friday, May 20, 2016 10:47 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V.
>
> From: Rafael Weingär
strange situation because we need to make sure
> > > people
> > > > > are either aware of the fact that properties in Command classes are
> > > > > serialized (and not change existing variable names) or come up
> with a
> > > > less
> > > > >
h a
> > > less
> > > > fragile way of choosing property names when sending data (perhaps
> using
> > > > annotations).
> > > >
> > > > At the very least, we should have comments in these classes
> indicating
> > > the
> &
Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V.
From: Rafael Weingärtner
Sent: Friday, May 20, 2016 10:42 AM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents
You are right Mike about the “_”. The
, Mike
wrote:
> Yeah, I'm just teasing. :) The PR needs to go into 4.9 to fix Hyper-V.
>
> From: Rafael Weingärtner
> Sent: Friday, May 20, 2016 10:49 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant
Yeah, I'm just teasing. :) The PR needs to go into 4.9 to fix Hyper-V.
From: Rafael Weingärtner
Sent: Friday, May 20, 2016 10:49 AM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents
I think that if we say we su
Also, does this mean that we have zero Hyper-V integration tests run during CI?
From: Tutkowski, Mike
Sent: Friday, May 20, 2016 10:47 AM
To: dev@cloudstack.apache.org
Subject: Re: Variable renaming in classes meant for Agents
Yeah, it has to go into 4.9
20, 2016 10:42 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> You are right Mike about the “_”. The point is that in some other language
> the use of “_” makes sense, whereas in Java it does not, at least not the
> way it has
lem.
>
> From: Rafael Weingärtner
> Sent: Friday, May 20, 2016 9:12 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Variable renaming in classes meant for Agents
>
> Hi guys,
> I agree with Daan that if class fields have improper (not
long term?
> >
> > Thanks!
> > Mike
> >
> > From: Anshul Gangwar
> > Sent: Thursday, May 19, 2016 10:47 PM
> > To: dev@cloudstack.apache.org
> > Subject: Variable renaming in classes meant for Agents
> >
gt; the
> > > > dangers of changing property names. It might also be beneficial to
> have
> > > > unit tests in place that expect certain variable names and assert if
> > they
> > > > are not as expected.
> > > >
> > > > In the meanwhile, I plan to change the va
o be beneficial to have
> > > unit tests in place that expect certain variable names and assert if
> they
> > > are not as expected.
> > >
> > > In the meanwhile, I plan to change the variable names back that were
> > > changed in PR #816.
> > &
> > > changed in PR #816.
> > >
> > > Additional thoughts on how this should be addressed long term?
> > >
> > > Thanks!
> > > Mike
> > >
> > > From: Anshul Gangwar
> > > Sent: Th
________________
> > From: Anshul Gangwar
> > Sent: Thursday, May 19, 2016 10:47 PM
> > To: dev@cloudstack.apache.org
> > Subject: Variable renaming in classes meant for Agents
> >
> > Hi,
> >
> > We should not allow renaming of variabl
s should be addressed long term?
>
> Thanks!
> Mike
>
> From: Anshul Gangwar
> Sent: Thursday, May 19, 2016 10:47 PM
> To: dev@cloudstack.apache.org
> Subject: Variable renaming in classes meant for Agents
>
> Hi,
>
> We should not al
Subject: Variable renaming in classes meant for Agents
Hi,
We should not allow renaming of variables in classes which ends with Command
and TO. As these objects are meant to be consumed by Agents.
Agents may not be written in java so relying on these variable names to get the
info. One such
Hi,
We should not allow renaming of variables in classes which ends with Command
and TO. As these objects are meant to be consumed by Agents.
Agents may not be written in java so relying on these variable names to get the
info. One such example is Hyper-V agent.
Hyper-V support is currently br
23 matches
Mail list logo
