Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Laszlo Hornyak
at 10:38 AM, David Nalley wrote: > > >>> > I have not. Yesterday RB went down for some period of time, though > > >>> > AFAIK, infra restored it. > > >>> > > > >>> > --David > > >>> > > > >>> > On Sa

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Daan Hoogland
>> On Sun, Feb 2, 2014 at 10:38 AM, David Nalley wrote: >> >> > I have not. Yesterday RB went down for some period of time, though >> >> > AFAIK, infra restored it. >> >> > >> >> > --David >> >> > >> >>

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Laszlo Hornyak
an > >> > >> On Sun, Feb 2, 2014 at 10:38 AM, David Nalley wrote: > >> > I have not. Yesterday RB went down for some period of time, though > >> > AFAIK, infra restored it. > >> > > >> > --David > >> > > >> > On S

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Prasanna Santhanam
t;> Daan > >>> > >>> On Sun, Feb 2, 2014 at 10:38 AM, David Nalley wrote: > >>> > I have not. Yesterday RB went down for some period of time, though > >>> > AFAIK, infra restored it. > >>> > > >>> > --David >

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Daan Hoogland
10:38 AM, David Nalley wrote: >>> > I have not. Yesterday RB went down for some period of time, though >>> > AFAIK, infra restored it. >>> > >>> > --David >>> > >>> > On Sat, Feb 1, 2014 at 4:11 PM, Daan Hoogland >>>

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Daan Hoogland
an Hoogland >> wrote: >> >> H David, >> >> >> >> have you started on this yet? >> >> I can't reach the review board at the moment. >> >> >> >> On Mon, Jan 27, 2014 at 8:59 PM, David Nalley wrote: >> >>> Hi folks: >&

Re: Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Laszlo Hornyak
; H David, > >> > >> have you started on this yet? > >> I can't reach the review board at the moment. > >> > >> On Mon, Jan 27, 2014 at 8:59 PM, David Nalley wrote: > >>> Hi folks: > >>> > >>> ReviewBoard

Add reviewer to Review requests (was: ReviewBoard)

2014-02-02 Thread Daan Hoogland
riod of time, though > AFAIK, infra restored it. > > --David > > On Sat, Feb 1, 2014 at 4:11 PM, Daan Hoogland wrote: >> H David, >> >> have you started on this yet? >> I can't reach the review board at the moment. >> >> On Mon, Jan 27, 2014

Re: ReviewBoard

2014-02-02 Thread David Nalley
OK - this is now done - we shrank from 93 to 44 reviews due to this. Lets see if we can get these reviewed or rejected and keep up with this. --David On Mon, Jan 27, 2014 at 2:59 PM, David Nalley wrote: > Hi folks: > > ReviewBoard is pretty bloated. There are currently 93 reviews that

Re: ReviewBoard

2014-02-02 Thread David Nalley
2014 at 8:59 PM, David Nalley wrote: >> Hi folks: >> >> ReviewBoard is pretty bloated. There are currently 93 reviews that are open. >> >> Some of those haven't been updated in 7 months old. >> >> Unless someone objects (and promptly begins reviewing and a

Re: ReviewBoard

2014-02-01 Thread Daan Hoogland
H David, have you started on this yet? I can't reach the review board at the moment. On Mon, Jan 27, 2014 at 8:59 PM, David Nalley wrote: > Hi folks: > > ReviewBoard is pretty bloated. There are currently 93 reviews that are open. > > Some of those haven't bee

ReviewBoard

2014-01-27 Thread David Nalley
Hi folks: ReviewBoard is pretty bloated. There are currently 93 reviews that are open. Some of those haven't been updated in 7 months old. Unless someone objects (and promptly begins reviewing and applying patches) I will close any patch that hasn't been updated in 2 months. Please

Re: Reviewboard needs your attention

2013-11-08 Thread Mike Tutkowski
e is this the only review that you cannot see, or it's a general > problem you are seeing with reviewboard. May be try another browser > > > -Original Message- > > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > > Sent: Friday, November 08, 2013 4:4

RE: Reviewboard needs your attention

2013-11-08 Thread Animesh Chaturvedi
Mike is this the only review that you cannot see, or it's a general problem you are seeing with reviewboard. May be try another browser > -Original Message- > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > Sent: Friday, November 08, 2013 4:4

Re: Reviewboard needs your attention

2013-11-08 Thread Mike Tutkowski
--- > > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > > Sent: Thursday, November 07, 2013 6:03 PM > > To: dev@cloudstack.apache.org > > Subject: Re: Reviewboard needs your attention > > > > Hi Animesh, > > > > For whatever reason, I can n

RE: Reviewboard needs your attention

2013-11-07 Thread Animesh Chaturvedi
I can see it fine, were you logged in at that time > -Original Message- > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > Sent: Thursday, November 07, 2013 6:03 PM > To: dev@cloudstack.apache.org > Subject: Re: Reviewboard needs your attention > >

Re: Reviewboard needs your attention

2013-11-07 Thread Mike Tutkowski
Hi Animesh, For whatever reason, I can no longer edit https://reviews.apache.org/r/13865/. Any thoughts on this? Thanks! On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu wrote: > 2013/11/8 Animesh Chaturvedi > > > Given that we are approaching the 4.3 feature freeze tomorrow if you have > > su

Re: Reviewboard needs your attention

2013-11-07 Thread Nguyen Anh Tu
2013/11/8 Animesh Chaturvedi > Given that we are approaching the 4.3 feature freeze tomorrow if you have > submitted patches and are still pending reviews please reach out to your > reviewers Dear Sebastien & Hugo, I have two pending patches on review board need to review: Rebase OVS (sdnexte

Re: Reviewboard needs your attention

2013-11-07 Thread Sebastien Goasguen
I hate to move deadline, but it might be good to have couple days to try to clean review board. -Sebastien On 7 Nov 2013, at 19:26, Animesh Chaturvedi wrote: > There are large number of patches in review board. I went through some of > them and followed up and closed out few that are already

Reviewboard needs your attention

2013-11-07 Thread Animesh Chaturvedi
There are large number of patches in review board. I went through some of them and followed up and closed out few that are already checked in, but the list is huge. Given that we are approaching the 4.3 feature freeze tomorrow if you have submitted patches and are still pending reviews please re

Patches in reviewboard that were updated over two months ago

2013-10-11 Thread Animesh Chaturvedi
Folks Following 27 patches were last updated over 2 months ago | Review ID | Summary |#Reviews | Submitter| People| | 11861 | double slash fix for windows based nfs se

reviewboard-tool

2013-08-15 Thread Hugo Trippaers
Heya all, Together with Daan we made some changes to the reviewboard buildtool. The following changes are now implemented: * Re-build if a new diff is submitted after the original build * Don't try to build a review that already has a ship-it review On the todo list it: * honour the b

Patches in reviewboard needs attention

2013-07-26 Thread Animesh Chaturvedi
There are large number of patches in review board. I went through some of them and followed up and closed out few that are already checked in, but the list is huge. Given that we are approaching the 4.2 code freeze on Monday if you have submitted patches and are still pending reviews please rea

Re: Reviewboard and jenkins

2013-07-26 Thread Hugo
e: > > > The job is running on jenkins.cloudstack.org > > > > This is de job doing the work: > > > > > http://jenkins.cloudstack.org/view/management/job/mgmt-build-reviewboard-requests/ > > > > This is the job being executed with the patch: > > > > >

Re: Reviewboard and jenkins

2013-07-25 Thread Chip Childers
/job/mgmt-build-reviewboard-requests/ > > This is the job being executed with the patch: > > http://jenkins.cloudstack.org/view/master/job/cloudstack-master-with-patch/ > > I really like the pipeline ideas, but we need to be careful with the > timing and the external factors i

Re: Reviewboard and jenkins

2013-07-22 Thread Prasanna Santhanam
On Mon, Jul 22, 2013 at 12:06:31PM +0200, Hugo Trippaers wrote: > The job is running on jenkins.cloudstack.org > > This is de job doing the work: > > http://jenkins.cloudstack.org/view/management/job/mgmt-build-reviewboard-requests/ > > This is the job being ex

Re: Reviewboard and jenkins

2013-07-22 Thread Hugo Trippaers
The job is running on jenkins.cloudstack.org This is de job doing the work: http://jenkins.cloudstack.org/view/management/job/mgmt-build-reviewboard-requests/ This is the job being executed with the patch: http://jenkins.cloudstack.org/view/master/job/cloudstack-master-with

Re: Reviewboard and jenkins

2013-07-20 Thread Prasanna Santhanam
On Sat, Jul 20, 2013 at 09:46:59AM -0400, David Nalley wrote: > On Sat, Jul 20, 2013 at 5:53 AM, Hugo Trippaers wrote: > > > > > > Sent from my iPhone > > > > On 20 jul. 2013, at 10:09, Prasanna Santhanam wrote: > > > >> On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote: > >>> > >>>

Re: Reviewboard and jenkins

2013-07-20 Thread David Nalley
On Sat, Jul 20, 2013 at 5:53 AM, Hugo Trippaers wrote: > > > Sent from my iPhone > > On 20 jul. 2013, at 10:09, Prasanna Santhanam wrote: > >> On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote: >>> >>> On Jul 19, 2013, at 7:15 PM, Daan Hoogland wrote: >>> good stuff, does it ru

Re: Reviewboard and jenkins

2013-07-20 Thread Hugo Trippaers
Sent from my iPhone On 20 jul. 2013, at 10:09, Prasanna Santhanam wrote: > On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote: >> >> On Jul 19, 2013, at 7:15 PM, Daan Hoogland wrote: >> >>> good stuff, does it run the risk of running while another instance is busy? >> >> Probab

Re: Reviewboard and jenkins

2013-07-20 Thread Prasanna Santhanam
On Sat, Jul 20, 2013 at 12:20:11AM +0200, Hugo Trippaers wrote: > > On Jul 19, 2013, at 7:15 PM, Daan Hoogland wrote: > > > good stuff, does it run the risk of running while another instance is busy? > > Probably not, it's a single threaded script. I intend to use jenkins > to schedule it and i

Re: Reviewboard and jenkins

2013-07-19 Thread Prasanna Santhanam
On Fri, Jul 19, 2013 at 06:51:29PM +0200, Hugo Trippaers wrote: > Hey all, > > I've been working on some scripting to get patches submitted on review board > automagically tested with Jenkins. > > The way it works is that a script will check if the jenkins user on > review board (catofong) has c

Re: Reviewboard and jenkins

2013-07-19 Thread Hugo Trippaers
On Jul 19, 2013, at 7:15 PM, Daan Hoogland wrote: > good stuff, does it run the risk of running while another instance is busy? Probably not, it's a single threaded script. I intend to use jenkins to schedule it and i can tell jenkins not to start another instance of a job once one is running

Reviewboard and jenkins

2013-07-19 Thread Hugo Trippaers
Hey all, I've been working on some scripting to get patches submitted on review board automagically tested with Jenkins. The way it works is that a script will check if the jenkins user on review board (catofong) has commented on the review. If it hasn't it will submit a job to jenkins.cloudst

Re: Reviewboard and jenkins

2013-07-19 Thread Daan Hoogland
good stuff, does it run the risk of running while another instance is busy? On Fri, Jul 19, 2013 at 6:57 PM, Prasanna Santhanam wrote: > On Fri, Jul 19, 2013 at 06:51:29PM +0200, Hugo Trippaers wrote: > > Hey all, > > > > I've been working on some scripting to get patches submitted on review >

Re: Reviewboard and jenkins

2013-07-19 Thread Chip Childers
Freaking awesome. I saw that hit the ML, and was just about to ask about it. On Fri, Jul 19, 2013 at 12:51 PM, Hugo Trippaers wrote: > Hey all, > > I've been working on some scripting to get patches submitted on review > board automagically tested with Jenkins. > > The way it works is that a s

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-19 Thread Daan Hoogland
I'll have a quick look on rbtool. I don't agree at all that more ASFBot noise should be produced. I'd like to take the time to learn lua, but the dev channel is not inviting to me because of it. I would propose to remove the present day message from it instead. They get send to the mail list which

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-18 Thread Sheng Yang
We need some mechanism to help on review board. Sometime the people didn't know who to ask for review and sometime committer push the code they didn't familiar with. I decided to spend much more time on reviewing code during 4.2 release period, trying to make sure I would review everything on netw

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-18 Thread Prasanna Santhanam
On Thu, Jul 18, 2013 at 06:07:48PM +0200, Daan Hoogland wrote: > this has been kind of bugging me too. Along with unanswered questions on > teh list by newbees like me. As we all depend on volunteers and > conculeagues I don't really see a solution but reporting on outstanding > reviews and maybe u

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-18 Thread Daan Hoogland
this has been kind of bugging me too. Along with unanswered questions on teh list by newbees like me. As we all depend on volunteers and conculeagues I don't really see a solution but reporting on outstanding reviews and maybe unanswered questions. The latter can only be done manually though, as it

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-18 Thread Chip Childers
So personally, I try my best to look at reviews whenever I have a spare moment. That's not all that frequent, but if everyone did that we would be moving new code into the repo much more effectively and efficiently. On Thu, Jul 18, 2013 at 11:42:01AM +0530, Prasanna Santhanam wrote: > Yes and I'

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-17 Thread Prasanna Santhanam
Yes and I've been doing it for months assigning reviewers, adding comments. In some cases I've also added possible contributors who are working in that area because committers are too "busy" to respond. Hate to be the pessimist around here but even upon adding reviewers I don't see any response. S

RE: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-17 Thread Animesh Chaturvedi
eviewers in the > reviewboard? > > Open an infra jira issue to get added permissions for reviewboard. > > > On Wed, Jul 17, 2013 at 6:02 PM, Sheng Yang wrote: > > > Or only submitter can modify it? > > > > I find it would be useful if we identify the

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-17 Thread Sheng Yang
Created https://issues.apache.org/jira/browse/INFRA-6561 --Sheng On Wed, Jul 17, 2013 at 3:06 PM, Chip Childers wrote: > Open an infra jira issue to get added permissions for reviewboard. > > > On Wed, Jul 17, 2013 at 6:02 PM, Sheng Yang wrote: > > > Or only submitter can

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-17 Thread Chip Childers
Open an infra jira issue to get added permissions for reviewboard. On Wed, Jul 17, 2013 at 6:02 PM, Sheng Yang wrote: > Or only submitter can modify it? > > I find it would be useful if we identify the people who need to review it > after it's submitted. > > --Sheng >

Is it possible for reviewer to add other reviewers in the reviewboard?

2013-07-17 Thread Sheng Yang
Or only submitter can modify it? I find it would be useful if we identify the people who need to review it after it's submitted. --Sheng

Re: Review Request: (CLOUDSTACK-1644) INFRA-5977: Testing ASFBot updates to reviewboard

2013-05-28 Thread ASF Subversion and Git Services
e.org/r/9876/ > --- > > (Updated March 12, 2013, 11:04 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > (CLOUDSTACK-1644) INFRA-5977: Testing ASFBot updates to reviewboard > > > This addresses bug CLOUDS

Re: Review Request: (CLOUDSTACK-1644) INFRA-5977: Testing ASFBot updates to reviewboard

2013-05-25 Thread ASF Subversion and Git Services
iews.apache.org/r/9876/ > --- > > (Updated March 12, 2013, 11:04 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > --- > > (CLOUDSTACK-1644) INFRA-5977: Testing ASFBot updates to reviewboard > > > This ad