Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-19 Thread Sheng Yang
> On March 18, 2014, 10:30 p.m., Sheng Yang wrote: > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java, > > line 282 > > > > > > Put it in query command rather than here. It would demand i

Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-19 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19038/#review37735 --- core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingReso

Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-19 Thread Harikrishna Patnala
> On March 18, 2014, 10:30 p.m., Sheng Yang wrote: > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java, > > line 282 > > > > > > Put it in query command rather than here. It would demand i

Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-18 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19038/#review37641 --- core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java

Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-14 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19038/#review37188 --- Ship it! master -> f7337527cf9dbb35ec4c60621d4b37173635660c, f293c

Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-14 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19038/#review37187 --- Commit f7337527cf9dbb35ec4c60621d4b37173635660c in cloudstack's bran

Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-14 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19038/ --- (Updated March 14, 2014, 9:36 a.m.) Review request for cloudstack, Chiradeep Vi

Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-11 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19038/ --- (Updated March 11, 2014, 3:02 p.m.) Review request for cloudstack, Chiradeep Vi

Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-11 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19038/ --- Review request for cloudstack, Chiradeep Vittal, Jayapal Reddy, and Murali Reddy