----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19038/ -----------------------------------------------------------
(Updated March 14, 2014, 9:36 a.m.) Review request for cloudstack, Chiradeep Vittal, Jayapal Reddy, and Murali Reddy. Changes ------- rebased with master. Ran findbugs on the changes and there are no bugs. Bugs: CLOUDSTACK-6090 https://issues.apache.org/jira/browse/CLOUDSTACK-6090 Repository: cloudstack-git Description ------- CLOUDSTACK-6090: Virtual Router Service Failure Alerting Currently in CS we can monitor the running services on Virtual Router and ensure they are running through the lifetime of VR. Upon failure of any service in VR, monitoring service logs the alerts in VR logs. With this feature those alerts will be sent to MS. Added marvin tests Diffs (updated) ----- core/src/com/cloud/agent/api/GetRouterAlertsAnswer.java PRE-CREATION core/src/com/cloud/agent/api/routing/GetRouterAlertsCommand.java PRE-CREATION core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 3712aba engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 765d86c engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/OpRouterMonitorServiceVO.java PRE-CREATION server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java eeab91d setup/db/db/schema-430to440.sql 056c5f8 systemvm/patches/debian/config/opt/cloud/bin/getRouterAlerts.sh PRE-CREATION systemvm/patches/debian/config/root/monitorServices.py 0319ece test/integration/smoke/test_VirtualRouter_alerts.py PRE-CREATION Diff: https://reviews.apache.org/r/19038/diff/ Testing ------- Thanks, Harikrishna Patnala