Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review44511 --- Commit eb8e630f24f5359b6c2e9a74bf12ea338df66a41 in cloudstack's bran

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42470 --- Commit 882bf079fa1886c9feab0948066a02c1cb6cd86a in cloudstack's bran

Re: Review Request 18677: CLOUDSTACK-3272

Yes, please check the code. It was reverted in 4.4. On Wed, May 14, 2014 at 12:43 PM, Sonal Ojha wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18677/ > > On May 14th, 2014, 8:41 a.m. UTC, *daan Hoogland* wrote: > > Sonal, this one didn't

Re: Review Request 18677: CLOUDSTACK-3272

> On May 14, 2014, 8:41 a.m., daan Hoogland wrote: > > Sonal, this one didn't make it to 4.4. Can you check it? It would really be > > nice to have it in. I dont see these changes made into 4.4. - Sonal --- This is an automatically gen

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42951 --- Sonal, this one didn't make it to 4.4. Can you check it? It would re

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42566 --- Commit 703e9f6f46228518e9ac83efe66cdfebe9107400 in cloudstack's bran

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42381 --- Commit 4b89a45e571a34dff0191d501089aa9b1046bc08 in cloudstack's bran

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42383 --- Ship it! commit 4b89a45e571a34dff0191d501089aa9b1046bc08 in master

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated May 6, 2014, 6:53 a.m.) Review request for cloudstack, Chiradeep Vitta

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42248 --- Patch applies, but does not build on master. please resolve check-st

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42154 --- File Attachment: Works on commit 6c44c0661dae0e9de4ed53fad8951e72db

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated May 5, 2014, 10:56 a.m.) Review request for cloudstack, Chiradeep Vitt

Re: [REMINDER] Review Request 18677: CLOUDSTACK-3272

Kindly let me know your comments to the changes. On Wed, Apr 16, 2014 at 9:32 AM, Sonal Ojha wrote: > Please take a look. > > -- Forwarded message -- > From: Sonal Ojha > Date: Tue, Apr 15, 2014 at 6:07 PM > Subject: Re: Review Request 18677: CLOUDSTACK-3272

[REMINDER] Review Request 18677: CLOUDSTACK-3272

Please take a look. -- Forwarded message -- From: Sonal Ojha Date: Tue, Apr 15, 2014 at 6:07 PM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Murali Reddy , Chiradeep Vittal < chirade...@gmail.com> Cc: Sonal Ojha , cloudstack < dev@cloudstack.apache.org>

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated April 15, 2014, 12:37 p.m.) Review request for cloudstack, Chiradeep V

Re: Review Request 18677: CLOUDSTACK-3272

Kindly take a look at the new patch file and let me know your comments. Thanks, Sonal On Wed, Mar 26, 2014 at 10:31 PM, Sonal Ojha wrote: > > > > On March 26, 2014, 6:36 a.m., Murali Reddy wrote: > > > Thanks for the patch. Could you please ensure patch can be applied to > master, its fails to

Re: Review Request 18677: CLOUDSTACK-3272

> On March 26, 2014, 6:36 a.m., Murali Reddy wrote: > > Thanks for the patch. Could you please ensure patch can be applied to > > master, its fails to apply. Please try the latest one attached, let me know if you see any issue. - Sonal ---

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 26, 2014, 5 p.m.) Review request for cloudstack, Chiradeep Vitta

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review38582 --- Thanks for the patch. Could you please ensure patch can be applied t

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 12:46 p.m.) Review request for cloudstack, Chiradeep V

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 12:33 p.m.) Review request for cloudstack, Chiradeep V

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 12:07 p.m.) Review request for cloudstack, Chiradeep V

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 12:07 p.m.) Review request for cloudstack, Chiradeep V

Re: Review Request 18677: CLOUDSTACK-3272

> On March 21, 2014, 10:11 a.m., Murali Reddy wrote: > > change look good. But patch does not apply on master. Could you please > > upload proper patch? > > > > Also current patch fixes only action events, do you wish to add similar > > logic for alerts and usage events as well? I am attachin

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 24, 2014, 7:23 a.m.) Review request for cloudstack, Chiradeep Vi

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review38080 --- change look good. But patch does not apply on master. Could you plea

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 20, 2014, 7:43 a.m.) Review request for cloudstack, Chiradeep Vi

Re: Review Request 18677: CLOUDSTACK-3272

> On March 18, 2014, 11:38 a.m., Murali Reddy wrote: > > plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java, > > lines 246-254 > > > > > > Why not filter at the source where events

Re: Review Request 18677: CLOUDSTACK-3272

> On March 18, 2014, 11:38 a.m., Murali Reddy wrote: > > plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java, > > line 244 > > > > > > Please use String.Equals method than '==' I w

Re: [REMINDER] Review Request 18677: CLOUDSTACK-3272

ot; wrote: >> >> >Any updates? >> > >> > >> >On Mon, Mar 10, 2014 at 10:01 AM, Sonal Ojha >> >wrote: >> > >> >> Kindly let me know your review comments. >> >> >> >> -- Forwarded message ---

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review37548 --- plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/R

Re: [REMINDER] Review Request 18677: CLOUDSTACK-3272

---- > >> From: Sonal Ojha > >> Date: Tue, Mar 4, 2014 at 11:20 AM > >> Subject: Re: Review Request 18677: CLOUDSTACK-3272 > >> To: Sonal Ojha , cloudstack < > >> dev@cloudstack.apache.org> > >> > >> > >>This is an au

Re: [REMINDER] Review Request 18677: CLOUDSTACK-3272

mments. >> >> -- Forwarded message -- >> From: Sonal Ojha >> Date: Tue, Mar 4, 2014 at 11:20 AM >> Subject: Re: Review Request 18677: CLOUDSTACK-3272 >> To: Sonal Ojha , cloudstack < >> dev@cloudstack.apache.org> >> >> >>

[REMINDER] Review Request 18677: CLOUDSTACK-3272

Any updates? On Mon, Mar 10, 2014 at 10:01 AM, Sonal Ojha wrote: > Kindly let me know your review comments. > > -- Forwarded message -- > From: Sonal Ojha > Date: Tue, Mar 4, 2014 at 11:20 AM > Subject: Re: Review Request 18677: CLOUDSTACK-3272 > To: So

[REMINDER]Review Request 18677: CLOUDSTACK-3272

Kindly let me know your review comments. -- Forwarded message -- From: Sonal Ojha Date: Tue, Mar 4, 2014 at 11:20 AM Subject: Re: Review Request 18677: CLOUDSTACK-3272 To: Sonal Ojha , cloudstack < dev@cloudstack.apache.org> This is an automatically generated e-ma

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- (Updated March 4, 2014, 5:51 a.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review36094 --- - Sonal Ojha On March 3, 2014, 5:58 a.m., Sonal Ojha wrote: > > -

Review Request 18677: CLOUDSTACK-3272

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/ --- Review request for cloudstack. Repository: cloudstack-git Description ---