----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18677/#review42248 -----------------------------------------------------------
Patch applies, but does not build on master. please resolve check-style errors. - Murali Reddy On May 5, 2014, 10:56 a.m., Sonal Ojha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18677/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 10:56 a.m.) > > > Review request for cloudstack, Chiradeep Vittal and Murali Reddy. > > > Bugs: CLOUDSTACK-3272 > https://issues.apache.org/jira/browse/CLOUDSTACK-3272 > > > Repository: cloudstack-git > > > Description > ------- > > At present, there are multiple event types that are generated by CS, action > events,usage events, resource state change events and alerts. Current problem > is > all the events gets published on the event bus when event bus is enabled. > Intent is to introduce global setting config parameters to specify which > category of events to be published or not be published on the event bus. > > > Diffs > ----- > > server/src/com/cloud/configuration/Config.java 2d55f46 > server/src/com/cloud/event/ActionEventUtils.java 00122de > server/src/com/cloud/test/DatabaseConfig.java 9370218 > > Diff: https://reviews.apache.org/r/18677/diff/ > > > Testing > ------- > > Successfully tested publishing / not publishing of various events based on > the global parameter publish.*.events. > > > File Attachments > ---------------- > > Working patch for master (latest git commit 55f53e13e) > > https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch > Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335 > > https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch > > > Thanks, > > Sonal Ojha > >
