Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-04-09 Thread Axel Delahaye
> On April 9, 2014, 1:54 p.m., daan Hoogland wrote: > > Axel, > > > > 4.2 will not be worked on anymore. You can create a patched version for > > yourself if you need to. Next release will be either 4.3.1, 4.4.0 or 5.0.0 > > > > Also please submit a seperate review request for another branch i

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-04-09 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16688/#review39885 --- Axel, 4.2 will not be worked on anymore. You can create a patched v

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-04-03 Thread Daan Hoogland
Axel, did you change this already submitted change request? Or did you reuse the entry in the review boar to create a new review request? In both cases I'd rather have you close this one and create a new one. On Thu, Apr 3, 2014 at 6:51 PM, Axel Delahaye wrote: >This is an automatically gene

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-04-03 Thread Axel Delahaye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16688/ --- (Updated April 3, 2014, 4:51 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-03-04 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16688/#review36105 --- Ship it! eb2f323c48ac4d26d268cc5ee566520b475c74cf (note that needs

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-03-04 Thread daan Hoogland
> On March 4, 2014, 7:35 a.m., daan Hoogland wrote: > > This is ust for 4.2.x, does it apply to higher version as well or do you > > want to submit a separate patch for those? > > Axel Delahaye wrote: > I don't try it with newest cloudstack version (I don't have a 4.3) but if > the console

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-03-04 Thread Axel Delahaye
> On March 4, 2014, 7:35 a.m., daan Hoogland wrote: > > This is ust for 4.2.x, does it apply to higher version as well or do you > > want to submit a separate patch for those? I don't try it with newest cloudstack version (I don't have a 4.3) but if the console-proxy doesn't change a lot it ma

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-03-03 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16688/#review36098 --- This is ust for 4.2.x, does it apply to higher version as well or do

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-03-03 Thread Axel Delahaye
> On March 3, 2014, 9:23 a.m., daan Hoogland wrote: > > is this still a valid patch? should it be updated? I uploaded a new version for 4.2.1 systemvm - Axel --- This is an automatically generated e-mail. To reply, visit: https://review

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-03-03 Thread Axel Delahaye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16688/ --- (Updated March 3, 2014, 11:20 a.m.) Review request for cloudstack. Changes --

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-03-03 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16688/#review35950 --- is this still a valid patch? should it be updated? - daan Hoogland

Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-01-07 Thread Axel Delahaye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16688/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Re: Review Request 16688: console-proxy add support of AltGr key and FR azerty keyboard

2014-01-07 Thread Axel Delahaye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16688/ --- (Updated Jan. 7, 2014, 4:28 p.m.) Review request for cloudstack. Repository: