-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16688/
-----------------------------------------------------------
(Updated March 3, 2014, 11:20 a.m.)
Review request for cloudstack.
Changes
-------
Add new item in console proxy menu list : "French AZERTY keyboard" (So now I
don't replace the Standard (US) keyboard)
Add comment to describe the key before each rule : //[50 = ~]
Fix some key translation : (M,m)
Repository: cloudstack-git
Description
-------
Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in
ajaxviwer.js.
altgr : <altgr state match condition>, -- match on altgr state
It works like the shift match condition.
shift : <shift state match condition>, -- match on shift state
Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same
time.
So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr
key and 'altgr' condition will be true.
In the ajaxkey.js file you got for example:
{type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key
Secondly,
I wrote the French AZERTY translation table in ajaxkeys.js with the support of
AltGr character (like #{}[]|,etc.)
For example the '#':
{keycode: 51, entry: [ //User type the "3# key and each condition match
'altgr'
{type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC
AltGR key
{type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true}, //press the 3 key
{type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it
{type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true} //release the AltGr
key
]},
I replace the Standard (US) keyboard translation table because I can't add an
entry in the console proxy keyboard menu.
Thanks for watching my work
Axel Delahaye
Diffs (updated)
-----
services/console-proxy/server/css/ajaxviewer.css fd2fb3c
services/console-proxy/server/js/ajaxkeys.js 60c9798
services/console-proxy/server/js/ajaxviewer.js e5657e1
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
b3cda0b
Diff: https://reviews.apache.org/r/16688/diff/
Testing
-------
Tested with
Hardware : French AZERTY keyboard
Software : Configured in windows as FR keyboard
Console-proxy : Customized Standard (US) keyboard
Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
Guest keymap : fr, fr-pc
Only the "<" ">" key doesn't work
Thanks,
Axel Delahaye
