RE: Review Request 14827: hyperv unit tests

2013-10-28 Thread Anshul Gangwar
: dev@cloudstack.apache.org; Prasanna Santhanam; Rajesh Battala; Devdeep Singh; Chiradeep Vittal Cc: Anshul Gangwar Subject: RE: Review Request 14827: hyperv unit tests The mvn build flags are: -P hyperv-plugin for the C# portion of plugin -DskipTests=false for unit tests (platform independent

Re: Review Request 14827: hyperv unit tests

2013-10-28 Thread Prasanna Santhanam
> On Oct. 28, 2013, 8:25 a.m., Prasanna Santhanam wrote: > > Are we okay with putting in VisualStudio project files? We don't do the > > same for Eclipse. > > + > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj > > > > I guess there is a HOWTO somewhere on runni

RE: Review Request 14827: hyperv unit tests

2013-10-28 Thread Donal Lafferty
f > Of Prasanna Santhanam > Sent: 28 October 2013 11:20 > To: Rajesh Battala; Donal Lafferty; Devdeep Singh; Chiradeep Vittal > Cc: Prasanna Santhanam; Anshul Gangwar; cloudstack > Subject: Re: Review Request 14827: hyperv unit tests > > > > > On Oct. 28, 2013, 8:25 a.m.,

Re: Review Request 14827: hyperv unit tests

2013-10-28 Thread Prasanna Santhanam
> On Oct. 28, 2013, 8:25 a.m., Prasanna Santhanam wrote: > > Are we okay with putting in VisualStudio project files? We don't do the > > same for Eclipse. > > + > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj > > > > I guess there is a HOWTO somewhere on runni

Re: Review Request 14827: hyperv unit tests

2013-10-28 Thread Anshul Gangwar
> On Oct. 28, 2013, 8:25 a.m., Prasanna Santhanam wrote: > > Are we okay with putting in VisualStudio project files? We don't do the > > same for Eclipse. > > + > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj > > > > I guess there is a HOWTO somewhere on runni

Re: Review Request 14827: hyperv unit tests

2013-10-28 Thread Donal Lafferty
> On Oct. 28, 2013, 8:25 a.m., Prasanna Santhanam wrote: > > Are we okay with putting in VisualStudio project files? We don't do the > > same for Eclipse. > > + > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj > > > > I guess there is a HOWTO somewhere on runni

Re: Review Request 14827: hyperv unit tests

2013-10-28 Thread Prasanna Santhanam
> On Oct. 28, 2013, 8:25 a.m., Prasanna Santhanam wrote: > > Are we okay with putting in VisualStudio project files? We don't do the > > same for Eclipse. > > + > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj > > > > I guess there is a HOWTO somewhere on runni

Re: Review Request 14827: hyperv unit tests

2013-10-28 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14827/#review27604 --- Are we okay with putting in VisualStudio project files? We don't do

Re: Review Request 14827: hyperv unit tests

2013-10-28 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14827/#review27603 --- Ship it! LGTM - Rajesh Battala On Oct. 23, 2013, 11:05 a.m., An

Re: Review Request 14827: hyperv unit tests

2013-10-27 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14827/#review27588 --- Ship it! Ship It! - Devdeep Singh On Oct. 23, 2013, 11:05 a.m.,

Re: Review Request 14827: hyperv unit tests

2013-10-23 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14827/ --- (Updated Oct. 23, 2013, 11:05 a.m.) Review request for cloudstack, Chiradeep Vi

Review Request 14827: hyperv unit tests

2013-10-22 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14827/ --- Review request for cloudstack, Chiradeep Vittal, Devdeep Singh, Donal Lafferty,