> On Oct. 28, 2013, 8:25 a.m., Prasanna Santhanam wrote: > > Are we okay with putting in VisualStudio project files? We don't do the > > same for Eclipse. > > + > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj > > > > I guess there is a HOWTO somewhere on running the NUnit tests? > > > > Also, isn't .vhdx a binary file? > > Prasanna Santhanam wrote: > May be the .vhdx should contain a ASF license header. It seems to be a > dummy file. > > Donal Lafferty wrote: > Hi Prasanna, > > VisualStudio's .sln and .csproj files provide functionality equivalent to > Maven's pom.xml User specific settings are in a .suo file along side the > .sln, but this has not been included in the diff. > > WRT running the NUnit tests, they are triggered automatically as part of > the hyperv-plugin profile. Should we add a README.txt? > > The .vhdx is a dummy file used in functional tests. It may be worth > considering downloading this separate to source, as we do with the system VM > templates. > > My 2cents...
I will remove the .vhdx file and will create the file for test dynamically As Donal mentioned NUnit tests will be triggered automatically as part of the hyperv-plugin profile. skipTests switch is used to trigger them/skip them - Anshul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14827/#review27604 ----------------------------------------------------------- On Oct. 23, 2013, 11:05 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14827/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 11:05 a.m.) > > > Review request for cloudstack, Chiradeep Vittal, Devdeep Singh, Donal > Lafferty, and Rajesh Battala. > > > Repository: cloudstack-git > > > Description > ------- > > Hyperv Unit tests written using NSubstitute and XUnit. Description for this > can be found at > > http://nsubstitute.github.io/help/getting-started/ > http://xunit.codeplex.com/wikipage?title=HowToUse > http://xunit.codeplex.com/wikipage?title=Comparisons > > Currently packages have to be manually copied for Linux. buildagent script is > not downloading them. > > I have also changed the existing tests to xunit > > > Diffs > ----- > > plugins/hypervisors/hyperv/DotNet/ServerResource/.gitignore cf9cb85 > plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config > PRE-CREATION > plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.targets > PRE-CREATION > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.Designer.cs > a73e6bb > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings > 435b8e0 > > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj > fe055d0 > plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/packages.config > f5f47e6 > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResource.csproj > dbd7b15 > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs > 7a0c2db > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCalls.cs > PRE-CREATION > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs > PRE-CREATION > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCalls.cs > 1b9e073 > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs > 7557320 > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/packages.config > b0f2ace > > plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/App.config > 1bf17d4 > > plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/HypervResourceController1Test.cs > PRE-CREATION > > plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/HypervResourceControllerTest.cs > 8a86727 > > plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/ServerResource.Tests.csproj > 381245e > > plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/packages.config > 08ef691 > > plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj > d3baab4 > plugins/hypervisors/hyperv/buildagent.sh f2a4921 > > plugins/hypervisors/hyperv/var/test/storagepool/TestCopiedLocalTemplate.vhdx > PRE-CREATION > > Diff: https://reviews.apache.org/r/14827/diff/ > > > Testing > ------- > > > Thanks, > > Anshul Gangwar > >
