Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- (Updated Oct. 23, 2013, 7:19 p.m.) Review request for cloudstack, Brian Federle

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- (Updated Oct. 22, 2013, 9:53 p.m.) Review request for cloudstack, Brian Federle

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27335 --- Please use the --squash option when creating the patch to keep the m

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- (Updated Oct. 22, 2013, 9:37 p.m.) Review request for cloudstack, Brian Federle

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27333 --- Please rebase and provide a squashed patch. - John Burwell On Oct

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 22, 2013, 4:04 p.m., John Burwell wrote: > > Merge of the patch failed. Please rebase your local branch, test, and > > re-generate the patch. I've rebased and added the 4 patches. Please give those a try. - Chris --- This is

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- (Updated Oct. 22, 2013, 4:42 p.m.) Review request for cloudstack, Brian Federle

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27303 --- Merge of the patch failed. Please rebase your local branch, test, a

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27302 --- Ship it! Ship It! - John Burwell On Oct. 22, 2013, 10:48 a.m., C

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- (Updated Oct. 22, 2013, 2:48 p.m.) Review request for cloudstack, Brian Federle

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27300 --- engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 22, 2013, 1:32 p.m., John Burwell wrote: > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java, > > line 81 > > > > > > Convert these lines to a StringUtils.join.

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27298 --- engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

Chris, I am in-transit to CloudConnect. I will try to review the latest patch by COB today (21 Oct 2013). Thanks, -John On Oct 21, 2013, at 9:31 AM, "SuichII, Christopher" wrote: John, Will you be able to take a look at this revision soon? It is a small change to address your comments s

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

John, Will you be able to take a look at this revision soon? It is a small change to address your comments so it should not take very long. Thanks, Chris -- Chris Suich chris.su...@netapp.com NetApp Software Engineer Data Center Platforms – Cloud Solutions Citrix,

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 17, 2013, 3:18 p.m., John Burwell wrote: > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java, > > line 62 > > > > > > Add context information to error message to

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- (Updated Oct. 17, 2013, 6:46 p.m.) Review request for cloudstack, Brian Federle

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 17, 2013, 11:18 a.m., John Burwell wrote: > > ui/scripts/storage.js, line 1963 > > > > > > How will a corrupted snapshot failure be surfaced to the user? > > Chris Suich wrote: > It depends on what you

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 17, 2013, 3:18 p.m., John Burwell wrote: > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java, > > line 62 > > > > > > Add context information to error message to

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27127 --- Overall, this patch is very close to ready. I really like the way t

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27126 --- engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- (Updated Oct. 16, 2013, 2:50 p.m.) Review request for cloudstack, Brian Federle

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 15, 2013, 2:41 p.m., John Burwell wrote: > > engine/storage/integration-test/test/org/apache/cloudstack/storage/test/SnapshotTest.java, > > line 437 > > > > > > *This comment may be more editorial at this po

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 15, 2013, 2:41 p.m., John Burwell wrote: > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java, > > line 28 > > > > > > I don't know that a flag is necessary to rep

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 15, 2013, 10:41 a.m., John Burwell wrote: > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java, > > line 28 > > > > > > I don't know that a flag is necessary to re

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 15, 2013, 2:41 p.m., John Burwell wrote: > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java, > > line 28 > > > > > > I don't know that a flag is necessary to rep

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 15, 2013, 2:41 p.m., John Burwell wrote: > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java, > > line 28 > > > > > > I don't know that a flag is necessary to rep

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 15, 2013, 10:41 a.m., John Burwell wrote: > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java, > > line 28 > > > > > > I don't know that a flag is necessary to re

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 15, 2013, 2:41 p.m., John Burwell wrote: > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java, > > line 28 > > > > > > I don't know that a flag is necessary to rep

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27021 --- api/src/org/apache/cloudstack/api/response/SnapshotResponse.java

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- (Updated Oct. 14, 2013, 10:50 p.m.) Review request for cloudstack, Brian Federl

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review26989 --- Ship it! Ship It! - edison su On Oct. 7, 2013, 8:26 p.m., Chris

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

Just sent you an e-mail chain under the subject: [DISCUSS/PROPOSAL] Upgrading Driver Model On Wed, Oct 9, 2013 at 2:17 PM, SuichII, Christopher wrote: > Well then, I think sending back a list of supported operations with > volumes would be a good start. Eventually, this could be extended to hav

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

Well then, I think sending back a list of supported operations with volumes would be a good start. Eventually, this could be extended to have supported fields as well. While it does cost some overhead up front to load the supported operations from storage providers when listing volumes, I think

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

"Has there been any thoughts to allow storage providers to indicate which features they support?" We talked about this for a while at the CloudStack Collaboration Conference in Santa Clara. Right now, this is not supported and that's a serious problem. This kind of ties in with Storage Tagging a

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

Just bumping this since there haven't been any responses. Does anyone have any thoughts on this? I'm ready and prepared to do the work, but I don't want to move on if people have concerns with this approach or can think of a better solution. -Chris -- Chris Suich chris.su...@netapp.com

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

> On Oct. 8, 2013, 8:18 p.m., edison su wrote: > > ui/scripts/storage.js, line 1763 > > > > > > The ui change here, is there way to disable it from ui, if the storage > > provider is not NetApp? Or move the ui change

Re: Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review26786 --- ui/scripts/storage.js

Review Request 14522: [CLOUDSTACK-4771] Support Revert VM Disk from Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/ --- Review request for cloudstack, Brian Federle and edison su. Repository: cloudst