----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14522/#review27333 -----------------------------------------------------------
Please rebase and provide a squashed patch. - John Burwell On Oct. 22, 2013, 12:42 p.m., Chris Suich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14522/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2013, 12:42 p.m.) > > > Review request for cloudstack, Brian Federle, edison su, John Burwell, and > Mike Tutkowski. > > > Repository: cloudstack-git > > > Description > ------- > > After the last batch of work to the revertSnapshot API, SnapshotServiceImpl > was not tied into the workflow to be used by storage providers. I have added > the logic in a similar fashion to takeSnapshot(), backupSnapshot() and > deleteSnapshot(). > > I have also added a 'Revert to Snapshot' action to the volume snapshots list > in the UI. > > > Diffs > ----- > > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java > 2d31320 > server/src/com/cloud/api/ApiResponseHelper.java 6978c9b > > Diff: https://reviews.apache.org/r/14522/diff/ > > > Testing > ------- > > I have tested all of this locally with a custom storage provider. > > Unfortunately, I'm still in the middle of figuring out how to properly unit > test this type of code. If anyone has any recommendations, please let me know. > > > File Attachments > ---------------- > > > > https://reviews.apache.org/media/uploaded/files/2013/10/22/0001-Added-volume-snapshot-revert-capability-to-SnapshotR.patch > > > https://reviews.apache.org/media/uploaded/files/2013/10/22/0002-Updated-inefficient-strategy-sorting-selection.patch > > > https://reviews.apache.org/media/uploaded/files/2013/10/22/0003-Added-context-to-strategy-sorting-error-responses.patch > > > https://reviews.apache.org/media/uploaded/files/2013/10/22/0004-Updated-DataMotionServiceImpl-and-ApiResponseHelper-.patch > > > Thanks, > > Chris Suich > >
