Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-30 Thread Gaurav Aradhye
> On Oct. 29, 2013, 11:38 p.m., SrikanteswaraRao Talluri wrote: > > Committed by Talluri Master - 8a6694b396500897a3d5ce3f292864f2c5c2530f 4.2 - c6ce74fe61ae463a964215ab892c6cb399909801 - Gaurav --- This is an automatically generated e

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-29 Thread SrikanteswaraRao Talluri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27707 --- Ship it! - SrikanteswaraRao Talluri On Oct. 24, 2013, 2:07 p.m.,

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-24 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/ --- (Updated Oct. 24, 2013, 7:37 p.m.) Review request for cloudstack, bharat kumar

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-23 Thread sanjeev n
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27374 --- test/integration/component/test_non_contiguous_vlan.py

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-23 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27377 --- test/integration/component/test_non_contiguous_vlan.py

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-23 Thread Girish Shilamkar
On Oct. 23, 2013, 9:08 a.m., Gaurav Aradhye wrote: > > The naming of the tests should be improved. test_01/02/03 doesn't tell much > > about the test. Also is the ordering strictly required? Can I reorder the > > tests and still expect the tests to pass? If not, we should remove the 01 , > > 0

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-23 Thread Prasanna Santhanam
On Oct. 23, 2013, 9:08 a.m., Gaurav Aradhye wrote: > > The naming of the tests should be improved. test_01/02/03 doesn't tell much > > about the test. Also is the ordering strictly required? Can I reorder the > > tests and still expect the tests to pass? If not, we should remove the 01 , > > 0

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-23 Thread Gaurav Aradhye
On Oct. 23, 2013, 2:38 p.m., Gaurav Aradhye wrote: > > The naming of the tests should be improved. test_01/02/03 doesn't tell much > > about the test. Also is the ordering strictly required? Can I reorder the > > tests and still expect the tests to pass? If not, we should remove the 01 , > > 0

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-23 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27372 --- test/integration/component/test_non_contiguous_vlan.py

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-23 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/ --- (Updated Oct. 23, 2013, 9:01 a.m.) Review request for cloudstack, bharat kumar

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-15 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/ --- (Updated Oct. 15, 2013, 7:25 p.m.) Review request for cloudstack, Harikrishna P

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-15 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/ --- (Updated Oct. 15, 2013, 7:23 p.m.) Review request for cloudstack, Harikrishna P

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-15 Thread Gaurav Aradhye
> On Oct. 15, 2013, 4:08 p.m., venkata swamy babu budumuru wrote: > > test/integration/component/test_non_contiguous_vlan.py, line 117 > > > > > > 1. Have something like "self.phy_network" instead of slf.network. This

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-15 Thread Gaurav Aradhye
> On Oct. 15, 2013, 4:08 p.m., venkata swamy babu budumuru wrote: > > test/integration/component/test_non_contiguous_vlan.py, line 311 > > > > > > I dont see this instructions and the steps mentioned in the doc string

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-15 Thread venkata swamy babu budumuru
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/#review27016 --- test/integration/component/test_non_contiguous_vlan.py

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-09-30 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/ --- (Updated Sept. 30, 2013, 1:51 p.m.) Review request for cloudstack, Harikrishna

Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-09-24 Thread Gaurav Aradhye
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14319/ --- Review request for cloudstack, Harikrishna Patnala, venkata swamy babu budumuru