Re: Review Request 14084: Updates to @ActionEvent to be compatible with Spring AOP

2013-09-13 Thread Kelven Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14084/#review26086 --- Ship it! - Kelven Yang On Sept. 11, 2013, 5:07 p.m., Darren Sheph

Re: Review Request 14084: Updates to @ActionEvent to be compatible with Spring AOP

2013-09-13 Thread Darren Shepherd
> On Sept. 13, 2013, 6:17 p.m., Kelven Yang wrote: > > Was this actually committed? - Darren --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14084/#review26086 ---

Re: Review Request 14084: Updates to @ActionEvent to be compatible with Spring AOP

2013-09-13 Thread Darren Shepherd
> On Sept. 12, 2013, 5:28 p.m., Kelven Yang wrote: > > Darren, I saw you added the annotation for group of events and annotated in > > various places, is there any test done for the business logic validation? I added an annotation @ActionEvents and its used in only one place and that is on Acc

Re: Review Request 14084: Updates to @ActionEvent to be compatible with Spring AOP

2013-09-13 Thread Kelven Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14084/#review26056 --- Darren, I saw you added the annotation for group of events and annot

Review Request 14084: Updates to @ActionEvent to be compatible with Spring AOP

2013-09-11 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14084/ --- Review request for cloudstack, Kelven Yang and Kishan Kavala. Repository: cloud