----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14084/#review26086 -----------------------------------------------------------
Ship it! - Kelven Yang On Sept. 11, 2013, 5:07 p.m., Darren Shepherd wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14084/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2013, 5:07 p.m.) > > > Review request for cloudstack, Kelven Yang and Kishan Kavala. > > > Repository: cloudstack-git > > > Description > ------- > > Two fields were added to CallContext to allow call to dynamically change > the event type and description. Additionally a @ActionEvents annotation > was added to allow a method to specify multiple events > > Spring AOP will not intercept calls to "this" so @ActionEvent needs to be > put on public methods that are externally invoked > > Annotations that needed to be changed were identified by doing byte code > analysis using objectweb asm. Code for that is at > https://github.com/ibuildthecloud/cloudstack-findbadactionevents and there > are instructions to run it there. > > > Diffs > ----- > > api/src/com/cloud/event/ActionEvents.java PRE-CREATION > api/src/org/apache/cloudstack/context/CallContext.java > e3c1bf2a7b97573cdeb4f530d0afe74cb7e3e834 > engine/components-api/src/com/cloud/configuration/ConfigurationManager.java > 6e76b6ffb91c200127589831893d9d79970aafdb > engine/components-api/src/com/cloud/network/rules/FirewallManager.java > fa12cd804a67138740f9d9042709938871dc8629 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java > fb727a1705487416b7069fc2aca5086fd726e700 > server/src/com/cloud/event/ActionEventInterceptor.java > ba7e270af90f7bc191b570a7cc131319f446e2f6 > server/src/com/cloud/event/ActionEventUtils.java > 60f5633fc3c53dac960247308de12b60b492de59 > server/src/com/cloud/network/firewall/FirewallManagerImpl.java > cd83c4e52f85adc9c9d9c7997c28838f2c15b323 > server/src/com/cloud/server/ManagementServerImpl.java > a3efd2129ce082023d79e55872e8134d1b6bd85c > server/src/com/cloud/user/AccountManagerImpl.java > 0602514fcf429b09a62edf65f4b0dc0e87d80b94 > server/src/com/cloud/vm/UserVmManagerImpl.java > c3a718ac55be05f123b062a627c2de042c4321ab > server/test/com/cloud/network/MockFirewallManagerImpl.java > c50459e98737eaf5662bb44c6e9a12fad54b4175 > server/test/com/cloud/vpc/MockConfigurationManagerImpl.java > 3ec146b953726c9480b1e15848a67e4746dd65a6 > > Diff: https://reviews.apache.org/r/14084/diff/ > > > Testing > ------- > > > Thanks, > > Darren Shepherd > >
