Re: Review Request 13192: create private network test

2013-08-02 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/#review24571 --- Ship it! Needs license headers. Fixed locally and committed. Please

Re: Review Request 13192: create private network test

2013-08-02 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/ --- (Updated Aug. 2, 2013, 8:24 p.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 13192: create private network test

2013-08-02 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/ --- (Updated Aug. 2, 2013, 8:23 p.m.) Review request for cloudstack, Koushik Das an

Re: Review Request 13192: create private network test

2013-08-02 Thread daan Hoogland
> On Aug. 2, 2013, 5:26 p.m., Chiradeep Vittal wrote: > > server/test/com/cloud/network/CreatePrivateNetworkTest.java, line 163 > > > > > > Use logger.error instead of printStackTrace? This way the logfile will > > co

Re: Review Request 13192: create private network test

2013-08-02 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/#review24547 --- server/test/com/cloud/network/CreatePrivateNetworkTest.java

Re: Review Request 13192: create private network test

2013-08-01 Thread Daan Hoogland
someone broke the jenkins patch submission builds with a checkin. I think no patch passes jenkins anymore because of the usage server not building anymore. The patch build in my env in two different branches (master and my work branch). The Apache CloudStack Server4.6 sec << my changes Apache Clo

Re: Review Request 13192: create private network test

2013-08-01 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/#review24443 --- Review 13192 failed the build test : FAILURE The url of build clouds

Review Request 13192: create private network test

2013-08-01 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/ --- Review request for cloudstack, Koushik Das and Sheng Yang. Bugs: CLOUDSTACK-153