> On Aug. 2, 2013, 5:26 p.m., Chiradeep Vittal wrote: > > server/test/com/cloud/network/CreatePrivateNetworkTest.java, line 163 > > <https://reviews.apache.org/r/13192/diff/1/?file=332329#file332329line163> > > > > Use logger.error instead of printStackTrace? This way the logfile will > > contain the error.
will do - daan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/#review24547 ----------------------------------------------------------- On Aug. 1, 2013, 2:52 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13192/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 2:52 p.m.) > > > Review request for cloudstack, Koushik Das and Sheng Yang. > > > Bugs: CLOUDSTACK-1532 > > > Repository: cloudstack-git > > > Description > ------- > > This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It > occurred to me it can be submitted separately. > > > Diffs > ----- > > server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/13192/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > >
