> On Nov. 8, 2013, 2:03 a.m., Amogh Vasekar wrote:
> > Reminder -
> > Hi,
> > This review has been pending for long. Request the reviewer to provide
> > comments.
> > Thanks
Appears to be committed in: 4e0e7410e99c7f57cde934af1fef9b27d0ae1e66
- David
--
> On Aug. 14, 2013, 5:31 p.m., Marcus Sorensen wrote:
> > Any comments?
Reminder -
Hi,
This review has been pending for long. Request the reviewer to provide comments.
Thanks
- Amogh
---
This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review28482
---
Reminder -
Hi,
This review has been pending for long. Request the r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review25153
---
Any comments?
- Marcus Sorensen
On Aug. 6, 2013, 10:32 p.m., Marc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/
---
(Updated Aug. 6, 2013, 10:32 p.m.)
Review request for cloudstack.
Changes
---
alse,"vmName":"i-2-45-VM","wait":0}}] }
> >
> >
> >The changes you have made would definitely improve the readability.
> >
> >-Koushik
> >
> >From: Marcus Sorensen [mailto:shadow...@gmail.com]
> >Sent: Thursday, August 0
> Cc: cloudstack; Alex Huang
> Subject: Re: Review Request 13072: Print agent host name in logging of agent
> commands
>
> This of course introduces an extra DB call during EVERY agent communication.
> If there was a cache, not a big deal, but as it so happens, there isn't on
Ver: v1,
>Flags: 100011,
>[{"com.cloud.agent.api.StopCommand":{"isProxy":false,"executeInSequence":f
>alse,"vmName":"i-2-45-VM","wait":0}}] }
>
>
>The changes you have made would definitely improve the readability.
>
>-K
cus Sorensen [mailto:shadow...@gmail.com]
Sent: Thursday, August 01, 2013 7:26 PM
To: Koushik Das
Cc: cloudstack
Subject: Re: Review Request 13072: Print agent host name in logging of agent
commands
I agree, that would be useful.
The issue im resolving here is that 1) not everyone who has access
I agree, that would be useful.
The issue im resolving here is that 1) not everyone who has access to look
at the logs and troubleshoot also has access to (or knows the schema of)
the database. There might be an issue with a KVM host, but the admin will
waste time manually hunting down which host t
> On Aug. 1, 2013, 12:06 p.m., Koushik Das wrote:
> > The changes look fine but I don't see much value with this as the name can
> > be easily identified from the db. I feel the logs are used primarily for
> > debugging issues. And one key aspect that is missing currently is the
> > correlatio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review24435
---
The changes look fine but I don't see much value with this as the na
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review24262
---
Review 13072 PASSED the build test
The url of build cloudstack-maste
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/
---
Review request for cloudstack.
Bugs: CLOUDSTACK-3872
Repository: cloudstack-g
14 matches
Mail list logo
