----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13072/ -----------------------------------------------------------
(Updated Aug. 6, 2013, 10:32 p.m.) Review request for cloudstack. Changes ------- Here's an updated patch, addressing our concerns about extra db lookups. This stows the agent host name in the attache so that it can be retrieved wherever needed, rather than looking up the host in the db every time a Command is sent to agent. Tested in a KVM environment on a fresh 4.2 install, as well as in an existing 4.1 install (applied with fuzz). I'm not sure how/if this will affect Xen or VMware. Bugs: CLOUDSTACK-3872 Repository: cloudstack-git Description ------- Print agent name when logging Commands sent to VM hosts. See bug description. I'm not super familiar with this code, so I'd like someone to look over it and verify it's the right thing. Diffs (updated) ----- core/src/com/cloud/agent/transport/Request.java b0fa4cc server/src/com/cloud/agent/manager/AgentAttache.java 1785bcf server/src/com/cloud/agent/manager/AgentManagerImpl.java b157838 server/src/com/cloud/agent/manager/ClusteredAgentAttache.java 058a904 server/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java 4fdb3c6 server/src/com/cloud/agent/manager/ClusteredDirectAgentAttache.java 9012433 server/src/com/cloud/agent/manager/ConnectedAgentAttache.java c98307b server/src/com/cloud/agent/manager/DirectAgentAttache.java 9b7d69f server/src/com/cloud/agent/manager/DummyAttache.java 14286d2 Diff: https://reviews.apache.org/r/13072/diff/ Testing ------- Tested on KVM zone, need help testing others. Thanks, Marcus Sorensen
