Re: Review Request 12896: General clean up of ldapplugin

2013-07-25 Thread Sebastien Goasguen
ok On Jul 25, 2013, at 9:56 AM, "Ian Duffy" wrote: > > >> On July 25, 2013, 1:52 p.m., Sebastien Goasguen wrote: >>> Has this been applied ?I don't see a commit hash > > Hi Sebastien. > > This was applied but not directly via this request, which is why this was > discarded. > > The LDAPPlu

Re: Review Request 12896: General clean up of ldapplugin

2013-07-25 Thread Ian Duffy
> On July 25, 2013, 1:52 p.m., Sebastien Goasguen wrote: > > Has this been applied ?I don't see a commit hash Hi Sebastien. This was applied but not directly via this request, which is why this was discarded. The LDAPPlugin branch was updated with master and new patches that related to the L

Re: Review Request 12896: General clean up of ldapplugin

2013-07-25 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23840 --- Has this been applied ?I don't see a commit hash - Sebastien Goasgu

Re: Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23763 --- Ship it! Ship It! - Abhinandan Prateek On July 24, 2013, 10:26 a

Re: Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Ian Duffy
> On July 24, 2013, 10:30 a.m., Jenkins Cloudstack.org wrote: > > Review 12896 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #29 is : > > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/29/ Jenkins attempted to patch master... patch is for ldap

Re: Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23746 --- Review 12896 failed the build test : FAILURE The url of build clouds

Review Request 12896: General clean up of ldapplugin

2013-07-24 Thread Ian Duffy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/ --- Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Repos